[PR PATCH] New package: python3 tasklib

[PR PATCH] New package: python3 tasklib

[Pinoinha]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is a new pull request by Pinoinha against master on the void-packages repository

https://github.com/Pinoinha/void-packages new-package-python3-tasklib
https://github.com/void-linux/void-packages/pull/34125

New package: python3 tasklib
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64


A patch file from https://github.com/void-linux/void-packages/pull/34125.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-new-package-python3-tasklib-34125.patch --]
[-- Type: text/x-diff, Size: 2950 bytes --]

From 840b47d72555969b55d3739f5e30e5fb07fdd5eb Mon Sep 17 00:00:00 2001
From: Matheus R <matheusrbarros03@gmail.com>
Date: Wed, 17 Nov 2021 11:20:44 -0300
Subject: [PATCH 1/3] New package: vit 2.1.0

---
 srcpkgs/vit/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/vit/template

diff --git a/srcpkgs/vit/template b/srcpkgs/vit/template
new file mode 100644
index 000000000000..19810682e46b
--- /dev/null
+++ b/srcpkgs/vit/template
@@ -0,0 +1,19 @@
+# Template file for 'vit'
+pkgname=vit
+version=2.1.0
+revision=0
+build_style=python3-module
+hostmakedepends="python3-pip task python3-pytz python3-urwid python3-tzlocal"
+depends="task"
+checkdepends=
+short_desc="VIT is a lightweight, fast, curses-based front end to Taskwarrior "
+maintainer="pinoinha <pinoinha@disroot.org"
+license="MIT"
+homepage="https://github.com/vit-project/vit"
+changelog="https://raw.githubusercontent.com/vit-project/vit/2.x/CHANGES.md"
+distfiles="${homepage}/archive/refs/tags/v${version}.tar.gz"
+checksum=56676651164fb71878a0c1e4bb369cfa336d46e6fd0de7e6167b57fca7eaf662
+
+pre_build() {
+	pip3 install tasklib
+}

From 6d54abb0402e1a00677aef084a1b50f5d9cdf4de Mon Sep 17 00:00:00 2001
From: Matheus R <matheusrbarros03@gmail.com>
Date: Wed, 17 Nov 2021 20:09:46 -0300
Subject: [PATCH 2/3] New package: tasklib

---
 srcpkgs/python3-tasklib/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/python3-tasklib/template

diff --git a/srcpkgs/python3-tasklib/template b/srcpkgs/python3-tasklib/template
new file mode 100644
index 000000000000..4b3661bc5d81
--- /dev/null
+++ b/srcpkgs/python3-tasklib/template
@@ -0,0 +1,13 @@
+# Template file for 'python3-tasklib'
+pkgname=python3-tasklib
+version=2.4.3
+revision=4
+build_style="python3-module"
+hostmakedepends="python3-setuptools"
+depends="python3-tzlocal task"
+short_desc="A Python library for interacting with taskwarrior databases. "
+maintainer="pinoinha <pinoinha@disroot.org>"
+license="BSD-3-Clause License"
+homepage="https://github.com/GothenburgBitFactory/tasklib"
+distfiles="https://github.com/GothenburgBitFactory/tasklib/archive/refs/tags/${version}.tar.gz"
+checksum=2c0c8fc5b40631fb0e9df147dae49713d93918f7ca3e1c05437e3bbdaaf6b3cd

From ea8691775ddb04b4491f90579fc290367ff62bef Mon Sep 17 00:00:00 2001
From: Matheus R <matheusrbarros03@gmail.com>
Date: Wed, 17 Nov 2021 20:46:58 -0300
Subject: [PATCH 3/3] New package: python3-tasklib

---
 srcpkgs/python3-tasklib/template | 1 +
 1 file changed, 1 insertion(+)

diff --git a/srcpkgs/python3-tasklib/template b/srcpkgs/python3-tasklib/template
index 4b3661bc5d81..a34e7d015a0e 100644
--- a/srcpkgs/python3-tasklib/template
+++ b/srcpkgs/python3-tasklib/template
@@ -2,6 +2,7 @@
 pkgname=python3-tasklib
 version=2.4.3
 revision=4
+wrksrc="tasklib-${version}"
 build_style="python3-module"
 hostmakedepends="python3-setuptools"
 depends="python3-tzlocal task"

Re: [PR REVIEW] New package: python3 tasklib

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34125#discussion_r751786233

Comment:
Add `python3-tasklib` to `hostmakedepends`.

Re: New package: python3 tasklib

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34125#issuecomment-972366924

Comment:
Actually, this should be together with the `vit` PR.

Re: New package: python3 tasklib

[Pinoinha]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

New comment by Pinoinha on void-packages repository

https://github.com/void-linux/void-packages/pull/34125#issuecomment-972368562

Comment:
> Actually, this should be together with the `vit` PR.

thank you for the warning. I'm new to contributing, so am still learning the "etiquette"

will close this PR in favor of the vit PR

Re: [PR PATCH] [Closed]: New package: python3 tasklib

[Pinoinha]

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There's a closed pull request on the void-packages repository

New package: python3 tasklib
https://github.com/void-linux/void-packages/pull/34125

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64

Re: [PR REVIEW] New package: python3 tasklib

[Pinoinha]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New review comment by Pinoinha on void-packages repository

https://github.com/void-linux/void-packages/pull/34125#discussion_r751789111

Comment:
just as a clarification: is this line needed? in the vit PR a fellow contributor said it shouldn't be essential

also the template already installs the files in the system