From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: owncloudclient: update to 2.9.1, fix tests
Date: Thu, 18 Nov 2021 15:16:18 +0100 [thread overview]
Message-ID: <20211118141618.jGyOaD6-pCLFVR2RwvFm2I_lP98PjIoi32CHjIgJk8w@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34131@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/34131#issuecomment-972905223
Comment:
TL;DR: don't merge now, I'll make CI pass.
What happened: there's another test that assumes non-root but for some reason passes on my local xbps-src so I didn't disable it, but I will so we can get CI to pass (I like green checkmarks, they make me salivate).
For reference: https://github.com/owncloud/client/commit/d987a7e7cb19367d708e21f9ef881afecffe35a3
That patch is merged in the development branch of owncloudclient. However, it tests for root with `getuid() == 0` which, at least on my local xbps-src, is false, so that patch alone is not enough to pass tests. What's the recommended way to change that so it works properly in xbps-src (the only thing that comes to my mind is to replace `getuid() == 0` by `1` and be done with it, but I don't think upstream will accept that change -- if only there was a way to fix it that was upstream-friendly...).
next prev parent reply other threads:[~2021-11-18 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 12:51 [PR PATCH] " tornaria
2021-11-18 14:16 ` tornaria [this message]
2021-11-18 14:25 ` [PR PATCH] [Updated] " tornaria
2021-11-18 14:30 ` tornaria
2021-11-18 22:52 ` tornaria
2021-11-21 18:26 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118141618.jGyOaD6-pCLFVR2RwvFm2I_lP98PjIoi32CHjIgJk8w@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).