Github messages for voidlinux
 help / color / mirror / Atom feed
From: mobinmob <mobinmob@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] stremio-shell: fix server start, adopt.
Date: Sat, 20 Nov 2021 16:29:35 +0100	[thread overview]
Message-ID: <20211120152935.hxrVYVr0IOIn3Iwwncv1RdL4WQ0CS4_rCcz_226-9JE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34123@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

There is an updated pull request by mobinmob against master on the void-packages repository

https://github.com/mobinmob/void-packages stremio-shell
https://github.com/void-linux/void-packages/pull/34123

stremio-shell: fix server start, adopt.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34123.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-stremio-shell-34123.patch --]
[-- Type: text/x-diff, Size: 2698 bytes --]

From 9dd9cacb85139420308b2547da236357f4a84247 Mon Sep 17 00:00:00 2001
From: mobinmob <mobinmob@disroot.org>
Date: Wed, 17 Nov 2021 23:24:18 +0200
Subject: [PATCH] stremio-shell: fix server start, adopt.

---
 srcpkgs/stremio-shell/template | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/srcpkgs/stremio-shell/template b/srcpkgs/stremio-shell/template
index 3d29d1da3303..5e74be56b18e 100644
--- a/srcpkgs/stremio-shell/template
+++ b/srcpkgs/stremio-shell/template
@@ -1,7 +1,7 @@
 # Template file for 'stremio-shell'
 pkgname=stremio-shell
 version=4.4.142
-revision=2
+revision=3
 _singleapplication_hash=4aeac8fa3e7e96385ba556346ebb6020e35ffdd8
 _libmpv_hash=822a41a1087daf2911fc336fbd9509f962158fef
 build_style=qmake
@@ -12,7 +12,7 @@ makedepends="mpv-devel qt5-webview-devel qt5-webengine-devel
 depends="qt5-quickcontrols qt5-quickcontrols2 virtual?nodejs-runtime
  qt5-webengine"
 short_desc="Hub for video content aggregation"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="mobinmob <mobinmob@disroot.org>"
 license="GPL-3.0-or-later"
 homepage="https://www.stremio.com"
 distfiles="https://github.com/Stremio/stremio-shell/archive/v${version}.tar.gz
@@ -35,21 +35,27 @@ post_extract() {
 }
 
 post_install() {
+
 	# Fix the bizarre locations
 	vmkdir usr/lib/stremio
-	mv "${DESTDIR}"/usr/opt/stremio/stremio ${DESTDIR}/usr/lib/stremio
+	mv "${DESTDIR}/usr/opt/stremio/stremio" "${DESTDIR}/usr/lib/stremio"
 
+	# Move .desktop file to proper location
 	vmkdir usr/share/applications
-	mv "${DESTDIR}"/usr/opt/stremio/smartcode-stremio.desktop ${DESTDIR}/usr/share/applications
+	mv "${DESTDIR}/usr/opt/stremio/smartcode-stremio.desktop" "${DESTDIR}/usr/share/applications"
+
+	# Link executable in PATH
+	vmkdir usr/bin
+	ln -s /usr/lib/stremio/stremio "${DESTDIR}/usr/bin/stremio"
 
-	echo "#!/bin/sh" > stremio
-	echo "cd /usr/lib/stremio && exec ./stremio" >> stremio
-	vbin stremio
+	# Symlink node in the instalation directory
+	ln -s /usr/bin/node "${DESTDIR}/usr/lib/stremio/node"
 
-	echo "#!/bin/sh" > stremio-server
-	echo "cd /usr/lib/stremio && exec node server.js" >> stremio-server
-	vbin stremio-server
+	# Install icon
+	vmkdir usr/share/icons
+	cp "${wrksrc}/images/stremio_window.png" "${DESTDIR}/usr/share/icons/smartcode-stremio.png"
 
-	cp ${XBPS_SRCDISTDIR}/${pkgname}-${version}/server.js ${DESTDIR}/usr/lib/stremio
-	cp ${XBPS_SRCDISTDIR}/${pkgname}-${version}/stremio.asar ${DESTDIR}/usr/lib/stremio
+	# Copy server
+	cp "${XBPS_SRCDISTDIR}/${pkgname}-${version}/server.js" "${DESTDIR}/usr/lib/stremio"
+	cp "${XBPS_SRCDISTDIR}/${pkgname}-${version}/stremio.asar" "${DESTDIR}/usr/lib/stremio"
 }

  parent reply	other threads:[~2021-11-20 15:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 21:26 [PR PATCH] " mobinmob
2021-11-20 15:22 ` [PR REVIEW] " Chocimier
2021-11-20 15:26 ` mobinmob
2021-11-20 15:29 ` mobinmob [this message]
2021-11-22 20:15 ` thkormas
2021-12-04  4:20 ` ericonr
2021-12-04  6:12 ` mobinmob
2021-12-04 15:13 ` ericonr
2021-12-10 18:58 ` mobinmob
2021-12-10 18:59 ` mobinmob
2021-12-10 19:01 ` mobinmob
2021-12-10 19:05 ` [PR PATCH] [Updated] " mobinmob
2021-12-10 19:06 ` mobinmob
2021-12-11  3:24 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211120152935.hxrVYVr0IOIn3Iwwncv1RdL4WQ0CS4_rCcz_226-9JE@z \
    --to=mobinmob@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).