Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] minigalaxy: update to 1.1.0, orphan.
@ 2021-11-28  6:50 not-chicken
  2021-11-28  6:52 ` [PR PATCH] [Updated] " not-chicken
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: not-chicken @ 2021-11-28  6:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1224 bytes --]

There is a new pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages minig
https://github.com/void-linux/void-packages/pull/34279

minigalaxy: update to 1.1.0, orphan.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34279.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-minig-34279.patch --]
[-- Type: text/x-diff, Size: 1418 bytes --]

From 1352732a5fc5628a74e229434ebe44d776e42490 Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sun, 28 Nov 2021 11:25:31 +0530
Subject: [PATCH] minigalaxy: update to 1.1.0, orphan.

---
 srcpkgs/minigalaxy/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/minigalaxy/template b/srcpkgs/minigalaxy/template
index 9b7d2f6dbc90..58aed0ed456a 100644
--- a/srcpkgs/minigalaxy/template
+++ b/srcpkgs/minigalaxy/template
@@ -1,18 +1,18 @@
 # Template file for 'minigalaxy'
 pkgname=minigalaxy
-version=1.0.2
-revision=2
+version=1.1.0
+revision=1
 build_style=python3-module
 hostmakedepends="gettext python3-setuptools"
 depends="hicolor-icon-theme webkit2gtk python3-gobject python3-requests"
-checkdepends="$depends"
+checkdepends="$depends python3-simplejson"
 short_desc="Simple GOG client for Linux"
-maintainer="Lorem <notloremipsum@protonmail.com>"
+maintainer="Orphaned <orphan@voidlinux.org"
 license="GPL-3.0-or-later, CC-BY-3.0"
 homepage="https://sharkwouter.github.io/minigalaxy/"
 changelog="https://github.com/sharkwouter/minigalaxy/blob/master/CHANGELOG.md"
 distfiles="https://github.com/sharkwouter/minigalaxy/archive/${version}.tar.gz"
-checksum=9cb482760c68153f2fc8b8fe229d60033634bc0c7b83a6aa43a9cfa20ab2d0e9
+checksum=581e7abfb4af0c01d795dc57a93b1305644d8bdd11ecb533bb2787f85b4bc992
 
 do_check() {
 	python -m unittest tests/*.py

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Updated] minigalaxy: update to 1.1.0, orphan.
  2021-11-28  6:50 [PR PATCH] minigalaxy: update to 1.1.0, orphan not-chicken
@ 2021-11-28  6:52 ` not-chicken
  2021-11-29  5:13 ` ericonr
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: not-chicken @ 2021-11-28  6:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

There is an updated pull request by not-chicken against master on the void-packages repository

https://github.com/not-chicken/void-packages minig
https://github.com/void-linux/void-packages/pull/34279

minigalaxy: update to 1.1.0, orphan.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34279.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-minig-34279.patch --]
[-- Type: text/x-diff, Size: 1419 bytes --]

From 1589270e189176fd409c00d40775507ecc88a2ee Mon Sep 17 00:00:00 2001
From: Lorem <notloremipsum@protonmail.com>
Date: Sun, 28 Nov 2021 11:25:31 +0530
Subject: [PATCH] minigalaxy: update to 1.1.0, orphan.

---
 srcpkgs/minigalaxy/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/minigalaxy/template b/srcpkgs/minigalaxy/template
index 9b7d2f6dbc90..30d360cf6414 100644
--- a/srcpkgs/minigalaxy/template
+++ b/srcpkgs/minigalaxy/template
@@ -1,18 +1,18 @@
 # Template file for 'minigalaxy'
 pkgname=minigalaxy
-version=1.0.2
-revision=2
+version=1.1.0
+revision=1
 build_style=python3-module
 hostmakedepends="gettext python3-setuptools"
 depends="hicolor-icon-theme webkit2gtk python3-gobject python3-requests"
-checkdepends="$depends"
+checkdepends="$depends python3-simplejson"
 short_desc="Simple GOG client for Linux"
-maintainer="Lorem <notloremipsum@protonmail.com>"
+maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-or-later, CC-BY-3.0"
 homepage="https://sharkwouter.github.io/minigalaxy/"
 changelog="https://github.com/sharkwouter/minigalaxy/blob/master/CHANGELOG.md"
 distfiles="https://github.com/sharkwouter/minigalaxy/archive/${version}.tar.gz"
-checksum=9cb482760c68153f2fc8b8fe229d60033634bc0c7b83a6aa43a9cfa20ab2d0e9
+checksum=581e7abfb4af0c01d795dc57a93b1305644d8bdd11ecb533bb2787f85b4bc992
 
 do_check() {
 	python -m unittest tests/*.py

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: minigalaxy: update to 1.1.0, orphan.
  2021-11-28  6:50 [PR PATCH] minigalaxy: update to 1.1.0, orphan not-chicken
  2021-11-28  6:52 ` [PR PATCH] [Updated] " not-chicken
@ 2021-11-29  5:13 ` ericonr
  2021-11-29  5:13 ` [PR PATCH] [Merged]: " ericonr
  2021-11-29 15:12 ` not-chicken
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-11-29  5:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34279#issuecomment-981298390

Comment:
```
=> minigalaxy-1.1.0_1: running do_check ...
................................F............................................................................
======================================================================
FAIL: test1_set_info (tests.test_game.TestGame)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.10/unittest/mock.py", line 1370, in patched
    return func(*newargs, **newkeywargs)
  File "/builddir/minigalaxy-1.1.0/tests/test_game.py", line 151, in test1_set_info
    self.assertEqual(expected, observed)
AssertionError: '{"version": "gog-3"}' != '{"locale": "", "install_dir": "/tmp/GOG Gam[265 chars]-3"}'
- {"version": "gog-3"}
+ {"locale": "", "install_dir": "/tmp/GOG Games", "keep_installers": false, "stay_logged_in": true, "show_fps": false, "use_dark_theme": false, "show_hidden_games": false, "show_windows_games": false, "keep_window_maximized": false, "installed_filter": false, "create_applications_file": false}{"version": "gog-3"}


----------------------------------------------------------------------
Ran 109 tests in 0.257s

FAILED (failures=1)
beneath_a_steel_sky_en_gog_2_20150.sh integrity is preserved. MD5 is: 5cc68247b61ba31e37e842fd04409d98
Using system's scrummvm to launch Beneath A Steel Sky
Using system's dosbox to launch Test Game
Using system's scrummvm to launch Test Game
mock: line 1 column 1 (char 0)
```

is slightly concerning, would you mind reporting upstream?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PR PATCH] [Merged]: minigalaxy: update to 1.1.0, orphan.
  2021-11-28  6:50 [PR PATCH] minigalaxy: update to 1.1.0, orphan not-chicken
  2021-11-28  6:52 ` [PR PATCH] [Updated] " not-chicken
  2021-11-29  5:13 ` ericonr
@ 2021-11-29  5:13 ` ericonr
  2021-11-29 15:12 ` not-chicken
  3 siblings, 0 replies; 5+ messages in thread
From: ericonr @ 2021-11-29  5:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]

There's a merged pull request on the void-packages repository

minigalaxy: update to 1.1.0, orphan.
https://github.com/void-linux/void-packages/pull/34279

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: minigalaxy: update to 1.1.0, orphan.
  2021-11-28  6:50 [PR PATCH] minigalaxy: update to 1.1.0, orphan not-chicken
                   ` (2 preceding siblings ...)
  2021-11-29  5:13 ` [PR PATCH] [Merged]: " ericonr
@ 2021-11-29 15:12 ` not-chicken
  3 siblings, 0 replies; 5+ messages in thread
From: not-chicken @ 2021-11-29 15:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 224 bytes --]

New comment by not-chicken on void-packages repository

https://github.com/void-linux/void-packages/pull/34279#issuecomment-981727209

Comment:
>is slightly concerning, would you mind reporting upstream?

Will do soonish.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-11-29 15:12 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-28  6:50 [PR PATCH] minigalaxy: update to 1.1.0, orphan not-chicken
2021-11-28  6:52 ` [PR PATCH] [Updated] " not-chicken
2021-11-29  5:13 ` ericonr
2021-11-29  5:13 ` [PR PATCH] [Merged]: " ericonr
2021-11-29 15:12 ` not-chicken

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).