Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: delta: update to 0.10.2
Date: Mon, 29 Nov 2021 06:08:49 +0100	[thread overview]
Message-ID: <20211129050849.58xTgacbBOHSjob9TOEER_fSRL92RKpAxtpxT6xYmDs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34291@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1675 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34291#issuecomment-981296209

Comment:
```
   Compiling git-delta v0.10.2 (/builddir/delta-0.10.2)
error[E0277]: the trait bound `std::collections::HashSet<std::string::String>: From<[_; 0]>` is not satisfied
   --> src/utils/process.rs:689:46
    |
689 |             Some(CallingProcess::GitGrep(([].into(), [].into())))
    |                                              ^^^^ the trait `From<[_; 0]>` is not implemented for `std::collections::HashSet<std::string::String>`
    |
    = note: required because of the requirements on the impl of `Into<std::collections::HashSet<std::string::String>>` for `[_; 0]`

error[E0277]: the trait bound `std::collections::HashSet<std::string::String>: From<[_; 0]>` is not satisfied
   --> src/utils/process.rs:689:42
    |
689 |             Some(CallingProcess::GitGrep(([].into(), [].into())))
    |                                          ^^^^^^^^^^^^^^^^^^^^^^ the trait `From<[_; 0]>` is not implemented for `std::collections::HashSet<std::string::String>`
    |
    = note: required because of the requirements on the impl of `Into<std::collections::HashSet<std::string::String>>` for `[_; 0]`

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0277`.
error: could not compile `git-delta`

To learn more, run the command again with --verbose.
=> ERROR: delta-0.10.2_1: do_check: '${make_cmd} test --release --target ${RUST_TARGET} ${configure_args} 
```

tests fail to compile, do you think they are depending on new Rust features we don't have?

  reply	other threads:[~2021-11-29  5:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-29  4:42 [PR PATCH] " cinerea0
2021-11-29  5:08 ` ericonr [this message]
2021-11-29  5:12 ` cinerea0
2021-11-29  5:14 ` ericonr
2021-11-29  5:50 ` [PR PATCH] [Updated] " cinerea0
2021-11-29  6:02 ` [PR REVIEW] " ericonr
2021-11-29  6:08 ` [PR PATCH] [Updated] " cinerea0
2021-11-29  7:46 ` ericonr
2021-11-29  7:46 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129050849.58xTgacbBOHSjob9TOEER_fSRL92RKpAxtpxT6xYmDs@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).