Github messages for voidlinux
 help / color / mirror / Atom feed
From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: minigalaxy: update to 1.1.0, orphan.
Date: Mon, 29 Nov 2021 06:13:28 +0100	[thread overview]
Message-ID: <20211129051328.UDVzsYJ6PpyHOlXiVjacigUSlGVBfQtmTLnUE_04Av8@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34279@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1682 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34279#issuecomment-981298390

Comment:
```
=> minigalaxy-1.1.0_1: running do_check ...
................................F............................................................................
======================================================================
FAIL: test1_set_info (tests.test_game.TestGame)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3.10/unittest/mock.py", line 1370, in patched
    return func(*newargs, **newkeywargs)
  File "/builddir/minigalaxy-1.1.0/tests/test_game.py", line 151, in test1_set_info
    self.assertEqual(expected, observed)
AssertionError: '{"version": "gog-3"}' != '{"locale": "", "install_dir": "/tmp/GOG Gam[265 chars]-3"}'
- {"version": "gog-3"}
+ {"locale": "", "install_dir": "/tmp/GOG Games", "keep_installers": false, "stay_logged_in": true, "show_fps": false, "use_dark_theme": false, "show_hidden_games": false, "show_windows_games": false, "keep_window_maximized": false, "installed_filter": false, "create_applications_file": false}{"version": "gog-3"}


----------------------------------------------------------------------
Ran 109 tests in 0.257s

FAILED (failures=1)
beneath_a_steel_sky_en_gog_2_20150.sh integrity is preserved. MD5 is: 5cc68247b61ba31e37e842fd04409d98
Using system's scrummvm to launch Beneath A Steel Sky
Using system's dosbox to launch Test Game
Using system's scrummvm to launch Test Game
mock: line 1 column 1 (char 0)
```

is slightly concerning, would you mind reporting upstream?

  parent reply	other threads:[~2021-11-29  5:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-28  6:50 [PR PATCH] " not-chicken
2021-11-28  6:52 ` [PR PATCH] [Updated] " not-chicken
2021-11-29  5:13 ` ericonr [this message]
2021-11-29  5:13 ` [PR PATCH] [Merged]: " ericonr
2021-11-29 15:12 ` not-chicken

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129051328.UDVzsYJ6PpyHOlXiVjacigUSlGVBfQtmTLnUE_04Av8@z \
    --to=ericonr@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).