Github messages for voidlinux
 help / color / mirror / Atom feed
From: sgn <sgn@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] botan: fix pycompile_module
Date: Mon, 29 Nov 2021 11:46:30 +0100	[thread overview]
Message-ID: <20211129104630.INXIcLAGwHVlYUbVIyL2G00amFw3G0QMkXmg3SSHkrM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34285@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

There is an updated pull request by sgn against master on the void-packages repository

https://github.com/paper42/void-packages botan-pycompile-module
https://github.com/void-linux/void-packages/pull/34285

botan: fix pycompile_module
#### Testing the changes
- I tested the changes in this PR:**briefly**

before:
```
Byte-compiling python3.10 code for module botan.py...
Can't list 'usr/lib/python3.10/site-packages/botan.py'
Can't list 'usr/lib/python3.10/site-packages/botan.py'
```

A patch file from https://github.com/void-linux/void-packages/pull/34285.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-botan-pycompile-module-34285.patch --]
[-- Type: text/x-diff, Size: 1865 bytes --]

From d391b6ecfed23a27b2a9f0c1eae113ab243e2e03 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Sun, 28 Nov 2021 15:04:27 +0100
Subject: [PATCH 1/2] botan: remove pycompile_module

removes a warning at install time
---
 srcpkgs/botan/template | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/srcpkgs/botan/template b/srcpkgs/botan/template
index 282bceabd3ce..e38ecea1dd4e 100644
--- a/srcpkgs/botan/template
+++ b/srcpkgs/botan/template
@@ -1,10 +1,9 @@
 # Template file for 'botan'
 pkgname=botan
 version=2.16.0
-revision=4
+revision=5
 wrksrc="${pkgname^}-${version}"
 build_style=gnu-makefile
-pycompile_module="botan.py"
 hostmakedepends="doxygen python3"
 makedepends="openssl-devel bzip2-devel liblzma-devel sqlite-devel zlib-devel"
 short_desc="Crypto library written in C++"

From b56523f90df28fe65182f99ca2fb92365c8cd828 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Mon, 29 Nov 2021 17:45:57 +0700
Subject: [PATCH 2/2] enable do_check

---
 srcpkgs/botan/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/botan/template b/srcpkgs/botan/template
index e38ecea1dd4e..bac1bd0873a7 100644
--- a/srcpkgs/botan/template
+++ b/srcpkgs/botan/template
@@ -2,7 +2,7 @@
 pkgname=botan
 version=2.16.0
 revision=5
-wrksrc="${pkgname^}-${version}"
+wrksrc="Botan-${version}"
 build_style=gnu-makefile
 hostmakedepends="doxygen python3"
 makedepends="openssl-devel bzip2-devel liblzma-devel sqlite-devel zlib-devel"
@@ -15,7 +15,6 @@ checksum=92ed6ebc918d86bd1b04221ca518af4cf29cc326c4760740bd2d22e61cea2628
 python_version=3
 
 LDFLAGS="-pthread"
-CXXFLAGS="-O3"
 
 do_configure() {
 	local _args _cpu
@@ -77,7 +76,7 @@ do_configure() {
 }
 
 do_check() {
-	./botan-test
+	make check
 }
 
 post_install() {

  parent reply	other threads:[~2021-11-29 10:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-28 14:08 [PR PATCH] " paper42
2021-11-28 14:22 ` [PR PATCH] [Updated] " paper42
2021-11-29 10:46 ` sgn [this message]
2022-04-12 22:10 ` [PR PATCH] [Closed]: " Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211129104630.INXIcLAGwHVlYUbVIyL2G00amFw3G0QMkXmg3SSHkrM@z \
    --to=sgn@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).