* [PR PATCH] gnome-keyring: remove libcap-ng, adopt.
@ 2021-11-29 5:06 ericonr
2021-11-29 15:10 ` not-chicken
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: ericonr @ 2021-11-29 5:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]
There is a new pull request by ericonr against master on the void-packages repository
https://github.com/ericonr/void-packages keyring
https://github.com/void-linux/void-packages/pull/34295
gnome-keyring: remove libcap-ng, adopt.
We don't set capabilities on the binary right now, so it's better to
build without libcap-ng, so it doesn't complain on start-up. This is
also done by other distros, see [1].
libcap was no longer used, and neither was libtasn1.
We already depend on gcr via shlibs, so it doesn't need to be in
depends= explicitly.
Also update changelog to canonical URL.
[1] https://gitlab.gnome.org/GNOME/gnome-keyring/-/merge_requests/41#note_1277767
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
@Not-chicken looks good to you?
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34295.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-keyring-34295.patch --]
[-- Type: text/x-diff, Size: 2022 bytes --]
From 80ea9f4edcff7bf0b2057ffe9c88e5b134cf9a4f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C3=89rico=20Nogueira?= <erico.erc@gmail.com>
Date: Mon, 29 Nov 2021 02:01:44 -0300
Subject: [PATCH] gnome-keyring: remove libcap-ng, adopt.
We don't set capabilities on the binary right now, so it's better to
build without libcap-ng, so it doesn't complain on start-up. This is
also done by other distros, see [1].
libcap was no longer used, and neither was libtasn1.
We already depend on gcr via shlibs, so it doesn't need to be in
depends= explicitly.
Also update changelog to canonical URL.
[1] https://gitlab.gnome.org/GNOME/gnome-keyring/-/merge_requests/41#note_1277767
---
srcpkgs/gnome-keyring/template | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gnome-keyring/template b/srcpkgs/gnome-keyring/template
index 12f1e8d2df64..f479f7f0fe5e 100644
--- a/srcpkgs/gnome-keyring/template
+++ b/srcpkgs/gnome-keyring/template
@@ -1,19 +1,19 @@
# Template file for 'gnome-keyring'
pkgname=gnome-keyring
version=40.0
-revision=2
+revision=3
build_style=gnu-configure
configure_args="--with-pam-dir=/usr/lib/security --disable-schemas-compile"
hostmakedepends="autoconf docbook-xsl glib-devel intltool libtasn1-tools libxslt
openssh pkg-config"
-makedepends="gcr-devel libcap-devel libcap-ng-devel libtasn1-devel pam-devel"
-depends="dconf gcr"
+makedepends="gcr-devel pam-devel"
+depends="dconf"
checkdepends="dbus xvfb-run"
short_desc="GNOME password and secret manager"
-maintainer="Orphaned <orphan@voidlinux.org>"
+maintainer="Érico Nogueira <ericonr@disroot.org>"
license="GPL-2.0-or-later, LGPL-2.1-or-later"
homepage="https://www.gnome.org"
-changelog="https://raw.githubusercontent.com/GNOME/gnome-keyring/gnome-40/NEWS"
+changelog="https://gitlab.gnome.org/GNOME/gnome-keyring/-/raw/master/NEWS"
distfiles="${GNOME_SITE}/$pkgname/${version%.*}/$pkgname-$version.tar.xz"
checksum=a3d24db08ee2fdf240fbbf0971a98c8ee295aa0e1a774537f4ea938038a3b931
make_check=ci-skip
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gnome-keyring: remove libcap-ng, adopt.
2021-11-29 5:06 [PR PATCH] gnome-keyring: remove libcap-ng, adopt ericonr
@ 2021-11-29 15:10 ` not-chicken
2021-11-29 16:02 ` paper42
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: not-chicken @ 2021-11-29 15:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 246 bytes --]
New comment by not-chicken on void-packages repository
https://github.com/void-linux/void-packages/pull/34295#issuecomment-981725957
Comment:
lgtm. Also seems like setting caps is broken for now with glib 2.70+, https://bugs.gentoo.org/815154.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gnome-keyring: remove libcap-ng, adopt.
2021-11-29 5:06 [PR PATCH] gnome-keyring: remove libcap-ng, adopt ericonr
2021-11-29 15:10 ` not-chicken
@ 2021-11-29 16:02 ` paper42
2021-11-29 16:13 ` not-chicken
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2021-11-29 16:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/34295#issuecomment-981774780
Comment:
> lgtm. Also seems like setting caps is broken for now with glib 2.70+, [bugs.gentoo.org/815154](https://bugs.gentoo.org/815154).
I dropped setting the capability with the glib update (#33017) but didn't clean it up properly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gnome-keyring: remove libcap-ng, adopt.
2021-11-29 5:06 [PR PATCH] gnome-keyring: remove libcap-ng, adopt ericonr
2021-11-29 15:10 ` not-chicken
2021-11-29 16:02 ` paper42
@ 2021-11-29 16:13 ` not-chicken
2021-11-29 18:06 ` ericonr
2021-11-29 19:18 ` [PR PATCH] [Merged]: " ericonr
4 siblings, 0 replies; 6+ messages in thread
From: not-chicken @ 2021-11-29 16:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 204 bytes --]
New comment by not-chicken on void-packages repository
https://github.com/void-linux/void-packages/pull/34295#issuecomment-981785044
Comment:
Ah, makes sense. ericonr probably meant to tag you instead.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gnome-keyring: remove libcap-ng, adopt.
2021-11-29 5:06 [PR PATCH] gnome-keyring: remove libcap-ng, adopt ericonr
` (2 preceding siblings ...)
2021-11-29 16:13 ` not-chicken
@ 2021-11-29 18:06 ` ericonr
2021-11-29 19:18 ` [PR PATCH] [Merged]: " ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-11-29 18:06 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 230 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34295#issuecomment-981883069
Comment:
I tagged you correctly, since nheko working meant you were probably using the keyring :p
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: gnome-keyring: remove libcap-ng, adopt.
2021-11-29 5:06 [PR PATCH] gnome-keyring: remove libcap-ng, adopt ericonr
` (3 preceding siblings ...)
2021-11-29 18:06 ` ericonr
@ 2021-11-29 19:18 ` ericonr
4 siblings, 0 replies; 6+ messages in thread
From: ericonr @ 2021-11-29 19:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]
There's a merged pull request on the void-packages repository
gnome-keyring: remove libcap-ng, adopt.
https://github.com/void-linux/void-packages/pull/34295
Description:
We don't set capabilities on the binary right now, so it's better to
build without libcap-ng, so it doesn't complain on start-up. This is
also done by other distros, see [1].
libcap was no longer used, and neither was libtasn1.
We already depend on gcr via shlibs, so it doesn't need to be in
depends= explicitly.
Also update changelog to canonical URL.
[1] https://gitlab.gnome.org/GNOME/gnome-keyring/-/merge_requests/41#note_1277767
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
@Not-chicken looks good to you?
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-11-29 19:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-29 5:06 [PR PATCH] gnome-keyring: remove libcap-ng, adopt ericonr
2021-11-29 15:10 ` not-chicken
2021-11-29 16:02 ` paper42
2021-11-29 16:13 ` not-chicken
2021-11-29 18:06 ` ericonr
2021-11-29 19:18 ` [PR PATCH] [Merged]: " ericonr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).