From: ericonr <ericonr@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: nim: update to 1.6.0, fix non-x86_64/i686 packages, improve template
Date: Sat, 04 Dec 2021 05:30:31 +0100 [thread overview]
Message-ID: <20211204043031.3GxcysaspCV1sKHMRBrYO9bgUlRLTatioIzcRul90oo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34106@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]
There's a merged pull request on the void-packages repository
nim: update to 1.6.0, fix non-x86_64/i686 packages, improve template
https://github.com/void-linux/void-packages/pull/34106
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (glibc)
- I cross-built it for a few things (aarch64 and arm all glibc)
I think it is about ready.
Old comments below this line.
---
I was mainly putting this up here to gather comments. For background, things which have changed between what is available in the repositories and 1.6.0:
- Nim no longer bundles fusion. It provides a koch command to nimble install it at a specific commit. It might be worth providing it as a separate package but maybe not worth it.
- Nim now uses csources_v1 instead of csources. This is now built with make. We used to pass --cpu to build.sh based on XBPS_TARGET_MACHINE. I removed this temporarily, I think it would have to be re-added setting the ucpu variable instead but I would like to see what CI says first.
- Nim now comes with testament which I am installing like the rest of things
- Nim no longer comes with examples
Other notes:
- I bumped the nimble version but actually I think it would be more correct to figure out which exact commit nim 1.6.0 uses in build_all.sh and mirror that. I simply haven't gotten around to this yet. (update: Looks like it uses 0.13.1 so the template is correct now)
- I noticed build_all.sh passes `--skipUserCfg --skipParentCfg --hints:off` everywhere. I'm not sure if we should mirror that. I think the first two options would be irrelevant inside the build environment and the last option is just removing diagnostics. They're not essential options but I also don't think they hurt.
- It would be nice if someone else had a glance at this. I don't really do void packaging but I think I did almost everything correctly.
next prev parent reply other threads:[~2021-12-04 4:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 20:40 [PR PATCH] [RFC] nim: update to 1.6.0 EliteTK
2021-11-16 20:48 ` [PR PATCH] [Updated] " EliteTK
2021-11-16 21:20 ` EliteTK
2021-11-17 23:37 ` [PR PATCH] [Updated] " EliteTK
2021-11-17 23:45 ` EliteTK
2021-11-18 7:40 ` [PR PATCH] [Updated] " EliteTK
2021-11-18 9:24 ` EliteTK
2021-11-18 9:26 ` EliteTK
2021-11-18 19:18 ` EliteTK
2021-11-18 20:10 ` [PR PATCH] [Updated] " EliteTK
2021-11-18 20:12 ` nim: update to 1.6.0, fix non-x86_64/i686 packages, improve template EliteTK
2021-11-18 20:21 ` [PR PATCH] [Updated] " EliteTK
2021-11-19 23:07 ` EliteTK
2021-11-19 23:07 ` EliteTK
2021-11-19 23:13 ` EliteTK
2021-11-19 23:21 ` EliteTK
2021-11-19 23:25 ` EliteTK
2021-12-04 4:27 ` ericonr
2021-12-04 4:30 ` ericonr [this message]
2021-12-04 4:30 ` ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211204043031.3GxcysaspCV1sKHMRBrYO9bgUlRLTatioIzcRul90oo@z \
--to=ericonr@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).