Github messages for voidlinux
 help / color / mirror / Atom feed
From: karlgrose <karlgrose@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] lumina: update to 1.6.1.
Date: Sat, 04 Dec 2021 23:30:01 +0100	[thread overview]
Message-ID: <20211204223001.p_7E0LtQhV7195eKjMWF4psN5wR1w1eKK7ScBFDbgCQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34262@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

New review comment by karlgrose on void-packages repository

https://github.com/void-linux/void-packages/pull/34262#discussion_r762473026

Comment:
The lumina-checkpass binary, which I understand is to be disabled in release 1.6.2 according to comments on the project site (https://github.com/lumina-desktop/lumina/issues/774), was set to install to a hardwired "sbin" location, but that generates a conflict with the pkg-src sanity/lint tests. This patch just forces the build to install to a "bin" path resulting in the pkg-src checks being passed. The need for this patch should disappear with 1.6.2 if the 774 issue cited is to be believed.

  parent reply	other threads:[~2021-12-04 22:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 18:57 [PR PATCH] " karlgrose
2021-11-27 23:57 ` [PR PATCH] [Updated] " karlgrose
2021-11-28  0:38 ` karlgrose
2021-11-28 17:19 ` karlgrose
2021-12-04  1:22 ` [PR REVIEW] " ericonr
2021-12-04 22:30 ` karlgrose [this message]
2021-12-04 22:40 ` [PR PATCH] [Updated] " karlgrose
2021-12-04 22:42 ` [PR REVIEW] " karlgrose
2021-12-05  2:08 ` [PR PATCH] [Updated] " karlgrose
2021-12-05  2:43 ` ericonr
2021-12-05  4:56 ` [PR PATCH] [Updated] " karlgrose
2021-12-05  5:08 ` karlgrose
2021-12-05  5:24 ` karlgrose
2021-12-05  5:36 ` [PR PATCH] [Closed]: " karlgrose
2021-12-05  5:36 ` [PR PATCH] [Updated] " karlgrose
2021-12-11  2:31 ` ericonr
2021-12-11  2:48 ` karlgrose
2021-12-11  3:20 ` ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211204223001.p_7E0LtQhV7195eKjMWF4psN5wR1w1eKK7ScBFDbgCQ@z \
    --to=karlgrose@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).