From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-Pyro4: update to 4.81.
Date: Wed, 08 Dec 2021 02:09:13 +0100 [thread overview]
Message-ID: <20211208010913.pysE2932Kbp_N93S9kSKhjUq0rk3ZpuqCoGTHqm76bo@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34385@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/34385#discussion_r764476112
Comment:
If getting tests to work without installing the package is difficult or impossible, I would delete `checkdepends` and the `do_check` altogether, set `make_check="no"` and leave a comment to the effect that tests don't work unless the package is installed (cf. `python3-numpy`).
next prev parent reply other threads:[~2021-12-08 1:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 20:55 [PR PATCH] " pfpulux
2021-12-04 21:00 ` [PR PATCH] [Updated] " pfpulux
2021-12-04 21:04 ` pfpulux
2021-12-06 15:22 ` [PR REVIEW] " ahesford
2021-12-06 15:22 ` ahesford
2021-12-06 15:22 ` ahesford
2021-12-07 16:36 ` pfpulux
2021-12-07 16:36 ` pfpulux
2021-12-07 16:37 ` pfpulux
2021-12-07 16:42 ` [PR PATCH] [Updated] " pfpulux
2021-12-08 1:08 ` [PR REVIEW] " ahesford
2021-12-08 1:09 ` ahesford [this message]
2022-01-09 6:46 ` [PR PATCH] [Updated] " pfpulux
2022-01-09 6:50 ` [PR PATCH] [Closed]: " pfpulux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208010913.pysE2932Kbp_N93S9kSKhjUq0rk3ZpuqCoGTHqm76bo@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).