Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: python3-pre-commit-2.15.0_1.
@ 2021-10-26 19:49 jbenden
  2021-10-26 20:30 ` [PR PATCH] [Updated] " jbenden
                   ` (25 more replies)
  0 siblings, 26 replies; 27+ messages in thread
From: jbenden @ 2021-10-26 19:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 862 bytes --]

There is a new pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 3813 bytes --]

From d80770a1d88928d33e1c2810f0b1698d61877a09 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Tue, 26 Oct 2021 12:40:30 -0700
Subject: [PATCH] New package: python3-pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template       | 17 +++++++++++++++++
 srcpkgs/python3-identify/template   | 17 +++++++++++++++++
 srcpkgs/python3-nodeenv/template    | 18 ++++++++++++++++++
 srcpkgs/python3-pre-commit/template | 18 ++++++++++++++++++
 4 files changed, 70 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template
 create mode 100644 srcpkgs/python3-identify/template
 create mode 100644 srcpkgs/python3-nodeenv/template
 create mode 100644 srcpkgs/python3-pre-commit/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..7f2b5bf6aa63
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,17 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..2e3438257418
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,17 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-nodeenv/template b/srcpkgs/python3-nodeenv/template
new file mode 100644
index 000000000000..b17be2feeba4
--- /dev/null
+++ b/srcpkgs/python3-nodeenv/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-nodeenv'
+pkgname=python3-nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="make"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-pre-commit/template b/srcpkgs/python3-pre-commit/template
new file mode 100644
index 000000000000..9da348c4ce17
--- /dev/null
+++ b/srcpkgs/python3-pre-commit/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-pre-commit'
+pkgname=python3-pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-cfgv python3-identify python3-nodeenv python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
@ 2021-10-26 20:30 ` jbenden
  2021-10-26 20:44 ` jbenden
                   ` (24 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-10-26 20:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 3888 bytes --]

From 71556381f81af2454feead4eb16ccac7e0deefe9 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Tue, 26 Oct 2021 12:40:30 -0700
Subject: [PATCH] New package: python3-pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template       | 17 +++++++++++++++++
 srcpkgs/python3-identify/template   | 17 +++++++++++++++++
 srcpkgs/python3-nodeenv/template    | 19 +++++++++++++++++++
 srcpkgs/python3-pre-commit/template | 18 ++++++++++++++++++
 4 files changed, 71 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template
 create mode 100644 srcpkgs/python3-identify/template
 create mode 100644 srcpkgs/python3-nodeenv/template
 create mode 100644 srcpkgs/python3-pre-commit/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..7f2b5bf6aa63
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,17 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..2e3438257418
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,17 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-nodeenv/template b/srcpkgs/python3-nodeenv/template
new file mode 100644
index 000000000000..80052bdce145
--- /dev/null
+++ b/srcpkgs/python3-nodeenv/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-nodeenv'
+pkgname=python3-nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="make"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-pre-commit/template b/srcpkgs/python3-pre-commit/template
new file mode 100644
index 000000000000..9da348c4ce17
--- /dev/null
+++ b/srcpkgs/python3-pre-commit/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-pre-commit'
+pkgname=python3-pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-cfgv python3-identify python3-nodeenv python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
  2021-10-26 20:30 ` [PR PATCH] [Updated] " jbenden
@ 2021-10-26 20:44 ` jbenden
  2021-10-27 16:33 ` Chocimier
                   ` (23 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-10-26 20:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 867 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 3948 bytes --]

From 64ba495b434bdbf60857df0ac46795a5b4331782 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Tue, 26 Oct 2021 12:40:30 -0700
Subject: [PATCH] New package: python3-pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template       | 17 +++++++++++++++++
 srcpkgs/python3-identify/template   | 17 +++++++++++++++++
 srcpkgs/python3-nodeenv/template    | 20 ++++++++++++++++++++
 srcpkgs/python3-pre-commit/template | 19 +++++++++++++++++++
 4 files changed, 73 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template
 create mode 100644 srcpkgs/python3-identify/template
 create mode 100644 srcpkgs/python3-nodeenv/template
 create mode 100644 srcpkgs/python3-pre-commit/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..7f2b5bf6aa63
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,17 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..2e3438257418
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,17 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-nodeenv/template b/srcpkgs/python3-nodeenv/template
new file mode 100644
index 000000000000..6d72f724ca8e
--- /dev/null
+++ b/srcpkgs/python3-nodeenv/template
@@ -0,0 +1,20 @@
+# Template file for 'python3-nodeenv'
+pkgname=python3-nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="make"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+make_check=ci-skip
+
+post_install() {
+	vlicense LICENSE
+}
diff --git a/srcpkgs/python3-pre-commit/template b/srcpkgs/python3-pre-commit/template
new file mode 100644
index 000000000000..aab0079766e7
--- /dev/null
+++ b/srcpkgs/python3-pre-commit/template
@@ -0,0 +1,19 @@
+# Template file for 'python3-pre-commit'
+pkgname=python3-pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3-cfgv python3-identify python3-nodeenv python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+make_check=no   # No tests available
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
  2021-10-26 20:30 ` [PR PATCH] [Updated] " jbenden
  2021-10-26 20:44 ` jbenden
@ 2021-10-27 16:33 ` Chocimier
  2021-10-27 21:35 ` [PR PATCH] [Updated] " jbenden
                   ` (22 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: Chocimier @ 2021-10-27 16:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#issuecomment-953101388

Comment:
-  not only pre-commit should be named without `python3-` prefix, but also nodeenv looking at readmes
- they all should `depends=` on either some python module, or `python3`
- split commits into one per package
- do you have error logs form test of nodeenv?

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (2 preceding siblings ...)
  2021-10-27 16:33 ` Chocimier
@ 2021-10-27 21:35 ` jbenden
  2021-10-27 21:37 ` jbenden
                   ` (21 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-10-27 21:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

#### Notes:
- The `nodeenv` package has tests that fail in CI. I've marked them to be skipped in CI. Locally these tests pass on x86_64.
- The `pre-commit` release package has no tests.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 4720 bytes --]

From 9d231e64d286acc78f3937dab52b51f839683467 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:09:29 -0700
Subject: [PATCH 1/4] New package: python3-cfgv-3.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..9e1e97e20659
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}

From dceef947840e0d4eea6073f681f29487b99e190d Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:10:26 -0700
Subject: [PATCH 2/4] New package: python3-identify-2.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-identify/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-identify/template

diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..6af581162d2f
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}

From 3193b54ea5edbf2bc079c59587e2175351ba5a3b Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:32:17 -0700
Subject: [PATCH 3/4] New package: nodeenv-1.6.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/nodeenv/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/nodeenv/template

diff --git a/srcpkgs/nodeenv/template b/srcpkgs/nodeenv/template
new file mode 100644
index 000000000000..ee404cd47747
--- /dev/null
+++ b/srcpkgs/nodeenv/template
@@ -0,0 +1,20 @@
+# Template file for 'nodeenv'
+pkgname=nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="make python3"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+make_check=ci-skip
+
+post_install() {
+	vlicense LICENSE
+}

From c061986817cf3ed35e9f026761fbfd02769ca47f Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:33:51 -0700
Subject: [PATCH 4/4] New package: pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/pre-commit/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/pre-commit/template

diff --git a/srcpkgs/pre-commit/template b/srcpkgs/pre-commit/template
new file mode 100644
index 000000000000..855dff84d13f
--- /dev/null
+++ b/srcpkgs/pre-commit/template
@@ -0,0 +1,19 @@
+# Template file for 'pre-commit'
+pkgname=pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="nodeenv python3-cfgv python3-identify python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+make_check=no   # No tests available
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (3 preceding siblings ...)
  2021-10-27 21:35 ` [PR PATCH] [Updated] " jbenden
@ 2021-10-27 21:37 ` jbenden
  2021-10-29 19:37 ` Chocimier
                   ` (20 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-10-27 21:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 8524 bytes --]

New comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#issuecomment-953330526

Comment:
Hi!

Thanks for all the feedback! I have made all requested changes.

For the last request, on logs, is the output below sufficient - or - did you mean some other specific thing?

```
=> xbps-src: removing autodeps, please wait...
=> xbps-src: cleaning up masterdir...
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> nodeenv-1.6.0_1: building [python3-module] for x86_64...
   [host] python3-setuptools-58.1.0_1: found (https://alpha.de.repo.voidlinux.org/current)
   [check] nodejs-16.9.1_1: found (https://alpha.de.repo.voidlinux.org/current)
   [check] python3-coverage-5.0.3_3: found (https://alpha.de.repo.voidlinux.org/current)
   [check] python3-mock-4.0.3_2: found (https://alpha.de.repo.voidlinux.org/current)
   [check] python3-pytest-6.2.5_2: found (https://alpha.de.repo.voidlinux.org/current)
   [check] which-2.21_3: found (https://alpha.de.repo.voidlinux.org/current)
   [target] python3-3.10.0_1: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] make-4.3_3: found (https://alpha.de.repo.voidlinux.org/current)
   [runtime] python3-3.10.0_1: found (https://alpha.de.repo.voidlinux.org/current)
=> nodeenv-1.6.0_1: installing host dependencies: python3-setuptools-58.1.0_1 nodejs-16.9.1_1 python3-coverage-5.0.3_3 python3-mock-4.0.3_2 python3-pytest-6.2.5_2 which-2.21_3 ...
=> nodeenv-1.6.0_1: installing target dependencies: python3-3.10.0_1 ...
=> nodeenv-1.6.0_1: running do-fetch hook: 00-distfiles ...
=> nodeenv-1.6.0_1: running do-extract hook: 00-distfiles ...
=> nodeenv-1.6.0_1: extracting distfile(s), please wait...
=> nodeenv-1.6.0_1: running do-patch hook: 00-patches ...
=> nodeenv-1.6.0_1: running pre-configure hook: 00-gnu-configure-asneeded ...
=> nodeenv-1.6.0_1: running pre-configure hook: 01-override-config ...
=> nodeenv-1.6.0_1: running pre-configure hook: 02-script-wrapper ...
=> nodeenv-1.6.0_1: running pre-build hook: 02-script-wrapper ...
=> nodeenv-1.6.0_1: running do_build ...
running build
running build_py
creating build
creating build/lib
copying nodeenv.py -> build/lib
=> nodeenv-1.6.0_1: running do_check ...
============================= test session starts ==============================
platform linux -- Python 3.10.0, pytest-6.2.5, py-1.10.0, pluggy-0.13.1
rootdir: /builddir/nodeenv-1.6.0, configfile: tox.ini
collected 14 items

tests/nodeenv_test.py ........                                           [ 57%]
tests/test_install_activate.py ......                                    [100%]

=============================== warnings summary ===============================
tests/nodeenv_test.py:50
  /builddir/nodeenv-1.6.0/tests/nodeenv_test.py:50: PytestDeprecationWarning: @pytest.yield_fixture is deprecated.
  Use @pytest.fixture instead; they are the same.
    def mock_index_json():

tests/nodeenv_test.py:58
  /builddir/nodeenv-1.6.0/tests/nodeenv_test.py:58: PytestDeprecationWarning: @pytest.yield_fixture is deprecated.
  Use @pytest.fixture instead; they are the same.
    def cap_logging_info():

-- Docs: https://docs.pytest.org/en/stable/warnings.html
======================== 14 passed, 2 warnings in 4.81s ========================
=> nodeenv-1.6.0_1: running pre-install hook: 00-libdir ...
=> nodeenv-1.6.0_1: running pre-install hook: 02-script-wrapper ...
=> nodeenv-1.6.0_1: running pre-install hook: 98-fixup-gir-path ...
=> nodeenv-1.6.0_1: running do_install ...
running install
running build
running build_py
running install_lib
creating /destdir/nodeenv-1.6.0/usr/lib/python3.10
creating /destdir/nodeenv-1.6.0/usr/lib/python3.10/site-packages
copying build/lib/nodeenv.py -> /destdir//nodeenv-1.6.0/usr/lib/python3.10/site-packages
byte-compiling /destdir//nodeenv-1.6.0/usr/lib/python3.10/site-packages/nodeenv.py to nodeenv.cpython-310.pyc
running install_egg_info
running egg_info
creating nodeenv.egg-info
writing nodeenv.egg-info/PKG-INFO
writing dependency_links to nodeenv.egg-info/dependency_links.txt
writing entry points to nodeenv.egg-info/entry_points.txt
writing top-level names to nodeenv.egg-info/top_level.txt
writing manifest file 'nodeenv.egg-info/SOURCES.txt'
reading manifest file 'nodeenv.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no files found matching 'setup.cfg'
no previously-included directories found matching 'debian-upstream/nodeenv'
no previously-included directories found matching 'debian-upstream/sdist'
warning: no previously-included files matching '*.log' found under directory 'debian-upstream'
warning: no previously-included files matching '*.substvars' found under directory 'debian-upstream'
warning: no previously-included files matching 'files' found under directory 'debian-upstream'
adding license file 'LICENSE'
adding license file 'AUTHORS'
writing manifest file 'nodeenv.egg-info/SOURCES.txt'
Copying nodeenv.egg-info to /destdir//nodeenv-1.6.0/usr/lib/python3.10/site-packages/nodeenv-1.6.0-py3.10.egg-info
running install_scripts
Installing nodeenv script to /destdir//nodeenv-1.6.0/usr/bin
=> nodeenv-1.6.0_1: running post_install ...
=> nodeenv-1.6.0_1: running post-install hook: 00-compress-info-files ...
=> nodeenv-1.6.0_1: running post-install hook: 00-fixup-gir-path ...
=> nodeenv-1.6.0_1: running post-install hook: 00-libdir ...
=> nodeenv-1.6.0_1: running post-install hook: 00-uncompress-manpages ...
=> nodeenv-1.6.0_1: running post-install hook: 01-remove-misc ...
=> nodeenv-1.6.0_1: running post-install hook: 02-remove-libtool-archives ...
=> nodeenv-1.6.0_1: running post-install hook: 02-remove-perl-files ...
=> nodeenv-1.6.0_1: running post-install hook: 02-remove-python-bytecode-files ...
=> nodeenv-1.6.0_1: running post-install hook: 03-remove-empty-dirs ...
=> WARNING: nodeenv-1.6.0_1: removed empty dir: /usr/lib/python3.10/site-packages/__pycache__
=> nodeenv-1.6.0_1: running post-install hook: 04-create-xbps-metadata-scripts ...
   Added trigger 'pycompile' for the 'INSTALL' script.
   Added trigger 'pycompile' for the 'REMOVE' script.
=> nodeenv-1.6.0_1: running post-install hook: 05-generate-gitrevs ...
=> nodeenv-1.6.0_1: running post-install hook: 06-strip-and-debug-pkgs ...
=> nodeenv-1.6.0_1: running post-install hook: 10-pkglint-devel-paths ...
=> nodeenv-1.6.0_1: running post-install hook: 11-pkglint-elf-in-usrshare ...
=> nodeenv-1.6.0_1: running post-install hook: 12-rename-python3-c-bindings ...
=> nodeenv-1.6.0_1: running post-install hook: 13-pkg-config-clean-xbps-cross-base-ref ...
=> nodeenv-1.6.0_1: running post-install hook: 14-fix-permissions ...
=> nodeenv-1.6.0_1: running post-install hook: 99-pkglint-warn-cross-cruft ...
=> nodeenv-1.6.0_1: running pre-pkg hook: 03-rewrite-python-shebang ...
   Shebang converted to '#!/usr/bin/python3': /usr/bin/nodeenv
   Shebang converted to '#!/usr/bin/python3': /usr/lib/python3.10/site-packages/nodeenv.py
=> nodeenv-1.6.0_1: running pre-pkg hook: 04-generate-runtime-deps ...
=> nodeenv-1.6.0_1: running pre-pkg hook: 05-prepare-32bit ...
=> nodeenv-1.6.0_1: running pre-pkg hook: 06-shlib-provides ...
=> nodeenv-1.6.0_1: running pre-pkg hook: 90-set-timestamps ...
=> nodeenv-1.6.0_1: setting mtimes to Wed Dec 31 05:00:00 PM MST 1969
=> nodeenv-1.6.0_1: running pre-pkg hook: 99-pkglint-subpkgs ...
=> nodeenv-1.6.0_1: running pre-pkg hook: 99-pkglint ...
=> nodeenv-1.6.0_1: running pre-pkg hook: 999-collected-rdeps ...
   make>=0 python3>=0
=> nodeenv-1.6.0_1: running do-pkg hook: 00-gen-pkg ...
=> Creating nodeenv-1.6.0_1.x86_64.xbps for repository /host/binpkgs ...
=> nodeenv-1.6.0_1: running post-pkg hook: 00-register-pkg ...
=> Registering new packages to /host/binpkgs
index: added `nodeenv-1.6.0_1' (x86_64).
index: 156 packages registered.
```

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (4 preceding siblings ...)
  2021-10-27 21:37 ` jbenden
@ 2021-10-29 19:37 ` Chocimier
  2021-10-29 20:19 ` jbenden
                   ` (19 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: Chocimier @ 2021-10-29 19:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#issuecomment-955002387

Comment:
I meant logs from tests failing in CI, to see and explain in template why make check is needed.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (5 preceding siblings ...)
  2021-10-29 19:37 ` Chocimier
@ 2021-10-29 20:19 ` jbenden
  2021-11-03 21:08 ` [PR REVIEW] " Chocimier
                   ` (18 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-10-29 20:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

New comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#issuecomment-955024813

Comment:
Hi,

I think I've found all previous runs through CI. They are listed in reverse order (oldest first):

- https://github.com/void-linux/void-packages/actions/runs/1387240074
- https://github.com/void-linux/void-packages/actions/runs/1387378126
- https://github.com/void-linux/void-packages/actions/runs/1387423760  [passed]
- https://github.com/void-linux/void-packages/actions/runs/1392068522  [passed]

Thanks,
-Joe

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (6 preceding siblings ...)
  2021-10-29 20:19 ` jbenden
@ 2021-11-03 21:08 ` Chocimier
  2021-11-03 22:31 ` jbenden
                   ` (17 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: Chocimier @ 2021-11-03 21:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r742337279

Comment:
It's not about CI, locally tests fail in same way, something's wrong with them.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (7 preceding siblings ...)
  2021-11-03 21:08 ` [PR REVIEW] " Chocimier
@ 2021-11-03 22:31 ` jbenden
  2021-11-03 22:45 ` paper42
                   ` (16 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-11-03 22:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 360 bytes --]

New review comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r742391862

Comment:
Yes. I used `ci-skip` to make the CI not run these tests, but allow anyone without amd64 chip to see that project has failing tests. It will probably still work, but ymmv.

Should I put something different here?

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (8 preceding siblings ...)
  2021-11-03 22:31 ` jbenden
@ 2021-11-03 22:45 ` paper42
  2021-11-06  4:05 ` [PR PATCH] [Updated] " jbenden
                   ` (15 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: paper42 @ 2021-11-03 22:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r742397807

Comment:
`ci-skip` means the tests run fine locally, but are broken in CI, that's not the case here. Ideally fix the tests or mark them as broken with `no` and add a comment why they fail. 

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (9 preceding siblings ...)
  2021-11-03 22:45 ` paper42
@ 2021-11-06  4:05 ` jbenden
  2021-11-06  4:07 ` jbenden
                   ` (14 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-11-06  4:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

#### Notes:
- The `nodeenv` package has tests that fail in CI. I've marked them to be skipped in CI. Locally these tests pass on x86_64.
- The `pre-commit` release package has no tests.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 4753 bytes --]

From 9d231e64d286acc78f3937dab52b51f839683467 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:09:29 -0700
Subject: [PATCH 1/4] New package: python3-cfgv-3.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..9e1e97e20659
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}

From dceef947840e0d4eea6073f681f29487b99e190d Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:10:26 -0700
Subject: [PATCH 2/4] New package: python3-identify-2.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-identify/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-identify/template

diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..6af581162d2f
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}

From e8b3721804c767900cc777b5d251f06c8b0b1073 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:32:17 -0700
Subject: [PATCH 3/4] New package: nodeenv-1.6.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/nodeenv/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/nodeenv/template

diff --git a/srcpkgs/nodeenv/template b/srcpkgs/nodeenv/template
new file mode 100644
index 000000000000..b5bed44d2e94
--- /dev/null
+++ b/srcpkgs/nodeenv/template
@@ -0,0 +1,20 @@
+# Template file for 'nodeenv'
+pkgname=nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="make python3"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+make_check=no # x86_64 tests pass, but others error
+
+post_install() {
+	vlicense LICENSE
+}

From e698ec3252ebefe0ad2521a48e43f349eb655d53 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:33:51 -0700
Subject: [PATCH 4/4] New package: pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/pre-commit/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/pre-commit/template

diff --git a/srcpkgs/pre-commit/template b/srcpkgs/pre-commit/template
new file mode 100644
index 000000000000..855dff84d13f
--- /dev/null
+++ b/srcpkgs/pre-commit/template
@@ -0,0 +1,19 @@
+# Template file for 'pre-commit'
+pkgname=pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="nodeenv python3-cfgv python3-identify python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+make_check=no   # No tests available
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (10 preceding siblings ...)
  2021-11-06  4:05 ` [PR PATCH] [Updated] " jbenden
@ 2021-11-06  4:07 ` jbenden
  2021-11-06 18:56 ` [PR REVIEW] " jbenden
                   ` (13 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-11-06  4:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

#### Notes:
- The `nodeenv` package has tests that fail in CI. I've marked them to be skipped in CI. Locally these tests pass on x86_64.
- The `pre-commit` release package has no tests.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 4753 bytes --]

From fab18692e378565587429b3162eb82680a494580 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:09:29 -0700
Subject: [PATCH 1/4] New package: python3-cfgv-3.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..9e1e97e20659
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}

From e47740415e4735f37ce78ff43df10984e02c2453 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:10:26 -0700
Subject: [PATCH 2/4] New package: python3-identify-2.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-identify/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-identify/template

diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..6af581162d2f
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}

From 0d01cb10f5a58fe2c13e88bb726037f8dff1fcf9 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:32:17 -0700
Subject: [PATCH 3/4] New package: nodeenv-1.6.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/nodeenv/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/nodeenv/template

diff --git a/srcpkgs/nodeenv/template b/srcpkgs/nodeenv/template
new file mode 100644
index 000000000000..b5bed44d2e94
--- /dev/null
+++ b/srcpkgs/nodeenv/template
@@ -0,0 +1,20 @@
+# Template file for 'nodeenv'
+pkgname=nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="make python3"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+make_check=no # x86_64 tests pass, but others error
+
+post_install() {
+	vlicense LICENSE
+}

From 6e6aee91e582f2a10b0117c406c5a4e900490487 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:33:51 -0700
Subject: [PATCH 4/4] New package: pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/pre-commit/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/pre-commit/template

diff --git a/srcpkgs/pre-commit/template b/srcpkgs/pre-commit/template
new file mode 100644
index 000000000000..855dff84d13f
--- /dev/null
+++ b/srcpkgs/pre-commit/template
@@ -0,0 +1,19 @@
+# Template file for 'pre-commit'
+pkgname=pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="nodeenv python3-cfgv python3-identify python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+make_check=no   # No tests available
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (11 preceding siblings ...)
  2021-11-06  4:07 ` jbenden
@ 2021-11-06 18:56 ` jbenden
  2021-11-06 20:05 ` Chocimier
                   ` (12 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-11-06 18:56 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New review comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r744157251

Comment:
I've placed some comments in the code. Thanks!!!

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (12 preceding siblings ...)
  2021-11-06 18:56 ` [PR REVIEW] " jbenden
@ 2021-11-06 20:05 ` Chocimier
  2021-11-06 22:20 ` [PR PATCH] [Updated] " jbenden
                   ` (11 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: Chocimier @ 2021-11-06 20:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r744163283

Comment:
But it caught real error - on musl `nodeenv --prebuild` fetches wrong binaries.
On musl, this is because it expect `x86_64-pc-linux-musl` where Void provides `x86_64-unknown-linux-musl`, on i686 because it does not hardcode i686 mirror excepion, unlike for musl.

@jbenden, could you complaint upstream about those?

Oh, and nodeenv is missing dependencies: `ModuleNotFoundError: No module named 'pkg_resources'`

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (13 preceding siblings ...)
  2021-11-06 20:05 ` Chocimier
@ 2021-11-06 22:20 ` jbenden
  2021-11-06 22:33 ` [PR REVIEW] " jbenden
                   ` (10 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-11-06 22:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

#### Notes:
- The `nodeenv` package has tests that fail in CI. I've marked them to be skipped in CI. Locally these tests pass on x86_64.
- The `pre-commit` release package has no tests.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 6654 bytes --]

From fab18692e378565587429b3162eb82680a494580 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:09:29 -0700
Subject: [PATCH 1/4] New package: python3-cfgv-3.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..9e1e97e20659
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}

From e47740415e4735f37ce78ff43df10984e02c2453 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:10:26 -0700
Subject: [PATCH 2/4] New package: python3-identify-2.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-identify/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-identify/template

diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..6af581162d2f
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}

From 48b2ddde4c7f4a5448c9ae5d64faaa1794f768cc Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:32:17 -0700
Subject: [PATCH 3/4] New package: nodeenv-1.6.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 .../nodeenv/patches/fix-i686-and-musl.patch   | 37 +++++++++++++++++++
 srcpkgs/nodeenv/template                      | 18 +++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
 create mode 100644 srcpkgs/nodeenv/template

diff --git a/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch b/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
new file mode 100644
index 000000000000..0ad103c8317a
--- /dev/null
+++ b/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
@@ -0,0 +1,37 @@
+--- a/nodeenv.py.orig	2021-04-09 01:10:31.000000000 -0700
++++ b/nodeenv.py	2021-11-06 14:53:44.049983253 -0700
+@@ -510,8 +510,13 @@ def get_root_url(version):
+         return src_base_url
+ 
+ 
++def is_i686_linux():
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'i686-pc-linux-gnu'
++
++
+ def is_x86_64_musl():
+-    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-pc-linux-musl'
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-pc-linux-musl' or \
++           sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-unknown-linux-musl'
+ 
+ 
+ def get_node_bin_url(version):
+@@ -1057,7 +1062,7 @@ def main():
+         else:
+             src_domain = opt.mirror
+     # use unofficial builds only if musl and no explicitly chosen mirror
+-    elif is_x86_64_musl():
++    elif is_x86_64_musl() or is_i686_linux():
+         src_domain = 'unofficial-builds.nodejs.org'
+     else:
+         src_domain = 'nodejs.org'
+--- a/tests/nodeenv_test.py.orig	2021-04-09 01:10:31.000000000 -0700
++++ b/tests/nodeenv_test.py	2021-11-06 15:08:23.169976189 -0700
+@@ -108,7 +108,7 @@ def test_mirror_option():
+             ('',
+              'https://nodejs.org/download/release/index.json')]
+     sys_type = sysconfig.get_config_var('HOST_GNU_TYPE')
+-    musl_type = ['x86_64-pc-linux-musl', 'x86_64-unknown-linux-musl']
++    musl_type = ['x86_64-pc-linux-musl', 'x86_64-unknown-linux-musl', 'i686-pc-linux-gnu']
+     # Check if running on musl system and delete last mirror if it is
+     if sys_type in musl_type:
+         urls.pop()
diff --git a/srcpkgs/nodeenv/template b/srcpkgs/nodeenv/template
new file mode 100644
index 000000000000..e4c5f7be680b
--- /dev/null
+++ b/srcpkgs/nodeenv/template
@@ -0,0 +1,18 @@
+# Template file for 'nodeenv'
+pkgname=nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+depends="make python3-setuptools"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+
+post_install() {
+	vlicense LICENSE
+}

From 0e3ebe9c24b98f40103941f2700f29167e12d5c4 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:33:51 -0700
Subject: [PATCH 4/4] New package: pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/pre-commit/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/pre-commit/template

diff --git a/srcpkgs/pre-commit/template b/srcpkgs/pre-commit/template
new file mode 100644
index 000000000000..855dff84d13f
--- /dev/null
+++ b/srcpkgs/pre-commit/template
@@ -0,0 +1,19 @@
+# Template file for 'pre-commit'
+pkgname=pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="nodeenv python3-cfgv python3-identify python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+make_check=no   # No tests available
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (14 preceding siblings ...)
  2021-11-06 22:20 ` [PR PATCH] [Updated] " jbenden
@ 2021-11-06 22:33 ` jbenden
  2021-11-06 23:29 ` jbenden
                   ` (9 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-11-06 22:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

New review comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r744175664

Comment:
I've fixed up i686 glibc. I also adjusted musl, so it might just work! I also fixed the module not found error.

Locally this is all working, but it is failing in CI. Not sure yet why...

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (15 preceding siblings ...)
  2021-11-06 22:33 ` [PR REVIEW] " jbenden
@ 2021-11-06 23:29 ` jbenden
  2021-11-06 23:32 ` jbenden
                   ` (8 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-11-06 23:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 388 bytes --]

New review comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r744179729

Comment:
I am not sure why i686 GNU is failing... It fully works in a local i686 VBox VM. It was a tad old on packages, so I upgraded and re-tested - still locally works.

What is different about that i686 CI instance, compared to a VBox 32-bit VM?

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (16 preceding siblings ...)
  2021-11-06 23:29 ` jbenden
@ 2021-11-06 23:32 ` jbenden
  2021-11-09  0:10 ` Chocimier
                   ` (7 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-11-06 23:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

New review comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r744179957

Comment:
I think the thing uses networking while running tests... Is that allowed in the CI?

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (17 preceding siblings ...)
  2021-11-06 23:32 ` jbenden
@ 2021-11-09  0:10 ` Chocimier
  2021-12-06 20:16 ` [PR PATCH] [Updated] " jbenden
                   ` (6 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: Chocimier @ 2021-11-09  0:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#issuecomment-963689801

Comment:
Tests failing on i686 CI can be ignored in this case, it looks like a poor pretending 32bit host.

Still, cross should be fixed, armv6l binaries are on "unofficial" mirror alike i686, and all musl but x86_64 would fetch wrong binaries, resulting in hard to understand error.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (18 preceding siblings ...)
  2021-11-09  0:10 ` Chocimier
@ 2021-12-06 20:16 ` jbenden
  2021-12-06 20:20 ` jbenden
                   ` (5 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-12-06 20:16 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

#### Notes:
- The `nodeenv` package has tests that fail in CI. I've marked them to be skipped in CI. Locally these tests pass on x86_64.
- The `pre-commit` release package has no tests.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 7360 bytes --]

From c148cddd3226844503e81874a225342bd0bcf36f Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:09:29 -0700
Subject: [PATCH 1/4] New package: python3-cfgv-3.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..9e1e97e20659
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}

From 4ebf1202b17a4aa8f9db165897328cc924fd3b7e Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:10:26 -0700
Subject: [PATCH 2/4] New package: python3-identify-2.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-identify/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-identify/template

diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..6af581162d2f
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}

From afca219741314f657c99b30bdbd03dfa5bcada49 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:32:17 -0700
Subject: [PATCH 3/4] New package: nodeenv-1.6.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 .../nodeenv/patches/fix-i686-and-musl.patch   | 55 +++++++++++++++++++
 srcpkgs/nodeenv/template                      | 19 +++++++
 2 files changed, 74 insertions(+)
 create mode 100644 srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
 create mode 100644 srcpkgs/nodeenv/template

diff --git a/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch b/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
new file mode 100644
index 000000000000..fa75c0f7a6b7
--- /dev/null
+++ b/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
@@ -0,0 +1,55 @@
+--- a/tests/nodeenv_test.py.orig	2021-04-09 01:10:31.000000000 -0700
++++ b/tests/nodeenv_test.py	2021-11-06 15:08:23.169976189 -0700
+@@ -108,7 +108,7 @@ def test_mirror_option():
+             ('',
+              'https://nodejs.org/download/release/index.json')]
+     sys_type = sysconfig.get_config_var('HOST_GNU_TYPE')
+-    musl_type = ['x86_64-pc-linux-musl', 'x86_64-unknown-linux-musl']
++    musl_type = ['x86_64-pc-linux-musl', 'x86_64-unknown-linux-musl', 'i686-pc-linux-gnu', 'armv6l-unknown-linux-gnueabi']
+     # Check if running on musl system and delete last mirror if it is
+     if sys_type in musl_type:
+         urls.pop()
+--- a/nodeenv.py.orig	2021-04-09 01:10:31.000000000 -0700
++++ b/nodeenv.py	2021-12-06 12:55:47.748645252 -0700
+@@ -510,8 +510,21 @@ def get_root_url(version):
+         return src_base_url
+ 
+ 
++def is_armv6l_linux():
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'armv6l-unknown-linux-gnueabi'
++
++
++def is_i686_linux():
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'i686-pc-linux-gnu'
++
++
++def is_musl():
++    return str(sysconfig.get_config_var('HOST_GNU_TYPE')).endswith('-musl')
++
++
+ def is_x86_64_musl():
+-    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-pc-linux-musl'
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-pc-linux-musl' or \
++           sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-unknown-linux-musl'
+ 
+ 
+ def get_node_bin_url(version):
+@@ -1057,13 +1070,17 @@ def main():
+         else:
+             src_domain = opt.mirror
+     # use unofficial builds only if musl and no explicitly chosen mirror
+-    elif is_x86_64_musl():
++    elif is_x86_64_musl() or is_armv6l_linux() or is_i686_linux():
+         src_domain = 'unofficial-builds.nodejs.org'
+     else:
+         src_domain = 'nodejs.org'
+     if src_base_url is None:
+         src_base_url = 'https://%s/download/release' % src_domain
+ 
++    if opt.prebuilt and is_musl() and not is_x86_64_musl():
++        logger.error('No prebuilt Node.js for MUSL libc exists!')
++        exit(1)
++
+     if not opt.node or opt.node.lower() == 'latest':
+         opt.node = get_last_stable_node_version()
+     elif opt.node.lower() == 'lts':
diff --git a/srcpkgs/nodeenv/template b/srcpkgs/nodeenv/template
new file mode 100644
index 000000000000..dc8733bf4583
--- /dev/null
+++ b/srcpkgs/nodeenv/template
@@ -0,0 +1,19 @@
+# Template file for 'nodeenv'
+pkgname=nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+makedepends="python3-setuptools"
+depends="make python3-setuptools"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+
+post_install() {
+	vlicense LICENSE
+}

From 506b514fc891d285c02412654e063ddeaf5a423f Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:33:51 -0700
Subject: [PATCH 4/4] New package: pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/pre-commit/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/pre-commit/template

diff --git a/srcpkgs/pre-commit/template b/srcpkgs/pre-commit/template
new file mode 100644
index 000000000000..855dff84d13f
--- /dev/null
+++ b/srcpkgs/pre-commit/template
@@ -0,0 +1,19 @@
+# Template file for 'pre-commit'
+pkgname=pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="nodeenv python3-cfgv python3-identify python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+make_check=no   # No tests available
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (19 preceding siblings ...)
  2021-12-06 20:16 ` [PR PATCH] [Updated] " jbenden
@ 2021-12-06 20:20 ` jbenden
  2021-12-08 17:29 ` [PR REVIEW] " Chocimier
                   ` (4 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-12-06 20:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by jbenden on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#issuecomment-987167130

Comment:
Hi!

It should exit with readable error message on musl platforms (non-amd64) now.

And it should pick up on armv6l too.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR REVIEW] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (20 preceding siblings ...)
  2021-12-06 20:20 ` jbenden
@ 2021-12-08 17:29 ` Chocimier
  2021-12-08 17:30 ` Chocimier
                   ` (3 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: Chocimier @ 2021-12-08 17:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 189 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#discussion_r765076213

Comment:
Put this into hostmakedepends for cross.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (21 preceding siblings ...)
  2021-12-08 17:29 ` [PR REVIEW] " Chocimier
@ 2021-12-08 17:30 ` Chocimier
  2021-12-08 18:52 ` [PR PATCH] [Updated] " jbenden
                   ` (2 subsequent siblings)
  25 siblings, 0 replies; 27+ messages in thread
From: Chocimier @ 2021-12-08 17:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 172 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/33770#issuecomment-989021630

Comment:
Solution for musl looks fine.

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (22 preceding siblings ...)
  2021-12-08 17:30 ` Chocimier
@ 2021-12-08 18:52 ` jbenden
  2021-12-28 23:46 ` jbenden
  2021-12-29 23:13 ` [PR PATCH] [Merged]: " Chocimier
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-12-08 18:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

#### Notes:
- The `nodeenv` package has tests that fail in CI. I've marked them to be skipped in CI. Locally these tests pass on x86_64.
- The `pre-commit` release package has no tests.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 7364 bytes --]

From c148cddd3226844503e81874a225342bd0bcf36f Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:09:29 -0700
Subject: [PATCH 1/4] New package: python3-cfgv-3.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..9e1e97e20659
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}

From 4ebf1202b17a4aa8f9db165897328cc924fd3b7e Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:10:26 -0700
Subject: [PATCH 2/4] New package: python3-identify-2.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-identify/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-identify/template

diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..6af581162d2f
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}

From 2ce54b40dec427da0b05566a0e5e251adb73b7f8 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:32:17 -0700
Subject: [PATCH 3/4] New package: nodeenv-1.6.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 .../nodeenv/patches/fix-i686-and-musl.patch   | 55 +++++++++++++++++++
 srcpkgs/nodeenv/template                      | 19 +++++++
 2 files changed, 74 insertions(+)
 create mode 100644 srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
 create mode 100644 srcpkgs/nodeenv/template

diff --git a/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch b/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
new file mode 100644
index 000000000000..fa75c0f7a6b7
--- /dev/null
+++ b/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
@@ -0,0 +1,55 @@
+--- a/tests/nodeenv_test.py.orig	2021-04-09 01:10:31.000000000 -0700
++++ b/tests/nodeenv_test.py	2021-11-06 15:08:23.169976189 -0700
+@@ -108,7 +108,7 @@ def test_mirror_option():
+             ('',
+              'https://nodejs.org/download/release/index.json')]
+     sys_type = sysconfig.get_config_var('HOST_GNU_TYPE')
+-    musl_type = ['x86_64-pc-linux-musl', 'x86_64-unknown-linux-musl']
++    musl_type = ['x86_64-pc-linux-musl', 'x86_64-unknown-linux-musl', 'i686-pc-linux-gnu', 'armv6l-unknown-linux-gnueabi']
+     # Check if running on musl system and delete last mirror if it is
+     if sys_type in musl_type:
+         urls.pop()
+--- a/nodeenv.py.orig	2021-04-09 01:10:31.000000000 -0700
++++ b/nodeenv.py	2021-12-06 12:55:47.748645252 -0700
+@@ -510,8 +510,21 @@ def get_root_url(version):
+         return src_base_url
+ 
+ 
++def is_armv6l_linux():
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'armv6l-unknown-linux-gnueabi'
++
++
++def is_i686_linux():
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'i686-pc-linux-gnu'
++
++
++def is_musl():
++    return str(sysconfig.get_config_var('HOST_GNU_TYPE')).endswith('-musl')
++
++
+ def is_x86_64_musl():
+-    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-pc-linux-musl'
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-pc-linux-musl' or \
++           sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-unknown-linux-musl'
+ 
+ 
+ def get_node_bin_url(version):
+@@ -1057,13 +1070,17 @@ def main():
+         else:
+             src_domain = opt.mirror
+     # use unofficial builds only if musl and no explicitly chosen mirror
+-    elif is_x86_64_musl():
++    elif is_x86_64_musl() or is_armv6l_linux() or is_i686_linux():
+         src_domain = 'unofficial-builds.nodejs.org'
+     else:
+         src_domain = 'nodejs.org'
+     if src_base_url is None:
+         src_base_url = 'https://%s/download/release' % src_domain
+ 
++    if opt.prebuilt and is_musl() and not is_x86_64_musl():
++        logger.error('No prebuilt Node.js for MUSL libc exists!')
++        exit(1)
++
+     if not opt.node or opt.node.lower() == 'latest':
+         opt.node = get_last_stable_node_version()
+     elif opt.node.lower() == 'lts':
diff --git a/srcpkgs/nodeenv/template b/srcpkgs/nodeenv/template
new file mode 100644
index 000000000000..6f2bb2e709b8
--- /dev/null
+++ b/srcpkgs/nodeenv/template
@@ -0,0 +1,19 @@
+# Template file for 'nodeenv'
+pkgname=nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="make python3-setuptools"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+
+post_install() {
+	vlicense LICENSE
+}

From a8c4602d71048c7610aee3611f15f627b8179f98 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:33:51 -0700
Subject: [PATCH 4/4] New package: pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/pre-commit/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/pre-commit/template

diff --git a/srcpkgs/pre-commit/template b/srcpkgs/pre-commit/template
new file mode 100644
index 000000000000..855dff84d13f
--- /dev/null
+++ b/srcpkgs/pre-commit/template
@@ -0,0 +1,19 @@
+# Template file for 'pre-commit'
+pkgname=pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="nodeenv python3-cfgv python3-identify python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+make_check=no   # No tests available
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Updated] New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (23 preceding siblings ...)
  2021-12-08 18:52 ` [PR PATCH] [Updated] " jbenden
@ 2021-12-28 23:46 ` jbenden
  2021-12-29 23:13 ` [PR PATCH] [Merged]: " Chocimier
  25 siblings, 0 replies; 27+ messages in thread
From: jbenden @ 2021-12-28 23:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

There is an updated pull request by jbenden against master on the void-packages repository

https://github.com/jbenden/void-packages pre-commit
https://github.com/void-linux/void-packages/pull/33770

New package: python3-pre-commit-2.15.0_1.
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

#### Notes:
- The `nodeenv` package has tests that fail in CI. I've marked them to be skipped in CI. Locally these tests pass on x86_64.
- The `pre-commit` release package has no tests.

A patch file from https://github.com/void-linux/void-packages/pull/33770.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-pre-commit-33770.patch --]
[-- Type: text/x-diff, Size: 7364 bytes --]

From 755ce91d09962bdb2482321ba2b500997730b5e2 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:09:29 -0700
Subject: [PATCH 1/4] New package: python3-cfgv-3.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-cfgv/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-cfgv/template

diff --git a/srcpkgs/python3-cfgv/template b/srcpkgs/python3-cfgv/template
new file mode 100644
index 000000000000..9e1e97e20659
--- /dev/null
+++ b/srcpkgs/python3-cfgv/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-cfgv'
+pkgname=python3-cfgv
+version=3.3.1
+revision=1
+wrksrc="cfgv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="Validate configuration and produce human readable error messages"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/asottile/cfgv"
+distfiles="${PYPI_SITE}/c/cfgv/cfgv-${version}.tar.gz"
+checksum=f5a830efb9ce7a445376bb66ec94c638a9787422f96264c98edc6bdeed8ab736
+
+post_install() {
+	vlicense LICENSE
+}

From f4d80cddac59a977be643012264af7a3984435a6 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:10:26 -0700
Subject: [PATCH 2/4] New package: python3-identify-2.3.1_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/python3-identify/template | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 srcpkgs/python3-identify/template

diff --git a/srcpkgs/python3-identify/template b/srcpkgs/python3-identify/template
new file mode 100644
index 000000000000..6af581162d2f
--- /dev/null
+++ b/srcpkgs/python3-identify/template
@@ -0,0 +1,18 @@
+# Template file for 'python3-identify'
+pkgname=python3-identify
+version=2.3.1
+revision=1
+wrksrc="identify-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="python3"
+short_desc="File identification library for Python"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://github.com/chriskuehl/identify"
+distfiles="${PYPI_SITE}/i/identify/identify-${version}.tar.gz"
+checksum=8a92c56893e9a4ce951f09a50489986615e3eba7b4c60610e0b25f93ca4487ba
+
+post_install() {
+	vlicense LICENSE
+}

From 6095e5c5a8c0dbb99cc323c2796fc811af44a54b Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:32:17 -0700
Subject: [PATCH 3/4] New package: nodeenv-1.6.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 .../nodeenv/patches/fix-i686-and-musl.patch   | 55 +++++++++++++++++++
 srcpkgs/nodeenv/template                      | 19 +++++++
 2 files changed, 74 insertions(+)
 create mode 100644 srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
 create mode 100644 srcpkgs/nodeenv/template

diff --git a/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch b/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
new file mode 100644
index 000000000000..fa75c0f7a6b7
--- /dev/null
+++ b/srcpkgs/nodeenv/patches/fix-i686-and-musl.patch
@@ -0,0 +1,55 @@
+--- a/tests/nodeenv_test.py.orig	2021-04-09 01:10:31.000000000 -0700
++++ b/tests/nodeenv_test.py	2021-11-06 15:08:23.169976189 -0700
+@@ -108,7 +108,7 @@ def test_mirror_option():
+             ('',
+              'https://nodejs.org/download/release/index.json')]
+     sys_type = sysconfig.get_config_var('HOST_GNU_TYPE')
+-    musl_type = ['x86_64-pc-linux-musl', 'x86_64-unknown-linux-musl']
++    musl_type = ['x86_64-pc-linux-musl', 'x86_64-unknown-linux-musl', 'i686-pc-linux-gnu', 'armv6l-unknown-linux-gnueabi']
+     # Check if running on musl system and delete last mirror if it is
+     if sys_type in musl_type:
+         urls.pop()
+--- a/nodeenv.py.orig	2021-04-09 01:10:31.000000000 -0700
++++ b/nodeenv.py	2021-12-06 12:55:47.748645252 -0700
+@@ -510,8 +510,21 @@ def get_root_url(version):
+         return src_base_url
+ 
+ 
++def is_armv6l_linux():
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'armv6l-unknown-linux-gnueabi'
++
++
++def is_i686_linux():
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'i686-pc-linux-gnu'
++
++
++def is_musl():
++    return str(sysconfig.get_config_var('HOST_GNU_TYPE')).endswith('-musl')
++
++
+ def is_x86_64_musl():
+-    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-pc-linux-musl'
++    return sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-pc-linux-musl' or \
++           sysconfig.get_config_var('HOST_GNU_TYPE') == 'x86_64-unknown-linux-musl'
+ 
+ 
+ def get_node_bin_url(version):
+@@ -1057,13 +1070,17 @@ def main():
+         else:
+             src_domain = opt.mirror
+     # use unofficial builds only if musl and no explicitly chosen mirror
+-    elif is_x86_64_musl():
++    elif is_x86_64_musl() or is_armv6l_linux() or is_i686_linux():
+         src_domain = 'unofficial-builds.nodejs.org'
+     else:
+         src_domain = 'nodejs.org'
+     if src_base_url is None:
+         src_base_url = 'https://%s/download/release' % src_domain
+ 
++    if opt.prebuilt and is_musl() and not is_x86_64_musl():
++        logger.error('No prebuilt Node.js for MUSL libc exists!')
++        exit(1)
++
+     if not opt.node or opt.node.lower() == 'latest':
+         opt.node = get_last_stable_node_version()
+     elif opt.node.lower() == 'lts':
diff --git a/srcpkgs/nodeenv/template b/srcpkgs/nodeenv/template
new file mode 100644
index 000000000000..6f2bb2e709b8
--- /dev/null
+++ b/srcpkgs/nodeenv/template
@@ -0,0 +1,19 @@
+# Template file for 'nodeenv'
+pkgname=nodeenv
+version=1.6.0
+revision=1
+wrksrc="nodeenv-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="make python3-setuptools"
+checkdepends="nodejs python3-coverage python3-mock python3-pytest which"
+short_desc="Node.js virtual environment builder"
+maintainer="Joseph Benden <joe@benden.us>"
+license="BSD-3-Clause"
+homepage="https://github.com/ekalinin/nodeenv"
+distfiles="https://github.com/ekalinin/nodeenv/archive/${version}.tar.gz"
+checksum=87b04b0832d38bd825e004e7c8ed82d75524efaa6b8a72e3a55088d93e4e17f7
+
+post_install() {
+	vlicense LICENSE
+}

From a5dd37d04a4bae30434ee0bf3008bfe8f759a508 Mon Sep 17 00:00:00 2001
From: Joseph Benden <joe@benden.us>
Date: Wed, 27 Oct 2021 14:33:51 -0700
Subject: [PATCH 4/4] New package: pre-commit-2.15.0_1.

Signed-off-by: Joseph Benden <joe@benden.us>
---
 srcpkgs/pre-commit/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/pre-commit/template

diff --git a/srcpkgs/pre-commit/template b/srcpkgs/pre-commit/template
new file mode 100644
index 000000000000..855dff84d13f
--- /dev/null
+++ b/srcpkgs/pre-commit/template
@@ -0,0 +1,19 @@
+# Template file for 'pre-commit'
+pkgname=pre-commit
+version=2.15.0
+revision=1
+wrksrc="pre_commit-${version}"
+build_style=python3-module
+hostmakedepends="python3-setuptools"
+depends="nodeenv python3-cfgv python3-identify python3-yaml python3-toml"
+short_desc="Framework for multi-language pre-commit hooks"
+maintainer="Joseph Benden <joe@benden.us>"
+license="MIT"
+homepage="https://pre-commit.com/"
+distfiles="${PYPI_SITE}/p/pre-commit/pre_commit-${version}.tar.gz"
+checksum=3c25add78dbdfb6a28a651780d5c311ac40dd17f160eb3954a0c59da40a505a7
+make_check=no   # No tests available
+
+post_install() {
+	vlicense LICENSE
+}

^ permalink raw reply	[flat|nested] 27+ messages in thread

* Re: [PR PATCH] [Merged]: New package: python3-pre-commit-2.15.0_1.
  2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
                   ` (24 preceding siblings ...)
  2021-12-28 23:46 ` jbenden
@ 2021-12-29 23:13 ` Chocimier
  25 siblings, 0 replies; 27+ messages in thread
From: Chocimier @ 2021-12-29 23:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

There's a merged pull request on the void-packages repository

New package: python3-pre-commit-2.15.0_1.
https://github.com/void-linux/void-packages/pull/33770

Description:
#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

The primary package "python3-pre-commit" could also be named "pre-commit". Not sure which is preferred.

#### Notes:
- The `nodeenv` package has tests that fail in CI. I've marked them to be skipped in CI. Locally these tests pass on x86_64.
- The `pre-commit` release package has no tests.

^ permalink raw reply	[flat|nested] 27+ messages in thread

end of thread, other threads:[~2021-12-29 23:13 UTC | newest]

Thread overview: 27+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-26 19:49 [PR PATCH] New package: python3-pre-commit-2.15.0_1 jbenden
2021-10-26 20:30 ` [PR PATCH] [Updated] " jbenden
2021-10-26 20:44 ` jbenden
2021-10-27 16:33 ` Chocimier
2021-10-27 21:35 ` [PR PATCH] [Updated] " jbenden
2021-10-27 21:37 ` jbenden
2021-10-29 19:37 ` Chocimier
2021-10-29 20:19 ` jbenden
2021-11-03 21:08 ` [PR REVIEW] " Chocimier
2021-11-03 22:31 ` jbenden
2021-11-03 22:45 ` paper42
2021-11-06  4:05 ` [PR PATCH] [Updated] " jbenden
2021-11-06  4:07 ` jbenden
2021-11-06 18:56 ` [PR REVIEW] " jbenden
2021-11-06 20:05 ` Chocimier
2021-11-06 22:20 ` [PR PATCH] [Updated] " jbenden
2021-11-06 22:33 ` [PR REVIEW] " jbenden
2021-11-06 23:29 ` jbenden
2021-11-06 23:32 ` jbenden
2021-11-09  0:10 ` Chocimier
2021-12-06 20:16 ` [PR PATCH] [Updated] " jbenden
2021-12-06 20:20 ` jbenden
2021-12-08 17:29 ` [PR REVIEW] " Chocimier
2021-12-08 17:30 ` Chocimier
2021-12-08 18:52 ` [PR PATCH] [Updated] " jbenden
2021-12-28 23:46 ` jbenden
2021-12-29 23:13 ` [PR PATCH] [Merged]: " Chocimier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).