From: Chocimier <Chocimier@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: 1password-8.4.1
Date: Wed, 08 Dec 2021 18:31:06 +0100 [thread overview]
Message-ID: <20211208173106.NCvTmh30t3bXn2-fwp8iX8hq9YD9QimnSh9PAIbRkH4@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34427@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/34427#issuecomment-989022335
Comment:
- usr should be populated build time (do install), not install time (INSTALL)
- group should be added with dedicated mechanism, not from INSTALL, and should be prefixed with underscore
- use url of specific version (see aur), otherwise template will break continuously
- drop build_style and custom extraction in `do_build`
next prev parent reply other threads:[~2021-12-08 17:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 9:46 [PR PATCH] " b-l-a-i-n-e
2021-12-08 9:48 ` b-l-a-i-n-e
2021-12-08 9:49 ` b-l-a-i-n-e
2021-12-08 9:50 ` b-l-a-i-n-e
2021-12-08 17:31 ` Chocimier [this message]
2021-12-08 22:11 ` [PR PATCH] [Updated] " b-l-a-i-n-e
2021-12-08 22:18 ` b-l-a-i-n-e
2021-12-08 22:23 ` b-l-a-i-n-e
2021-12-08 23:15 ` b-l-a-i-n-e
2021-12-09 17:28 ` b-l-a-i-n-e
2021-12-13 18:54 ` [PR PATCH] [Updated] " b-l-a-i-n-e
2021-12-13 19:36 ` Chocimier
2021-12-13 19:37 ` Chocimier
2021-12-13 19:38 ` Chocimier
2021-12-15 20:09 ` [PR PATCH] [Merged]: " Chocimier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211208173106.NCvTmh30t3bXn2-fwp8iX8hq9YD9QimnSh9PAIbRkH4@z \
--to=chocimier@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).