From: mobinmob <mobinmob@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: stremio-shell: fix server start, adopt.
Date: Fri, 10 Dec 2021 19:59:14 +0100 [thread overview]
Message-ID: <20211210185914.Q-blft0yQ4rbSy8T5hu0I-ISEt3_Hs4w_pYSjDQ4HLE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34123@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
New comment by mobinmob on void-packages repository
https://github.com/void-linux/void-packages/pull/34123#issuecomment-991218049
Comment:
> Please explain that in tbe commit message,then. It's not clear what the PR is doing to fix things.
The stremio-server needs to be autostarted by the stremio binary. In order for that to happen the node binary or a symlink to the node binary has to be in the same directory as the server.js script. That is the main change in the commit.
The previous situation was... awkward:
There was a seperate stremio-server script that the user should start manually in addition to the stremio binary. When started in that way, stremio will always produce a rather vague error, but will work after that.
The template not also symlinks the stremio binary to path instead of creating another shell script that will execute the binary.
There was also a problem with the icon, as it was not installed in the proper location. That means that ts was missing when the icon theme did not provide a stremio icon.
next prev parent reply other threads:[~2021-12-10 18:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 21:26 [PR PATCH] " mobinmob
2021-11-20 15:22 ` [PR REVIEW] " Chocimier
2021-11-20 15:26 ` mobinmob
2021-11-20 15:29 ` [PR PATCH] [Updated] " mobinmob
2021-11-22 20:15 ` thkormas
2021-12-04 4:20 ` ericonr
2021-12-04 6:12 ` mobinmob
2021-12-04 15:13 ` ericonr
2021-12-10 18:58 ` mobinmob
2021-12-10 18:59 ` mobinmob [this message]
2021-12-10 19:01 ` mobinmob
2021-12-10 19:05 ` [PR PATCH] [Updated] " mobinmob
2021-12-10 19:06 ` mobinmob
2021-12-11 3:24 ` [PR PATCH] [Merged]: " ericonr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211210185914.Q-blft0yQ4rbSy8T5hu0I-ISEt3_Hs4w_pYSjDQ4HLE@z \
--to=mobinmob@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).