Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] Add ncurses to terminfo package dependencies
@ 2021-12-05 13:36 meator
  2021-12-11  3:19 ` [PR PATCH] [Merged]: " ericonr
  2021-12-11  3:19 ` ericonr
  0 siblings, 2 replies; 3+ messages in thread
From: meator @ 2021-12-05 13:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

There is a new pull request by meator against master on the void-packages repository

https://github.com/meator/void-packages terminfo
https://github.com/void-linux/void-packages/pull/34394

Add ncurses to terminfo package dependencies
<!-- Uncomment relevant sections and delete options which are not applicable -->
This is very similar to #33116. I didn't notice that this issue affects other terminal emulators as well.
#### Testing the changes
- I tested the changes in this PR: **briefly**

@thypon @travankor I'm pinging you because you are the maintainers of affected packages. Do you have any comment on this?

Fixes #34392 

A patch file from https://github.com/void-linux/void-packages/pull/34394.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-terminfo-34394.patch --]
[-- Type: text/x-diff, Size: 1922 bytes --]

From d247f8476591c65d47eab78ac06001576a935cab Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Sun, 5 Dec 2021 14:08:00 +0100
Subject: [PATCH 1/2] alacritty: add ncurses to terminfo dependencies

alacritty-terminfo.INSTALL uses tic to compile terminfo dependencies,
but it doesn't depend on ncurses, the provider of tic. This commit fixes
this.
---
 srcpkgs/alacritty/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/alacritty/template b/srcpkgs/alacritty/template
index 0aaa952d4daa..9d34bdfb4a1b 100644
--- a/srcpkgs/alacritty/template
+++ b/srcpkgs/alacritty/template
@@ -1,7 +1,7 @@
 # Template file for 'alacritty'
 pkgname=alacritty
 version=0.9.0
-revision=1
+revision=2
 build_wrksrc="${pkgname}"
 build_style=cargo
 hostmakedepends="pkg-config python3"
@@ -33,6 +33,7 @@ post_install() {
 
 alacritty-terminfo_package() {
 	short_desc+=" - terminfo data"
+	depends="ncurses"
 	pkg_install() {
 		vmove usr/share/terminfo
 	}

From 8cbaf92d072c7244355ebb3e87c0df8beec812dd Mon Sep 17 00:00:00 2001
From: meator <meator.dev@gmail.com>
Date: Sun, 5 Dec 2021 14:13:13 +0100
Subject: [PATCH 2/2] mtm: add ncurses to terminfo dependencies

mtm-terminfo.INSTALL uses tic to compile terminfo dependencies,
but it doesn't depend on ncurses, the provider of tic. This commit fixes
this.
---
 srcpkgs/mtm/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/mtm/template b/srcpkgs/mtm/template
index 96597a16b13b..a6cfd2c104ce 100644
--- a/srcpkgs/mtm/template
+++ b/srcpkgs/mtm/template
@@ -1,7 +1,7 @@
 # Template file for 'mtm'
 pkgname=mtm
 version=1.2.0
-revision=2
+revision=3
 build_style=gnu-makefile
 makedepends="ncurses-devel ncurses-libs"
 depends="ncurses"
@@ -24,6 +24,7 @@ do_install() {
 
 mtm-terminfo_package() {
 	short_desc+=" - terminfo data"
+	depends="ncurses"
 	pkg_install() {
 		vmove usr/share/terminfo
 	}

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: Add ncurses to terminfo package dependencies
  2021-12-05 13:36 [PR PATCH] Add ncurses to terminfo package dependencies meator
@ 2021-12-11  3:19 ` ericonr
  2021-12-11  3:19 ` ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-12-11  3:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]

There's a merged pull request on the void-packages repository

Add ncurses to terminfo package dependencies
https://github.com/void-linux/void-packages/pull/34394

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
This is very similar to #33116. I didn't notice that this issue affects other terminal emulators as well.
#### Testing the changes
- I tested the changes in this PR: **briefly**

@thypon @travankor I'm pinging you because you are the maintainers of affected packages. Do you have any comment on this?

Fixes #34392 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Add ncurses to terminfo package dependencies
  2021-12-05 13:36 [PR PATCH] Add ncurses to terminfo package dependencies meator
  2021-12-11  3:19 ` [PR PATCH] [Merged]: " ericonr
@ 2021-12-11  3:19 ` ericonr
  1 sibling, 0 replies; 3+ messages in thread
From: ericonr @ 2021-12-11  3:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34394#issuecomment-991429517

Comment:
Thanks for the fix!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-11  3:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-05 13:36 [PR PATCH] Add ncurses to terminfo package dependencies meator
2021-12-11  3:19 ` [PR PATCH] [Merged]: " ericonr
2021-12-11  3:19 ` ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).