From: dotnetfox <dotnetfox@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: aws-cli: update to 1.22.23 (with deps)
Date: Sun, 12 Dec 2021 09:43:35 +0100 [thread overview]
Message-ID: <20211212084335.j5fCFxrhngES11aEJZi3VuuBfs1xpbSTatVHIOLtWBM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34490@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1469 bytes --]
New comment by dotnetfox on void-packages repository
https://github.com/void-linux/void-packages/pull/34490#issuecomment-991856439
Comment:
@bobertlo, your particular comment in all these commits caught my interest.
```sh
# pytest marked deprecated, suggests using tox (which does not test against system packages)
```
You see, I too got entrapped with tests (PR #34489) and it seems I have to explicitly specify `python3-pytest` in `checkdepends` along with packages it uses during tests.
If `python3-pytest` is not defined, `do_check` falls back to that "deprecated testing" which you mentioned.
```sh
do_check() {
if python3 -c 'import pytest' >/dev/null 2>&1; then
PYTHONPATH="$(cd build/lib* && pwd)" \
python3 -m pytest ${make_check_args} ${make_check_target}
else
# Fall back to deprecated setup.py test orchestration without pytest
if [ -z "$make_check_target" ]; then
if ! python3 setup.py --help test >/dev/null 2>&1; then
msg_warn "No command 'test' defined by setup.py.\n"
return 0
fi
fi
: ${make_check_target:=test}
python3 setup.py ${make_check_target} ${make_check_args}
fi
}
```
To be certain, the `python3-module` build style does not append `python3-pytest` to anywhere.
As you can see above, it is mentioned only within `do_check`.
Hope this information will be useful for you.
next prev parent reply other threads:[~2021-12-12 8:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 3:35 [PR PATCH] Aws 2112 bobertlo
2021-12-12 5:17 ` aws-cli: update to 1.22.23 (with deps) uhohspaghetios
2021-12-12 8:43 ` dotnetfox [this message]
2021-12-12 11:33 ` paper42
2021-12-12 12:49 ` bobertlo
2021-12-12 13:44 ` paper42
2021-12-12 13:46 ` paper42
2021-12-12 13:54 ` paper42
2021-12-12 13:54 ` paper42
2021-12-12 18:02 ` [PR PATCH] [Updated] " bobertlo
2021-12-12 18:08 ` bobertlo
2021-12-12 20:50 ` [PR REVIEW] " paper42
2021-12-12 20:50 ` paper42
2021-12-12 20:50 ` paper42
2021-12-12 23:14 ` [PR PATCH] [Updated] " bobertlo
2021-12-12 23:21 ` bobertlo
2021-12-12 23:45 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211212084335.j5fCFxrhngES11aEJZi3VuuBfs1xpbSTatVHIOLtWBM@z \
--to=dotnetfox@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).