Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gendesk: update to 1.0.9.
@ 2021-12-15 16:26 benalb
  2021-12-15 22:15 ` [PR REVIEW] " paper42
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: benalb @ 2021-12-15 16:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]

There is a new pull request by benalb against master on the void-packages repository

https://github.com/benalb/void-packages gendesk
https://github.com/void-linux/void-packages/pull/34558

gendesk: update to 1.0.9.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (X86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34558.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gendesk-34558.patch --]
[-- Type: text/x-diff, Size: 1098 bytes --]

From d96e47aa81f0686a57c6a81b3ea81ef84e690d47 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Wed, 15 Dec 2021 17:24:39 +0100
Subject: [PATCH] gendesk: update to 1.0.9.

---
 srcpkgs/gendesk/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gendesk/template b/srcpkgs/gendesk/template
index 7b9eaab6164b..0fec800bb575 100644
--- a/srcpkgs/gendesk/template
+++ b/srcpkgs/gendesk/template
@@ -1,6 +1,6 @@
 # Template file for 'gendesk'
 pkgname=gendesk
-version=1.0.8
+version=1.0.9
 revision=1
 build_style=go
 go_import_path=github.com/xyproto/gendesk
@@ -12,7 +12,7 @@ license="MIT"
 homepage="http://roboticoverlords.org/gendesk/"
 distfiles="https://github.com/xyproto/gendesk/archive/${version}.tar.gz
  http://roboticoverlords.org/images/default.png"
-checksum="548ca9b5bd81174414857ece85d6afd8e021c8ac769584c0f573896b845e8fe1
+checksum="dd0008512eebc893e4b630d07d9bf5e3a4f121b87fe725c32773caa6e391db58
  4d96eded48e536d02e35727c36dc20844c2e44654e81baf78e10aee4eb48e837"
 skip_extraction="default.png"
 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
@ 2021-12-15 22:15 ` paper42
  2021-12-16 15:08 ` [PR PATCH] [Updated] " benalb
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2021-12-15 22:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34558#discussion_r770071730

Comment:
```suggestion
homepage="https://roboticoverlords.org/gendesk/"
distfiles="https://github.com/xyproto/gendesk/archive/${version}.tar.gz
 https://roboticoverlords.org/images/default.png"
```

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
  2021-12-15 22:15 ` [PR REVIEW] " paper42
@ 2021-12-16 15:08 ` benalb
  2021-12-16 15:10 ` [PR REVIEW] " benalb
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: benalb @ 2021-12-16 15:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

There is an updated pull request by benalb against master on the void-packages repository

https://github.com/benalb/void-packages gendesk
https://github.com/void-linux/void-packages/pull/34558

gendesk: update to 1.0.9.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (X86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34558.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gendesk-34558.patch --]
[-- Type: text/x-diff, Size: 2357 bytes --]

From d96e47aa81f0686a57c6a81b3ea81ef84e690d47 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Wed, 15 Dec 2021 17:24:39 +0100
Subject: [PATCH 1/2] gendesk: update to 1.0.9.

---
 srcpkgs/gendesk/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gendesk/template b/srcpkgs/gendesk/template
index 7b9eaab6164b..0fec800bb575 100644
--- a/srcpkgs/gendesk/template
+++ b/srcpkgs/gendesk/template
@@ -1,6 +1,6 @@
 # Template file for 'gendesk'
 pkgname=gendesk
-version=1.0.8
+version=1.0.9
 revision=1
 build_style=go
 go_import_path=github.com/xyproto/gendesk
@@ -12,7 +12,7 @@ license="MIT"
 homepage="http://roboticoverlords.org/gendesk/"
 distfiles="https://github.com/xyproto/gendesk/archive/${version}.tar.gz
  http://roboticoverlords.org/images/default.png"
-checksum="548ca9b5bd81174414857ece85d6afd8e021c8ac769584c0f573896b845e8fe1
+checksum="dd0008512eebc893e4b630d07d9bf5e3a4f121b87fe725c32773caa6e391db58
  4d96eded48e536d02e35727c36dc20844c2e44654e81baf78e10aee4eb48e837"
 skip_extraction="default.png"
 

From ec0db6d5a426557d80855df0637504d4c4d4bf1d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Thu, 16 Dec 2021 16:07:53 +0100
Subject: [PATCH 2/2] remove go_mod_mode remove git hostmakedepends change URL
 to https

---
 srcpkgs/gendesk/template | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/gendesk/template b/srcpkgs/gendesk/template
index 0fec800bb575..22be43712b03 100644
--- a/srcpkgs/gendesk/template
+++ b/srcpkgs/gendesk/template
@@ -4,14 +4,12 @@ version=1.0.9
 revision=1
 build_style=go
 go_import_path=github.com/xyproto/gendesk
-go_mod_mode=default
-hostmakedepends="git"
 short_desc="Utility to generate .desktop files and download icons"
 maintainer="Benjamín Albiñana <benalb@gmail.com>"
 license="MIT"
-homepage="http://roboticoverlords.org/gendesk/"
+homepage="https://roboticoverlords.org/gendesk/"
 distfiles="https://github.com/xyproto/gendesk/archive/${version}.tar.gz
- http://roboticoverlords.org/images/default.png"
+ https://roboticoverlords.org/images/default.png"
 checksum="dd0008512eebc893e4b630d07d9bf5e3a4f121b87fe725c32773caa6e391db58
  4d96eded48e536d02e35727c36dc20844c2e44654e81baf78e10aee4eb48e837"
 skip_extraction="default.png"

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
  2021-12-15 22:15 ` [PR REVIEW] " paper42
  2021-12-16 15:08 ` [PR PATCH] [Updated] " benalb
@ 2021-12-16 15:10 ` benalb
  2021-12-16 22:14 ` paper42
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: benalb @ 2021-12-16 15:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]

New review comment by benalb on void-packages repository

https://github.com/void-linux/void-packages/pull/34558#discussion_r770627443

Comment:
Done. 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
                   ` (2 preceding siblings ...)
  2021-12-16 15:10 ` [PR REVIEW] " benalb
@ 2021-12-16 22:14 ` paper42
  2021-12-16 22:14 ` paper42
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2021-12-16 22:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34558#issuecomment-996235029

Comment:
squash the commits, otherwise lgtm :+1:

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
                   ` (3 preceding siblings ...)
  2021-12-16 22:14 ` paper42
@ 2021-12-16 22:14 ` paper42
  2021-12-17  5:55 ` [PR PATCH] [Updated] " benalb
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2021-12-16 22:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 187 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/34558#issuecomment-996235029

Comment:
please squash the commits, otherwise lgtm :+1:

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
                   ` (4 preceding siblings ...)
  2021-12-16 22:14 ` paper42
@ 2021-12-17  5:55 ` benalb
  2021-12-17  5:59 ` benalb
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: benalb @ 2021-12-17  5:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]

There is an updated pull request by benalb against master on the void-packages repository

https://github.com/benalb/void-packages gendesk
https://github.com/void-linux/void-packages/pull/34558

gendesk: update to 1.0.9.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (X86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34558.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gendesk-34558.patch --]
[-- Type: text/x-diff, Size: 1356 bytes --]

From d917b31a2b17bc36a8df8515de1996938dc49550 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Benjam=C3=ADn=20Albi=C3=B1ana?= <benalb@gmail.com>
Date: Wed, 15 Dec 2021 17:24:39 +0100
Subject: [PATCH] gendesk: update to 1.0.9.

---
 srcpkgs/gendesk/template | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/srcpkgs/gendesk/template b/srcpkgs/gendesk/template
index 7b9eaab6164b..22be43712b03 100644
--- a/srcpkgs/gendesk/template
+++ b/srcpkgs/gendesk/template
@@ -1,18 +1,16 @@
 # Template file for 'gendesk'
 pkgname=gendesk
-version=1.0.8
+version=1.0.9
 revision=1
 build_style=go
 go_import_path=github.com/xyproto/gendesk
-go_mod_mode=default
-hostmakedepends="git"
 short_desc="Utility to generate .desktop files and download icons"
 maintainer="Benjamín Albiñana <benalb@gmail.com>"
 license="MIT"
-homepage="http://roboticoverlords.org/gendesk/"
+homepage="https://roboticoverlords.org/gendesk/"
 distfiles="https://github.com/xyproto/gendesk/archive/${version}.tar.gz
- http://roboticoverlords.org/images/default.png"
-checksum="548ca9b5bd81174414857ece85d6afd8e021c8ac769584c0f573896b845e8fe1
+ https://roboticoverlords.org/images/default.png"
+checksum="dd0008512eebc893e4b630d07d9bf5e3a4f121b87fe725c32773caa6e391db58
  4d96eded48e536d02e35727c36dc20844c2e44654e81baf78e10aee4eb48e837"
 skip_extraction="default.png"
 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
                   ` (5 preceding siblings ...)
  2021-12-17  5:55 ` [PR PATCH] [Updated] " benalb
@ 2021-12-17  5:59 ` benalb
  2021-12-17  7:47 ` ericonr
  2021-12-17  7:47 ` [PR PATCH] [Merged]: " ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: benalb @ 2021-12-17  5:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New comment by benalb on void-packages repository

https://github.com/void-linux/void-packages/pull/34558#issuecomment-996459727

Comment:
Sorry for the extra work for the builders, In my defense, I got the booster dose and it hit me hard. 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
                   ` (6 preceding siblings ...)
  2021-12-17  5:59 ` benalb
@ 2021-12-17  7:47 ` ericonr
  2021-12-17  7:47 ` [PR PATCH] [Merged]: " ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-12-17  7:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/34558#issuecomment-996506621

Comment:
No worries, Go build are plenty quick ;)

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Merged]: gendesk: update to 1.0.9.
  2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
                   ` (7 preceding siblings ...)
  2021-12-17  7:47 ` ericonr
@ 2021-12-17  7:47 ` ericonr
  8 siblings, 0 replies; 10+ messages in thread
From: ericonr @ 2021-12-17  7:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

There's a merged pull request on the void-packages repository

gendesk: update to 1.0.9.
https://github.com/void-linux/void-packages/pull/34558

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (X86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-12-17  7:47 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-15 16:26 [PR PATCH] gendesk: update to 1.0.9 benalb
2021-12-15 22:15 ` [PR REVIEW] " paper42
2021-12-16 15:08 ` [PR PATCH] [Updated] " benalb
2021-12-16 15:10 ` [PR REVIEW] " benalb
2021-12-16 22:14 ` paper42
2021-12-16 22:14 ` paper42
2021-12-17  5:55 ` [PR PATCH] [Updated] " benalb
2021-12-17  5:59 ` benalb
2021-12-17  7:47 ` ericonr
2021-12-17  7:47 ` [PR PATCH] [Merged]: " ericonr

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).