[ISSUE] synapse 1.49.0 update deleted my productive server config

[ISSUE] synapse 1.49.0 update deleted my productive server config

[freshprince]

[-- Attachment #1: Type: text/plain, Size: 406 bytes --]

New issue by freshprince on void-packages repository

https://github.com/void-linux/void-packages/issues/34657

Description:
```
post_install() {
	vsv synapse

	vinstall docs/sample_config.yaml 644 etc/synapse homeserver.yaml
	vinstall docs/sample_log_config.yaml 644 etc/synapse log.yaml
}
```

not really a good idea if someone already has a productive config in /etc/synapse/homeserver.yaml :(

Re: synapse 1.49.0 update deleted my productive server config

[paper42]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/34657#issuecomment-999438347

Comment:
It's marked as conf_files, so your config won't be overwritten.

Re: synapse 1.49.0 update deleted my productive server config

[paper42]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/34657#issuecomment-999438347

Comment:
The file is mentioned in conf_files, so your config won't be overwritten.

Re: synapse 1.49.0 update deleted my productive server config

[freshprince]

[-- Attachment #1: Type: text/plain, Size: 184 bytes --]

New comment by freshprince on void-packages repository

https://github.com/void-linux/void-packages/issues/34657#issuecomment-999439375

Comment:
cannot confirm my config file is gone

Re: synapse 1.49.0 update deleted my productive server config

[paper42]

[-- Attachment #1: Type: text/plain, Size: 418 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/issues/34657#issuecomment-999440949

Comment:
Something like this should have happened if /etc/synapse/homeserver.yaml existed and you installed synapse:
```
synapse-1.49.0_1: unpacking ...
File `./etc/synapse/homeserver.yaml' exists, installing configuration file to `./etc/synapse/homeserver.yaml.new-1.49.0_1'.
```

Re: synapse 1.49.0 update deleted my productive server config

[freshprince]

[-- Attachment #1: Type: text/plain, Size: 1939 bytes --]

New comment by freshprince on void-packages repository

https://github.com/void-linux/void-packages/issues/34657#issuecomment-999447082

Comment:
```
# cat /etc/synapse/homeserver.yaml
feoofdsofjsod
# xbps-install -R. -u synapse

Name    Action    Version           New version            Download size
synapse update    1.48.0_1          1.49.0_1               -

Size required on disk:        6889KB
Space available on disk:      6535MB

Do you want to continue? [Y/n]

[*] Verifying package integrity
synapse-1.49.0_1: verifying SHA256 hash...

[*] Collecting package files
synapse-1.49.0_1: collecting files...
synapse-1.48.0_1: collecting files...

[*] Unpacking packages
synapse-1.48.0_1: updating to 1.49.0_1 ...
Removing byte-compiled python3.10 code for module synapse...
Removing byte-compiled python3.10 code for module synmark...
Updating ldconfig(8) cache...
synapse-1.49.0_1: unpacking ...
synapse-1.49.0_1: file `./etc/sv/synapse/run' won't be extracted, it's preserved.

[*] Configuring unpacked packages
synapse-1.49.0_1: configuring ...
Updated synapse system user.
Byte-compiling python3.10 code for module synapse...
Byte-compiling python3.10 code for module synmark...
Updating ldconfig(8) cache...
synapse-1.49.0_1: updated successfully.

0 downloaded, 0 installed, 1 updated, 1 configured, 0 removed.
# head /etc/synapse/homeserver.yaml
# This file is maintained as an up-to-date snapshot of the default
# homeserver.yaml configuration generated by Synapse.
#
# It is intended to act as a reference for the default configuration,
# helping admins keep track of new options and other changes, and compare
# their configs with the current default.  As such, many of the actual
# config values shown are placeholders.
#
# It is *not* intended to be copied and used as the basis for a real
# homeserver.yaml. Instead, if you are starting from scratch, please generate
```

Re: synapse 1.49.0 update deleted my productive server config

[ArsenArsen]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

New comment by ArsenArsen on void-packages repository

https://github.com/void-linux/void-packages/issues/34657#issuecomment-999462457

Comment:
Can you post output with debug and verbose? I suspect the block below gets called.

https://github.com/void-linux/xbps/blob/4a5eb8dc87cf08ad919ec6602ef5a70e8514710c/lib/package_config_files.c#L124-L132

Re: synapse 1.49.0 update deleted my productive server config

[freshprince]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New comment by freshprince on void-packages repository

https://github.com/void-linux/void-packages/issues/34657#issuecomment-999471054

Comment:
sure
[debug.txt](https://github.com/void-linux/void-packages/files/7762076/debug.txt)