Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: rofi-wayland-1.7.0
@ 2021-10-15 19:46 ram02z
  2021-10-15 19:54 ` [PR PATCH] [Updated] " ram02z
                   ` (24 more replies)
  0 siblings, 25 replies; 26+ messages in thread
From: ram02z @ 2021-10-15 19:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1596 bytes --]

There is a new pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 2778 bytes --]

From 1acd735c1e15be88c64026afb641b4424e6e7076 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.0

---
 ...1-meson-fix-version-in-rofi.pc-again.patch | 24 +++++++++++++++++++
 srcpkgs/rofi-wayland/template                 | 23 ++++++++++++++++++
 2 files changed, 47 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/01-meson-fix-version-in-rofi.pc-again.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/01-meson-fix-version-in-rofi.pc-again.patch b/srcpkgs/rofi-wayland/patches/01-meson-fix-version-in-rofi.pc-again.patch
new file mode 100644
index 000000000000..70119411a816
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/01-meson-fix-version-in-rofi.pc-again.patch
@@ -0,0 +1,24 @@
+From de28766ce014d9cd09c460d520a8a28fbe41fa0d Mon Sep 17 00:00:00 2001
+From: Jakub Jirutka <jakub@jirutka.cz>
+Date: Mon, 4 Oct 2021 00:59:51 +0200
+Subject: [PATCH] [Meson] Fix version in rofi.pc again
+Patch-Source: https://github.com/lbonn/rofi/pull/37
+
+rofi.pc: pkgconf version 1.7.0+wayland1 is invalid
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 604956f11..dfb1af847 100644
+--- a/meson.build
++++ b/meson.build
+@@ -339,7 +339,7 @@ pkg = import('pkgconfig')
+ pkg.generate(
+     filebase: 'rofi',
+     name: 'rofi',
+-    version: meson.project_version().split('-')[0],
++    version: meson.project_version().split('+')[0],
+     description: 'Header files for rofi plugins',
+     variables: [
+         'pluginsdir=@0@'.format(join_paths('${libdir}', meson.project_name())),
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..71b9302d9583
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.0
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel wayland-protocols"
+makedepends="libXinerama-devel librsvg-devel libxkbcommon-devel
+ pango-devel startup-notification-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=07892f3f993de3ccc5e3e7705c58a88498216d2a7aaaabb14e29dd2837701691
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
@ 2021-10-15 19:54 ` ram02z
  2021-10-15 19:59 ` ram02z
                   ` (23 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-15 19:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 4024 bytes --]

From 4fd9e7814eb1f54b6bc975cfed7bbd1a0bc1fe48 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.0

---
 ...1-meson-fix-version-in-rofi.pc-again.patch | 24 +++++++++++++++
 .../patches/disable-scrollbar-test.patch      | 30 +++++++++++++++++++
 srcpkgs/rofi-wayland/template                 | 23 ++++++++++++++
 3 files changed, 77 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
new file mode 100644
index 000000000000..70119411a816
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
@@ -0,0 +1,24 @@
+From de28766ce014d9cd09c460d520a8a28fbe41fa0d Mon Sep 17 00:00:00 2001
+From: Jakub Jirutka <jakub@jirutka.cz>
+Date: Mon, 4 Oct 2021 00:59:51 +0200
+Subject: [PATCH] [Meson] Fix version in rofi.pc again
+Patch-Source: https://github.com/lbonn/rofi/pull/37
+
+rofi.pc: pkgconf version 1.7.0+wayland1 is invalid
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 604956f11..dfb1af847 100644
+--- a/meson.build
++++ b/meson.build
+@@ -339,7 +339,7 @@ pkg = import('pkgconfig')
+ pkg.generate(
+     filebase: 'rofi',
+     name: 'rofi',
+-    version: meson.project_version().split('-')[0],
++    version: meson.project_version().split('+')[0],
+     description: 'Header files for rofi plugins',
+     variables: [
+         'pluginsdir=@0@'.format(join_paths('${libdir}', meson.project_name())),
diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..fd6b00624ffd
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,30 @@
+Don't run scrollbar test, it fails on i686.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -342,23 +342,6 @@ test('box test', executable('box.test', [
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..9508ac83e3c2
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.0
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="libXinerama-devel librsvg-devel libxkbcommon-devel
+ pango-devel startup-notification-devel wayland-protocols"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=07892f3f993de3ccc5e3e7705c58a88498216d2a7aaaabb14e29dd2837701691
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
  2021-10-15 19:54 ` [PR PATCH] [Updated] " ram02z
@ 2021-10-15 19:59 ` ram02z
  2021-10-15 20:08 ` ram02z
                   ` (22 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-15 19:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 4024 bytes --]

From 51f3af2f29b60a652f78dfec452bf6c8243748f8 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.0

---
 ...1-meson-fix-version-in-rofi.pc-again.patch | 24 +++++++++++++++
 .../patches/disable-scrollbar-test.patch      | 30 +++++++++++++++++++
 srcpkgs/rofi-wayland/template                 | 23 ++++++++++++++
 3 files changed, 77 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
new file mode 100644
index 000000000000..70119411a816
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
@@ -0,0 +1,24 @@
+From de28766ce014d9cd09c460d520a8a28fbe41fa0d Mon Sep 17 00:00:00 2001
+From: Jakub Jirutka <jakub@jirutka.cz>
+Date: Mon, 4 Oct 2021 00:59:51 +0200
+Subject: [PATCH] [Meson] Fix version in rofi.pc again
+Patch-Source: https://github.com/lbonn/rofi/pull/37
+
+rofi.pc: pkgconf version 1.7.0+wayland1 is invalid
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 604956f11..dfb1af847 100644
+--- a/meson.build
++++ b/meson.build
+@@ -339,7 +339,7 @@ pkg = import('pkgconfig')
+ pkg.generate(
+     filebase: 'rofi',
+     name: 'rofi',
+-    version: meson.project_version().split('-')[0],
++    version: meson.project_version().split('+')[0],
+     description: 'Header files for rofi plugins',
+     variables: [
+         'pluginsdir=@0@'.format(join_paths('${libdir}', meson.project_name())),
diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..fd6b00624ffd
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,30 @@
+Don't run scrollbar test, it fails on i686.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -342,23 +342,6 @@ test('box test', executable('box.test', [
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..81c21b8ae1e9
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.0
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config"
+makedepends="libXinerama-devel librsvg-devel libxkbcommon-devel
+ pango-devel startup-notification-devel wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=07892f3f993de3ccc5e3e7705c58a88498216d2a7aaaabb14e29dd2837701691
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
  2021-10-15 19:54 ` [PR PATCH] [Updated] " ram02z
  2021-10-15 19:59 ` ram02z
@ 2021-10-15 20:08 ` ram02z
  2021-10-15 22:34 ` ram02z
                   ` (21 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-15 20:08 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31

An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 4038 bytes --]

From d4359fac7f52d388a9183ac163967b386ae10f52 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.0

---
 ...1-meson-fix-version-in-rofi.pc-again.patch | 24 +++++++++++++++
 .../patches/disable-scrollbar-test.patch      | 30 +++++++++++++++++++
 srcpkgs/rofi-wayland/template                 | 23 ++++++++++++++
 3 files changed, 77 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
new file mode 100644
index 000000000000..70119411a816
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
@@ -0,0 +1,24 @@
+From de28766ce014d9cd09c460d520a8a28fbe41fa0d Mon Sep 17 00:00:00 2001
+From: Jakub Jirutka <jakub@jirutka.cz>
+Date: Mon, 4 Oct 2021 00:59:51 +0200
+Subject: [PATCH] [Meson] Fix version in rofi.pc again
+Patch-Source: https://github.com/lbonn/rofi/pull/37
+
+rofi.pc: pkgconf version 1.7.0+wayland1 is invalid
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 604956f11..dfb1af847 100644
+--- a/meson.build
++++ b/meson.build
+@@ -339,7 +339,7 @@ pkg = import('pkgconfig')
+ pkg.generate(
+     filebase: 'rofi',
+     name: 'rofi',
+-    version: meson.project_version().split('-')[0],
++    version: meson.project_version().split('+')[0],
+     description: 'Header files for rofi plugins',
+     variables: [
+         'pluginsdir=@0@'.format(join_paths('${libdir}', meson.project_name())),
diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..fd6b00624ffd
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,30 @@
+Don't run scrollbar test, it fails on i686.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -342,23 +342,6 @@ test('box test', executable('box.test', [
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..2cbeed8ee16d
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.0
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="libXinerama-devel librsvg-devel libxkbcommon-devel
+ pango-devel startup-notification-devel wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=07892f3f993de3ccc5e3e7705c58a88498216d2a7aaaabb14e29dd2837701691
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (2 preceding siblings ...)
  2021-10-15 20:08 ` ram02z
@ 2021-10-15 22:34 ` ram02z
  2021-10-15 22:40 ` ram02z
                   ` (20 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-15 22:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1834 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31

An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 3996 bytes --]

From 6c16fbfc4be344d4c44a63643e21699c53baac3e Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.0

---
 ...1-meson-fix-version-in-rofi.pc-again.patch | 24 +++++++++++++++
 .../patches/disable-scrollbar-test.patch      | 30 +++++++++++++++++++
 srcpkgs/rofi-wayland/template                 | 23 ++++++++++++++
 3 files changed, 77 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
new file mode 100644
index 000000000000..70119411a816
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
@@ -0,0 +1,24 @@
+From de28766ce014d9cd09c460d520a8a28fbe41fa0d Mon Sep 17 00:00:00 2001
+From: Jakub Jirutka <jakub@jirutka.cz>
+Date: Mon, 4 Oct 2021 00:59:51 +0200
+Subject: [PATCH] [Meson] Fix version in rofi.pc again
+Patch-Source: https://github.com/lbonn/rofi/pull/37
+
+rofi.pc: pkgconf version 1.7.0+wayland1 is invalid
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 604956f11..dfb1af847 100644
+--- a/meson.build
++++ b/meson.build
+@@ -339,7 +339,7 @@ pkg = import('pkgconfig')
+ pkg.generate(
+     filebase: 'rofi',
+     name: 'rofi',
+-    version: meson.project_version().split('-')[0],
++    version: meson.project_version().split('+')[0],
+     description: 'Header files for rofi plugins',
+     variables: [
+         'pluginsdir=@0@'.format(join_paths('${libdir}', meson.project_name())),
diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..fd6b00624ffd
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,30 @@
+Don't run scrollbar test, it fails on i686.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -342,23 +342,6 @@ test('box test', executable('box.test', [
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..88d531a0ca3c
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.0
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison pkg-config wayland-devel"
+makedepends="glib-devel gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=07892f3f993de3ccc5e3e7705c58a88498216d2a7aaaabb14e29dd2837701691
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (3 preceding siblings ...)
  2021-10-15 22:34 ` ram02z
@ 2021-10-15 22:40 ` ram02z
  2021-10-17 10:41 ` ram02z
                   ` (19 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-15 22:40 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 3996 bytes --]

From 767270188616f9a3ce7a48333abf4d9461fd48b3 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.0

---
 ...1-meson-fix-version-in-rofi.pc-again.patch | 24 +++++++++++++++
 .../patches/disable-scrollbar-test.patch      | 30 +++++++++++++++++++
 srcpkgs/rofi-wayland/template                 | 23 ++++++++++++++
 3 files changed, 77 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
new file mode 100644
index 000000000000..70119411a816
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
@@ -0,0 +1,24 @@
+From de28766ce014d9cd09c460d520a8a28fbe41fa0d Mon Sep 17 00:00:00 2001
+From: Jakub Jirutka <jakub@jirutka.cz>
+Date: Mon, 4 Oct 2021 00:59:51 +0200
+Subject: [PATCH] [Meson] Fix version in rofi.pc again
+Patch-Source: https://github.com/lbonn/rofi/pull/37
+
+rofi.pc: pkgconf version 1.7.0+wayland1 is invalid
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 604956f11..dfb1af847 100644
+--- a/meson.build
++++ b/meson.build
+@@ -339,7 +339,7 @@ pkg = import('pkgconfig')
+ pkg.generate(
+     filebase: 'rofi',
+     name: 'rofi',
+-    version: meson.project_version().split('-')[0],
++    version: meson.project_version().split('+')[0],
+     description: 'Header files for rofi plugins',
+     variables: [
+         'pluginsdir=@0@'.format(join_paths('${libdir}', meson.project_name())),
diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..fd6b00624ffd
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,30 @@
+Don't run scrollbar test, it fails on i686.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -342,23 +342,6 @@ test('box test', executable('box.test', [
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..7e018eca7695
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.0
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=07892f3f993de3ccc5e3e7705c58a88498216d2a7aaaabb14e29dd2837701691
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (4 preceding siblings ...)
  2021-10-15 22:40 ` ram02z
@ 2021-10-17 10:41 ` ram02z
  2021-10-17 10:42 ` ram02z
                   ` (18 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-17 10:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-945089835

Comment:
`xcb-util-cursor-devel` seems to be required for rofi to run, but that shouldn't be the case. I will raise this to upstream. 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (5 preceding siblings ...)
  2021-10-17 10:41 ` ram02z
@ 2021-10-17 10:42 ` ram02z
  2021-10-17 11:20 ` ram02z
                   ` (17 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-17 10:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-945089835

Comment:
`xcb-util-cursor-devel` seems to be required for rofi to run, but that shouldn't be the case. I will raise this issue to upstream. 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (6 preceding siblings ...)
  2021-10-17 10:42 ` ram02z
@ 2021-10-17 11:20 ` ram02z
  2021-10-17 11:20 ` [PR PATCH] [Updated] " ram02z
                   ` (16 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-17 11:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 271 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-945089835

Comment:
`xcb-util-cursor-devel` seems to be required for rofi to run, but that shouldn't be the case. I will raise this issue to upstream. 

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (7 preceding siblings ...)
  2021-10-17 11:20 ` ram02z
@ 2021-10-17 11:20 ` ram02z
  2021-11-03 18:58 ` [PR REVIEW] " TinfoilSubmarine
                   ` (15 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-10-17 11:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 5724 bytes --]

From 58f864a7eb9ce46c16854b582e131e9a7bdfd9f5 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.0

---
 ...1-meson-fix-version-in-rofi.pc-again.patch | 24 ++++++++++++++
 .../patches/disable-scrollbar-test.patch      | 30 +++++++++++++++++
 .../patches/fix-cursor-size.patch             | 33 +++++++++++++++++++
 srcpkgs/rofi-wayland/template                 | 23 +++++++++++++
 4 files changed, 110 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/fix-cursor-size.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
new file mode 100644
index 000000000000..70119411a816
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/0001-meson-fix-version-in-rofi.pc-again.patch
@@ -0,0 +1,24 @@
+From de28766ce014d9cd09c460d520a8a28fbe41fa0d Mon Sep 17 00:00:00 2001
+From: Jakub Jirutka <jakub@jirutka.cz>
+Date: Mon, 4 Oct 2021 00:59:51 +0200
+Subject: [PATCH] [Meson] Fix version in rofi.pc again
+Patch-Source: https://github.com/lbonn/rofi/pull/37
+
+rofi.pc: pkgconf version 1.7.0+wayland1 is invalid
+---
+ meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 604956f11..dfb1af847 100644
+--- a/meson.build
++++ b/meson.build
+@@ -339,7 +339,7 @@ pkg = import('pkgconfig')
+ pkg.generate(
+     filebase: 'rofi',
+     name: 'rofi',
+-    version: meson.project_version().split('-')[0],
++    version: meson.project_version().split('+')[0],
+     description: 'Header files for rofi plugins',
+     variables: [
+         'pluginsdir=@0@'.format(join_paths('${libdir}', meson.project_name())),
diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..fd6b00624ffd
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,30 @@
+Don't run scrollbar test, it fails on i686.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -342,23 +342,6 @@ test('box test', executable('box.test', [
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
diff --git a/srcpkgs/rofi-wayland/patches/fix-cursor-size.patch b/srcpkgs/rofi-wayland/patches/fix-cursor-size.patch
new file mode 100644
index 000000000000..c12d9e32b0c6
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/fix-cursor-size.patch
@@ -0,0 +1,33 @@
+From 745d5a477f08de0cdfc7afc4adad3d152269acc3 Mon Sep 17 00:00:00 2001
+From: sporif <sporif@posteo.net>
+Date: Fri, 15 Oct 2021 12:32:36 +0100
+Subject: [PATCH] Fix cursor size
+
+Default to a size of 24 pixels
+Use the environment variable XCURSOR_SIZE if it's set
+---
+ source/wayland/display.c | 10 +++++++++-
+ 1 file changed, 9 insertions(+), 1 deletion(-)
+
+diff --git a/source/wayland/display.c b/source/wayland/display.c
+index a3490c468..b8efb9b09 100644
+--- a/source/wayland/display.c
++++ b/source/wayland/display.c
+@@ -1208,8 +1208,16 @@ static gboolean wayland_display_setup(GMainLoop *main_loop,
+     return FALSE;
+   }
+
++  guint64 cursor_size = 24;
++  char *env_cursor_size = (char *)g_getenv("XCURSOR_SIZE");
++  if (env_cursor_size && strlen(env_cursor_size) > 0) {
++      guint64 size = g_ascii_strtoull(env_cursor_size, NULL, 10);
++      if (0 < size && size < G_MAXUINT64) {
++          cursor_size = size;
++      }
++  }
+   wayland->cursor.theme =
+-      wl_cursor_theme_load(wayland->cursor.theme_name, 32, wayland->shm);
++      wl_cursor_theme_load(wayland->cursor.theme_name, cursor_size, wayland->shm);
+   if (wayland->cursor.theme != NULL) {
+     const char *const *cname = (const char *const *)wayland->cursor.name;
+     for (cname = (cname != NULL) ? cname : wayland_cursor_names;
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..7e018eca7695
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.0
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=07892f3f993de3ccc5e3e7705c58a88498216d2a7aaaabb14e29dd2837701691
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (8 preceding siblings ...)
  2021-10-17 11:20 ` [PR PATCH] [Updated] " ram02z
@ 2021-11-03 18:58 ` TinfoilSubmarine
  2021-11-03 19:01 ` ram02z
                   ` (14 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: TinfoilSubmarine @ 2021-11-03 18:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New review comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#discussion_r742245373

Comment:
This should probably include something to differentiate this from the `rofi` package. Could just add "- wayland fork" or something...

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (9 preceding siblings ...)
  2021-11-03 18:58 ` [PR REVIEW] " TinfoilSubmarine
@ 2021-11-03 19:01 ` ram02z
  2021-11-03 19:14 ` TinfoilSubmarine
                   ` (13 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-11-03 19:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 174 bytes --]

New review comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#discussion_r742247052

Comment:
You mean in the description?

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR REVIEW] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (10 preceding siblings ...)
  2021-11-03 19:01 ` ram02z
@ 2021-11-03 19:14 ` TinfoilSubmarine
  2021-12-21 23:21 ` [PR PATCH] [Updated] " ram02z
                   ` (12 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: TinfoilSubmarine @ 2021-11-03 19:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

New review comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#discussion_r742255936

Comment:
Correct, for short_desc

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.0
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (11 preceding siblings ...)
  2021-11-03 19:14 ` TinfoilSubmarine
@ 2021-12-21 23:21 ` ram02z
  2021-12-22 13:21 ` [PR PATCH] [Updated] New package: rofi-wayland-1.7.2 ram02z
                   ` (11 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-12-21 23:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.0
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 1379 bytes --]

From 77ea54fbede6d137edbc04330a69465e11c9d43a Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.2

---
 srcpkgs/rofi-wayland/template | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..8122f2dcddca
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.2
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=13c9ac16e9940f72e952d65fdaaa41b0fcbd8da483119a9f6b9bea5940ff2118
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.2
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (12 preceding siblings ...)
  2021-12-21 23:21 ` [PR PATCH] [Updated] " ram02z
@ 2021-12-22 13:21 ` ram02z
  2021-12-22 14:37 ` ram02z
                   ` (10 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-12-22 13:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 2624 bytes --]

From 10d739bb2596513cdfe0e059e34d430d988f299f Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.2

---
 .../patches/disable-scrollbar-test.patch      | 32 +++++++++++++++++++
 srcpkgs/rofi-wayland/template                 | 23 +++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..9cb6c7fee7ba
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,32 @@
+Don't run scrollbar test, it fails on x86.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -410,24 +410,6 @@
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/css-colors.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
+
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..8122f2dcddca
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.2
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=13c9ac16e9940f72e952d65fdaaa41b0fcbd8da483119a9f6b9bea5940ff2118
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.2
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (13 preceding siblings ...)
  2021-12-22 13:21 ` [PR PATCH] [Updated] New package: rofi-wayland-1.7.2 ram02z
@ 2021-12-22 14:37 ` ram02z
  2022-01-30 23:12 ` ram02z
                   ` (9 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2021-12-22 14:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 3643 bytes --]

From fa5560977e79cd29e988fb26f39079a822d968cd Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.2

---
 .../patches/disable-scrollbar-test.patch      | 32 +++++++++++++++++++
 .../patches/fix-libnkutils-test.patch         | 13 ++++++++
 srcpkgs/rofi-wayland/template                 | 23 +++++++++++++
 3 files changed, 68 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..9cb6c7fee7ba
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,32 @@
+Don't run scrollbar test, it fails on x86.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -410,24 +410,6 @@
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/css-colors.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
+
diff --git a/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch b/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
new file mode 100644
index 000000000000..5c9bce1da207
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
@@ -0,0 +1,13 @@
+diff --git a/subprojects/libnkutils/tests/format-string.c b/subprojects/libnkutils/tests/format-string.c
+index d00ad2d..cf69b20 100644
+--- a/subprojects/libnkutils/tests/format-string.c
++++ b/subprojects/libnkutils/tests/format-string.c
+@@ -899,7 +899,7 @@ static const struct {
+         .testpath = "/nkutils/name/replace/escaping/forwardslash/3",
+         .data = {
+             .identifier = '$',
+-            .source = "${data/a/\\//b/x}",
++            .source = "${data/ab/\\/x}",
+             .data = {
+                 { .name = "data", .content = "'ab'" },
+                 { .name = NULL }
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..8122f2dcddca
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.2
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=13c9ac16e9940f72e952d65fdaaa41b0fcbd8da483119a9f6b9bea5940ff2118
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.2
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (14 preceding siblings ...)
  2021-12-22 14:37 ` ram02z
@ 2022-01-30 23:12 ` ram02z
  2022-02-01 23:44 ` [PR PATCH] [Updated] New package: rofi-wayland-1.7.3 ram02z
                   ` (8 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2022-01-30 23:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.2
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 4711 bytes --]

From c4e49ddb2adc97af91ff455985c060f2a8e2f2ff Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH 1/2] New package: rofi-wayland-1.7.2

---
 .../patches/disable-scrollbar-test.patch      | 32 +++++++++++++++++++
 .../patches/fix-libnkutils-test.patch         | 13 ++++++++
 srcpkgs/rofi-wayland/template                 | 23 +++++++++++++
 3 files changed, 68 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..9cb6c7fee7ba
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,32 @@
+Don't run scrollbar test, it fails on x86.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -410,24 +410,6 @@
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/css-colors.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
+
diff --git a/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch b/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
new file mode 100644
index 000000000000..5c9bce1da207
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
@@ -0,0 +1,13 @@
+diff --git a/subprojects/libnkutils/tests/format-string.c b/subprojects/libnkutils/tests/format-string.c
+index d00ad2d..cf69b20 100644
+--- a/subprojects/libnkutils/tests/format-string.c
++++ b/subprojects/libnkutils/tests/format-string.c
+@@ -899,7 +899,7 @@ static const struct {
+         .testpath = "/nkutils/name/replace/escaping/forwardslash/3",
+         .data = {
+             .identifier = '$',
+-            .source = "${data/a/\\//b/x}",
++            .source = "${data/ab/\\/x}",
+             .data = {
+                 { .name = "data", .content = "'ab'" },
+                 { .name = NULL }
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..8122f2dcddca
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.2
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=13c9ac16e9940f72e952d65fdaaa41b0fcbd8da483119a9f6b9bea5940ff2118
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

From 095944694b940f7628bd41b613a9ac0e92a9cb3b Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Sun, 30 Jan 2022 23:12:33 +0000
Subject: [PATCH 2/2] rofi-wayland: update to 1.7.3.

---
 srcpkgs/rofi-wayland/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
index 8122f2dcddca..f4818fbcdffe 100644
--- a/srcpkgs/rofi-wayland/template
+++ b/srcpkgs/rofi-wayland/template
@@ -1,6 +1,6 @@
 # Template file for 'rofi-wayland'
 pkgname=rofi-wayland
-version=1.7.2
+version=1.7.3
 revision=1
 _ver=${version}+wayland1
 wrksrc=rofi-${_ver}
@@ -15,7 +15,7 @@ maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
 license="MIT"
 homepage="https://github.com/lbonn/rofi"
 distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
-checksum=13c9ac16e9940f72e952d65fdaaa41b0fcbd8da483119a9f6b9bea5940ff2118
+checksum=31d912f63403c6db9561f140a2a0e5673390a0fc75ad0be80b45e76b625bf37c
 replaces="rofi>=0"
 
 post_install() {

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (15 preceding siblings ...)
  2022-01-30 23:12 ` ram02z
@ 2022-02-01 23:44 ` ram02z
  2022-03-03 15:14 ` ram02z
                   ` (7 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2022-02-01 23:44 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.3
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 3643 bytes --]

From e1d63026788797f9fa734db6f33c3b6e4053b44c Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.3

---
 .../patches/disable-scrollbar-test.patch      | 32 +++++++++++++++++++
 .../patches/fix-libnkutils-test.patch         | 13 ++++++++
 srcpkgs/rofi-wayland/template                 | 23 +++++++++++++
 3 files changed, 68 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..9cb6c7fee7ba
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,32 @@
+Don't run scrollbar test, it fails on x86.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -410,24 +410,6 @@
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/css-colors.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
+
diff --git a/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch b/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
new file mode 100644
index 000000000000..5c9bce1da207
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
@@ -0,0 +1,13 @@
+diff --git a/subprojects/libnkutils/tests/format-string.c b/subprojects/libnkutils/tests/format-string.c
+index d00ad2d..cf69b20 100644
+--- a/subprojects/libnkutils/tests/format-string.c
++++ b/subprojects/libnkutils/tests/format-string.c
+@@ -899,7 +899,7 @@ static const struct {
+         .testpath = "/nkutils/name/replace/escaping/forwardslash/3",
+         .data = {
+             .identifier = '$',
+-            .source = "${data/a/\\//b/x}",
++            .source = "${data/ab/\\/x}",
+             .data = {
+                 { .name = "data", .content = "'ab'" },
+                 { .name = NULL }
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..f4818fbcdffe
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.3
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=31d912f63403c6db9561f140a2a0e5673390a0fc75ad0be80b45e76b625bf37c
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Updated] New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (16 preceding siblings ...)
  2022-02-01 23:44 ` [PR PATCH] [Updated] New package: rofi-wayland-1.7.3 ram02z
@ 2022-03-03 15:14 ` ram02z
  2022-06-08  2:12 ` github-actions
                   ` (6 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2022-03-03 15:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1989 bytes --]

There is an updated pull request by ram02z against master on the void-packages repository

https://github.com/ram02z/void-packages rofi-wayland
https://github.com/void-linux/void-packages/pull/33578

New package: rofi-wayland-1.7.3
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/33578.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-rofi-wayland-33578.patch --]
[-- Type: text/x-diff, Size: 3658 bytes --]

From 978c7273d7c8b17501f519d3426f049242d4eaa4 Mon Sep 17 00:00:00 2001
From: Omar Zeghouani <omarzeghouanii@gmail.com>
Date: Fri, 15 Oct 2021 20:11:35 +0100
Subject: [PATCH] New package: rofi-wayland-1.7.3

---
 .../patches/disable-scrollbar-test.patch      | 32 +++++++++++++++++++
 .../patches/fix-libnkutils-test.patch         | 13 ++++++++
 srcpkgs/rofi-wayland/template                 | 23 +++++++++++++
 3 files changed, 68 insertions(+)
 create mode 100644 srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
 create mode 100644 srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
 create mode 100644 srcpkgs/rofi-wayland/template

diff --git a/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
new file mode 100644
index 000000000000..9cb6c7fee7ba
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/disable-scrollbar-test.patch
@@ -0,0 +1,32 @@
+Don't run scrollbar test, it fails on x86.
+
+diff --git a/meson.build b/meson.build
+index 6e1105a..f707cd9 100644
+--- a/meson.build
++++ b/meson.build
+@@ -410,24 +410,6 @@
+     dependencies: deps,
+ ))
+
+-test('scrollbar test', executable('scrollbar.test', [
+-        'test/scrollbar-test.c',
+-        theme_parser,
+-        theme_lexer,
+-        default_theme,
+-    ],
+-    objects: rofi.extract_objects([
+-        'source/widgets/widget.c',
+-        'source/widgets/scrollbar.c',
+-        'source/theme.c',
+-        'source/css-colors.c',
+-        'source/rofi-types.c',
+-        'source/css-colors.c',
+-        'config/config.c',
+-    ]),
+-    dependencies: deps,
+-))
+-
+ test('textbox test', executable('textbox.test', [
+         'test/textbox-test.c',
+         theme_parser,
+
diff --git a/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch b/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
new file mode 100644
index 000000000000..5c9bce1da207
--- /dev/null
+++ b/srcpkgs/rofi-wayland/patches/fix-libnkutils-test.patch
@@ -0,0 +1,13 @@
+diff --git a/subprojects/libnkutils/tests/format-string.c b/subprojects/libnkutils/tests/format-string.c
+index d00ad2d..cf69b20 100644
+--- a/subprojects/libnkutils/tests/format-string.c
++++ b/subprojects/libnkutils/tests/format-string.c
+@@ -899,7 +899,7 @@ static const struct {
+         .testpath = "/nkutils/name/replace/escaping/forwardslash/3",
+         .data = {
+             .identifier = '$',
+-            .source = "${data/a/\\//b/x}",
++            .source = "${data/ab/\\/x}",
+             .data = {
+                 { .name = "data", .content = "'ab'" },
+                 { .name = NULL }
diff --git a/srcpkgs/rofi-wayland/template b/srcpkgs/rofi-wayland/template
new file mode 100644
index 000000000000..38a8b4211aaa
--- /dev/null
+++ b/srcpkgs/rofi-wayland/template
@@ -0,0 +1,23 @@
+# Template file for 'rofi-wayland'
+pkgname=rofi-wayland
+version=1.7.3
+revision=1
+_ver=${version}+wayland1
+wrksrc=rofi-${_ver}
+build_style=meson
+configure_args="-Dxcb=disabled -Dcheck=disabled"
+hostmakedepends="ninja flex bison glib-devel pkg-config wayland-devel"
+makedepends="gdk-pixbuf-devel libxkbcommon-devel pango-devel
+ wayland-protocols wayland-devel"
+checkdepends="check-devel cppcheck xkeyboard-config"
+short_desc="Window switcher, run dialog and dmenu replacement (Wayland fork)"
+maintainer="Omar Zeghouani <omarzeghouanii@gmail.com>"
+license="MIT"
+homepage="https://github.com/lbonn/rofi"
+distfiles="https://github.com/lbonn/rofi/releases/download/${_ver}/rofi-${_ver}.tar.gz"
+checksum=31d912f63403c6db9561f140a2a0e5673390a0fc75ad0be80b45e76b625bf37c
+replaces="rofi>=0"
+
+post_install() {
+	vlicense COPYING
+}

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (17 preceding siblings ...)
  2022-03-03 15:14 ` ram02z
@ 2022-06-08  2:12 ` github-actions
  2022-06-08  7:51 ` ram02z
                   ` (5 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: github-actions @ 2022-06-08  2:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-1149373879

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (18 preceding siblings ...)
  2022-06-08  2:12 ` github-actions
@ 2022-06-08  7:51 ` ram02z
  2022-07-18 14:15 ` ahesford
                   ` (4 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2022-06-08  7:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-1149582854

Comment:
Bump

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (19 preceding siblings ...)
  2022-06-08  7:51 ` ram02z
@ 2022-07-18 14:15 ` ahesford
  2022-07-18 14:15 ` [PR PATCH] [Closed]: " ahesford
                   ` (3 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ahesford @ 2022-07-18 14:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 980 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-1187545403

Comment:
I'm not sure to what extend `wofi` fills the need for `rofi` on Wayland, but I don't think this is a good candidate for a separate package. It uses the same name and shadows upstream versions, leading to confusion about the authoritative upstream. The `replaces` directive here (incorrectly used) masks a conflict caused by executable naming that deepens confusion about what is running from where.

The original `rofi` author, still actively developing the software, has shown no interest in Wayland support. If this work won't be upstreamed, it's probably time for the fork maintainer to take the project in its own direction. We could talk about the value of moving the main package to a fork that provides both X and Wayland support, but given that the original project is still actively developed, that's going to be a tough sale.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PR PATCH] [Closed]: New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (20 preceding siblings ...)
  2022-07-18 14:15 ` ahesford
@ 2022-07-18 14:15 ` ahesford
  2022-07-18 14:25 ` ram02z
                   ` (2 subsequent siblings)
  24 siblings, 0 replies; 26+ messages in thread
From: ahesford @ 2022-07-18 14:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1830 bytes --]

There's a closed pull request on the void-packages repository

New package: rofi-wayland-1.7.3
https://github.com/void-linux/void-packages/pull/33578

Description:
<!-- Mark items with [x] where applicable -->

#### General
- [x] This is a new package and it conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements)

#### Have the results of the proposed changes been tested?
- [x] I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
- [ ] I generally don't use the affected packages but briefly tested this PR

Inspired by the alpine package, I have disabled xcb to make it wayland only. See https://github.com/lbonn/rofi/pull/31


An alternative would be to switch the current rofi template to use this fork to allow for wayland support. 

I have attempted to keep the dependencies to a minimum, so I would appreciate if anyone testing this can let me know if there are missing dependencies.
<!--
If GitHub CI cannot be used to validate the build result (for example, if the
build is likely to take several hours), make sure to
[skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration).
When skipping CI, uncomment and fill out the following section.
Note: for builds that are likely to complete in less than 2 hours, it is not
acceptable to skip CI.
-->
<!-- 
#### Does it build and run successfully? 
(Please choose at least one native build and, if supported, at least one cross build. More are better.)
- [ ] I built this PR locally for my native architecture, (ARCH-LIBC)
- [ ] I built this PR locally for these architectures (if supported. mark crossbuilds):
  - [ ] aarch64-musl
  - [ ] armv7l
  - [ ] armv6l-musl
-->


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (21 preceding siblings ...)
  2022-07-18 14:15 ` [PR PATCH] [Closed]: " ahesford
@ 2022-07-18 14:25 ` ram02z
  2022-07-18 14:35 ` paper42
  2022-07-18 14:50 ` ram02z
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2022-07-18 14:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-1187566090

Comment:
> I'm not sure to what extend `wofi` fills the need for `rofi` on Wayland, but I don't think this is a good candidate for a separate package. It uses the same name and shadows upstream versions, leading to confusion about the authoritative upstream. The `replaces` directive here (incorrectly used) masks a conflict caused by executable naming that deepens confusion about what is running from where.
> 
> The original `rofi` author, still actively developing the software, has shown no interest in Wayland support. If this work won't be upstreamed, it's probably time for the fork maintainer to take the project in its own direction. We could talk about the value of moving the main package to a fork that provides both X and Wayland support, but given that the original project is still actively developed, that's going to be a tough sale.

That's fair, but I did ask if the `replaces` directive was correct here but didn't get a response.

As far as I know, wofi is unmaintained but it worked fine when I tried it.

For anyone still interested in using the rofi-wayland fork, I have it in my public repository; github.com/ram02z/void-templates

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (22 preceding siblings ...)
  2022-07-18 14:25 ` ram02z
@ 2022-07-18 14:35 ` paper42
  2022-07-18 14:50 ` ram02z
  24 siblings, 0 replies; 26+ messages in thread
From: paper42 @ 2022-07-18 14:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-1187578640

Comment:
> As far as I know, wofi is unmaintained but it worked fine when I tried it.

https://hg.sr.ht/~scoopta/wofi last commit: a day ago


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: New package: rofi-wayland-1.7.3
  2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
                   ` (23 preceding siblings ...)
  2022-07-18 14:35 ` paper42
@ 2022-07-18 14:50 ` ram02z
  24 siblings, 0 replies; 26+ messages in thread
From: ram02z @ 2022-07-18 14:50 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

New comment by ram02z on void-packages repository

https://github.com/void-linux/void-packages/pull/33578#issuecomment-1187566090

Comment:
> I'm not sure to what extend `wofi` fills the need for `rofi` on Wayland, but I don't think this is a good candidate for a separate package. It uses the same name and shadows upstream versions, leading to confusion about the authoritative upstream. The `replaces` directive here (incorrectly used) masks a conflict caused by executable naming that deepens confusion about what is running from where.
> 
> The original `rofi` author, still actively developing the software, has shown no interest in Wayland support. If this work won't be upstreamed, it's probably time for the fork maintainer to take the project in its own direction. We could talk about the value of moving the main package to a fork that provides both X and Wayland support, but given that the original project is still actively developed, that's going to be a tough sale.

That's fair, but I did ask if the `replaces` directive was correct here but didn't get a response.

As far as I know, wofi is ~~unmaintained~~ maintained but it worked fine when I tried it.

For anyone still interested in using the rofi-wayland fork, I have it in my public repository; github.com/ram02z/void-templates

^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2022-07-18 14:50 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-15 19:46 [PR PATCH] New package: rofi-wayland-1.7.0 ram02z
2021-10-15 19:54 ` [PR PATCH] [Updated] " ram02z
2021-10-15 19:59 ` ram02z
2021-10-15 20:08 ` ram02z
2021-10-15 22:34 ` ram02z
2021-10-15 22:40 ` ram02z
2021-10-17 10:41 ` ram02z
2021-10-17 10:42 ` ram02z
2021-10-17 11:20 ` ram02z
2021-10-17 11:20 ` [PR PATCH] [Updated] " ram02z
2021-11-03 18:58 ` [PR REVIEW] " TinfoilSubmarine
2021-11-03 19:01 ` ram02z
2021-11-03 19:14 ` TinfoilSubmarine
2021-12-21 23:21 ` [PR PATCH] [Updated] " ram02z
2021-12-22 13:21 ` [PR PATCH] [Updated] New package: rofi-wayland-1.7.2 ram02z
2021-12-22 14:37 ` ram02z
2022-01-30 23:12 ` ram02z
2022-02-01 23:44 ` [PR PATCH] [Updated] New package: rofi-wayland-1.7.3 ram02z
2022-03-03 15:14 ` ram02z
2022-06-08  2:12 ` github-actions
2022-06-08  7:51 ` ram02z
2022-07-18 14:15 ` ahesford
2022-07-18 14:15 ` [PR PATCH] [Closed]: " ahesford
2022-07-18 14:25 ` ram02z
2022-07-18 14:35 ` paper42
2022-07-18 14:50 ` ram02z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).