[PR PATCH] synapse: update to 1.49.2.

[PR PATCH] synapse: update to 1.49.2.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

There is a new pull request by TinfoilSubmarine against master on the void-packages repository

https://github.com/TinfoilSubmarine/void-packages synapse
https://github.com/void-linux/void-packages/pull/34682

synapse: update to 1.49.2.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/34682.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-synapse-34682.patch --]
[-- Type: text/x-diff, Size: 1176 bytes --]

From b87a19bab18479421dc296b43f5893b3bb4648cd Mon Sep 17 00:00:00 2001
From: Joel Beckmeyer <joel@beckmeyer.us>
Date: Thu, 23 Dec 2021 17:31:03 -0500
Subject: [PATCH] synapse: update to 1.49.2.

---
 srcpkgs/synapse/template | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/synapse/template b/srcpkgs/synapse/template
index 2452f6a26ca4..abdb2e314e62 100644
--- a/srcpkgs/synapse/template
+++ b/srcpkgs/synapse/template
@@ -1,7 +1,7 @@
 # Template file for 'synapse'
 pkgname=synapse
-version=1.49.0
-revision=2
+version=1.49.2
+revision=1
 build_style=python3-module
 hostmakedepends="python3-setuptools"
 depends="python3-jsonschema python3-frozendict python3-canonicaljson
@@ -19,7 +19,7 @@ license="Apache-2.0"
 homepage="https://github.com/matrix-org/synapse"
 changelog="https://raw.githubusercontent.com/matrix-org/synapse/develop/CHANGES.md"
 distfiles="https://github.com/matrix-org/synapse/archive/v${version}.tar.gz"
-checksum=3c1b73eb36ec3af00868707b929f9b9d1faae9ccc4022c2c46bdb025ef0ead8e
+checksum=f5b0017e9d77db94fac853fbefbcb4538d879cb80f404b02003930c76f5cafab
 
 system_accounts="synapse"
 synapse_homedir="/var/lib/synapse"

Re: synapse: update to 1.49.2.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/34682#issuecomment-1000551649

Comment:
@Chocimier I saw that you switched to using `vsconf` on the config files to avoid overwriting any existing config files. Is there a fix for that? I could take a look at fixing/changing the behavior, was just curious if there was some history with this bug that would be helpful context before digging in too deep :)

Re: synapse: update to 1.49.2.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/34682#issuecomment-1001042331

Comment:
Nvm, just saw https://github.com/void-linux/xbps/issues/441

Re: [PR PATCH] [Merged]: synapse: update to 1.49.2.

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 1060 bytes --]

There's a merged pull request on the void-packages repository

synapse: update to 1.49.2.
https://github.com/void-linux/void-packages/pull/34682

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: synapse: update to 1.49.2.

[freshprince]

[-- Attachment #1: Type: text/plain, Size: 1279 bytes --]

New comment by freshprince on void-packages repository

https://github.com/void-linux/void-packages/pull/34676#issuecomment-1003314686

Comment:
>> explicit is better than implicit because if you want to check logs you
>> shouldn't need to know what's the default behaviour of vlogger

> We'll need to have a Void team member weigh in on this because the history of
> the logging service (introduced in #31263) was what made me start using
> vlogger instead of the older exec logger ... pattern.

For synapse, logging of stderr doesn't really make sense anyway since it only
produces output when there's a problem with the configuration.

> You are correct that this is confusing, so likely these paragraphs should be
> patched out as well.

Sure you can ignore what the authors of the software and people that use it
tell you and do it anyway.

> these are either optional or only needed for advanced functionality

If registering a user in the command line (which you do when you follow the
installation instructions) is advanced functionality for you.

I've rearranged my patches. Feel free to do with them as you please. I'll just
```
echo -e "preserve=/etc/synapse/*\npreserve=/etc/sv/synapse/*" >> /etc/xbps.d/synapse.conf
```
and be done with it.

Re: synapse: update to 1.49.2.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 1587 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/34676#issuecomment-1003061398

Comment:
> explicit is better than implicit because if you want to check logs you shouldn't need to know what's the default behaviour of vlogger

We'll need to have a Void team member weigh in on this because the history of the logging service (introduced in https://github.com/void-linux/void-packages/pull/31263) was what made me start using vlogger instead of the older `exec logger ...` pattern.

> If you read the [first three paragraphs of the config file that you want to install](https://github.com/matrix-org/synapse/blob/develop/docs/sample_config.yaml) you see that this config file is not intended to be copied into `/etc/synapse`, patched or otherwise. The config does contain several secrets that should be randomly generated and for this the correct and documented way is to use `generate_config`

I compared the output of `generate_config` with the patched `sample_config.yaml` and the only difference was that the header was included and the `log_config` location differed slightly. You are correct that this is confusing, so likely these paragraphs should be patched out as well. As far as secret generation, that is optional for having a working server, I specifically tested this. The comments above the three secrets that would be generated (`registration_shared_secret`, `macaroon_secret_key`, and `form_secret`) indicate that these are either optional or only needed for advanced functionality such as consent forms.

Re: synapse: update to 1.49.2.

[freshprince]

[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]

New comment by freshprince on void-packages repository

https://github.com/void-linux/void-packages/pull/34676#issuecomment-1002971905

Comment:
> Was curious what benefit directly execing logger has? I have this running on my system and synapse is already logging to daemon.notice.

I was used to see error output in the logging space of `runsvdir`, when I saw that there was a logging service running for synapse there was no easy way for me to see where it is logging to. All other services I use do have explicitly set where they are logging to and in this case explicit is better than implicit because if you want to check logs you shouldn't need to know what's the default behaviour of vlogger.

> For patching config files, I'd like to have the config file updates installed so that e.g. xdiff from xtools can be used to easily manage updates/changes to the synapse configuration. Currently that's waiting on void-linux/xbps#426, then hopefully we can install to /etc/synapse instead of vsconf.

If you read the [first three paragraphs of the config file that you want to install](https://github.com/matrix-org/synapse/blob/develop/docs/sample_config.yaml) you see that this config file is not intended to be copied into `/etc/synapse`, patched or otherwise. The config does contain several secrets that should be randomly generated and for this the correct and documented way is to use `generate_config`. Regardless of the behaviour of xbps that resulted in https://github.com/void-linux/xbps/issues/441.

Please test your patches before you create pull requests.

Re: synapse: update to 1.49.2.

[freshprince]

[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]

New comment by freshprince on void-packages repository

https://github.com/void-linux/void-packages/pull/34676#issuecomment-1002971905

Comment:
> Was curious what benefit directly execing logger has? I have this running on my system and synapse is already logging to daemon.notice.

I was used to see error output in the logging space of `runsvdir`, when I saw that there was a logging service running for synapse there was no easy way for me to see where it is logging to. All other services I use do have explicitly set where they are logging to and in this case explicit is better than implicit because if you want to check logs you shouldn't need to know what's the default behaviour of vlogger.

> For patching config files, I'd like to have the config file updates installed so that e.g. xdiff from xtools can be used to easily manage updates/changes to the synapse configuration. Currently that's waiting on void-linux/xbps#426, then hopefully we can install to /etc/synapse instead of vsconf.

If you read the [first three paragraphs of the config file that you want to install](https://github.com/matrix-org/synapse/blob/develop/docs/sample_config.yaml) you see that this config file is not intendet to be copied into `/etc/synapse`, patched or otherwise. The config does contain several secrets that should be randomly generated and for this the correct and documented way is to use `generate_config`. Regardles of the behaviour of xbps that resulted in https://github.com/void-linux/xbps/issues/441.

Please test your patches before you create pull requests.

Re: synapse: update to 1.49.2.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/34676#issuecomment-1002853882

Comment:
Should also mention that https://github.com/void-linux/void-packages/pull/34682 has already been merged.

Re: synapse: update to 1.49.2.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/34676#issuecomment-1002851025

Comment:
Hi, just saw this PR. I've been maintaining the package and added the `/usr/bin/vlogger -> /etc/sv/synapse/log/run` symlink. Was curious what benefit directly `exec`ing `logger` has? I have this running on my system and synapse is already logging to daemon.notice.

The configurable config file location looks good to me.

For patching config files, I'd like to have the config file updates installed so that e.g. `xdiff` from xtools can be used to easily manage updates/changes to the synapse configuration. Currently that's waiting on https://github.com/void-linux/xbps/pull/426, then hopefully we can install to `/etc/synapse` instead of vsconf.

Re: synapse: update to 1.49.2.

[TinfoilSubmarine]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/34676#issuecomment-1002851025

Comment:
Hi, just saw this PR. I've been maintaining the package and added the `/usr/bin/vlogger -> /etc/sv/synapse/log/run` symlink. Was curious what benefit directly `exec`ing `logger` has? I have this running on my system and synapse is already logging to daemon.notice.

The configurable config file location looks good to me.

For patching config files, I'd like to have the config file updates installed so that e.g. `xdiff` from xtools can be used to easily manage updates/changes to the synapse configuration. Currently that's waiting on https://github.com/void-linux/xbps/issues/441, then hopefully we can install to `/etc/synapse` instead of vsconf.