Github messages for voidlinux
 help / color / mirror / Atom feed
From: hervyqa <hervyqa@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] LibreCAD: fix missing built-in plugins menu
Date: Mon, 27 Dec 2021 15:01:52 +0100	[thread overview]
Message-ID: <20211227140152.9w7-mYkFDqtaowuCfVqu26FqSIdgMwlGzTT1MdmIcps@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34683@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

There is an updated pull request by hervyqa against master on the void-packages repository

https://github.com/hervyqa/void-packages LibreCAD
https://github.com/void-linux/void-packages/pull/34683

LibreCAD: fix missing built-in plugins menu
Solved #32497

#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)

https://user-images.githubusercontent.com/45872139/147313649-5c5f7710-8f24-4e88-8f6b-b0d7e60a6aee.mp4


A patch file from https://github.com/void-linux/void-packages/pull/34683.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-LibreCAD-34683.patch --]
[-- Type: text/x-diff, Size: 2566 bytes --]

From b11e97ee8970e322d4791ee9157d172988da8ed8 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur Rozi <hervyqa@pm.me>
Date: Fri, 24 Dec 2021 10:38:16 +0700
Subject: [PATCH 1/2] LibreCAD: fix missing built-in menu

---
 srcpkgs/LibreCAD/template | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/LibreCAD/template b/srcpkgs/LibreCAD/template
index 4de5398f119b..bb2ea57881cc 100644
--- a/srcpkgs/LibreCAD/template
+++ b/srcpkgs/LibreCAD/template
@@ -1,7 +1,7 @@
 # Template file for 'LibreCAD'
 pkgname=LibreCAD
 version=2.1.3
-revision=4
+revision=5
 build_style=qmake
 hostmakedepends="qt5-qmake pkg-config ImageMagick qt5-host-tools"
 makedepends="qt5-devel qt5-svg-devel boost-devel muparser-devel librsvg-devel"
@@ -46,9 +46,14 @@ do_install() {
 	vcopy librecad.svg usr/share/icons/hicolor/scalable/apps
 
 	# install resources
-	for resource in library patterns fonts qm; do
+	for resource in fonts library patterns qm; do
 		vcopy unix/resources/${resource} usr/share/librecad/
 	done
 
-    vcopy unix/resources/plugins usr/lib/librecad/
+	# install plugins
+	vmkdir usr/share/librecad/plugins
+	vcopy unix/resources/plugins usr/lib/librecad/
+	for plugins in libalign libasciifile libimportshp liblist libpicfile libplotequation libsameprop libsample; do
+		ln -sf ../../../lib/librecad/${plugins}.so ${DESTDIR}/usr/share/librecad/plugins/${plugins}.so
+	done
 }

From 69f528f979baed555d166921a8dfd37c80abd812 Mon Sep 17 00:00:00 2001
From: Hervy Qurrotul Ainur <hervyqa@pm.me>
Date: Sun, 26 Dec 2021 13:15:41 +0700
Subject: [PATCH 2/2] LibreCAD: fix plugin menu
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Érico Nogueira Rolim <34201958+ericonr@users.noreply.github.com>
---
 srcpkgs/LibreCAD/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/LibreCAD/template b/srcpkgs/LibreCAD/template
index bb2ea57881cc..36f326bf40ea 100644
--- a/srcpkgs/LibreCAD/template
+++ b/srcpkgs/LibreCAD/template
@@ -53,7 +53,7 @@ do_install() {
 	# install plugins
 	vmkdir usr/share/librecad/plugins
 	vcopy unix/resources/plugins usr/lib/librecad/
-	for plugins in libalign libasciifile libimportshp liblist libpicfile libplotequation libsameprop libsample; do
-		ln -sf ../../../lib/librecad/${plugins}.so ${DESTDIR}/usr/share/librecad/plugins/${plugins}.so
+	for plugin in $DESTDIR/usr/lib/librecad/*.so ; do
+		ln -sf ../../../lib/librecad/$(basename $plugin) ${DESTDIR}/usr/share/librecad/plugins/$(basename $plugin)
 	done
 }

  parent reply	other threads:[~2021-12-27 14:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-24  3:49 [PR PATCH] LibreCAD: fix missing built-in menu hervyqa
2021-12-25  5:55 ` LibreCAD: fix missing built-in plugins menu hervyqa
2021-12-26  2:37 ` [PR REVIEW] " ericonr
2021-12-26  6:14 ` hervyqa
2021-12-26  6:15 ` [PR PATCH] [Updated] " hervyqa
2021-12-26  9:58 ` [PR REVIEW] " hervyqa
2021-12-27 14:01 ` hervyqa [this message]
2021-12-27 14:16 ` [PR PATCH] [Updated] " hervyqa
2021-12-27 14:40 ` ericonr
2021-12-27 15:19 ` [PR PATCH] [Updated] " hervyqa
2021-12-27 15:42 ` hervyqa
2021-12-27 19:35 ` hervyqa
2021-12-27 21:53 ` ericonr
2021-12-27 22:28 ` ericonr
2021-12-27 22:28 ` [PR PATCH] [Merged]: " ericonr

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211227140152.9w7-mYkFDqtaowuCfVqu26FqSIdgMwlGzTT1MdmIcps@z \
    --to=hervyqa@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).