From: NyaaaWhatsUpDoc <NyaaaWhatsUpDoc@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: github-cli: update to 2.2.0.
Date: Thu, 30 Dec 2021 21:22:59 +0100 [thread overview]
Message-ID: <20211230202259.jwBiVVqE6p-m1f1YovGihZW3Cg4DFs7pj1B6zsRiR94@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34157@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
New comment by NyaaaWhatsUpDoc on void-packages repository
https://github.com/void-linux/void-packages/pull/34157#issuecomment-1003170236
Comment:
Might we want to build this using the repository makefile? Also the version info we're pulling in for the ldflags looks to be not using the v2 major version. See the build process in: https://github.com/cli/cli/blob/trunk/script/build.go
That might be the issue causing the above too.
next prev parent reply other threads:[~2021-12-30 20:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 14:35 [PR PATCH] " shizonic
2021-11-20 2:26 ` [PR REVIEW] " ericonr
2021-11-22 7:46 ` shizonic
2021-12-30 20:22 ` NyaaaWhatsUpDoc [this message]
2021-12-30 20:24 ` NyaaaWhatsUpDoc
2021-12-30 20:40 ` NyaaaWhatsUpDoc
2022-01-04 8:23 ` [PR PATCH] [Updated] " shizonic
2022-01-04 8:25 ` github-cli: update to 2.4.0 shizonic
2022-01-13 16:50 ` paper42
2022-01-19 8:25 ` [PR PATCH] [Updated] " shizonic
2022-01-19 8:25 ` shizonic
2022-01-19 9:26 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211230202259.jwBiVVqE6p-m1f1YovGihZW3Cg4DFs7pj1B6zsRiR94@z \
--to=nyaaawhatsupdoc@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).