* [PR PATCH] caddy: add missing dependency
@ 2022-01-01 0:38 steinex
2022-01-01 17:12 ` paper42
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: steinex @ 2022-01-01 0:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]
There is a new pull request by steinex against master on the void-packages repository
https://github.com/steinex/void-packages caddy
https://github.com/void-linux/void-packages/pull/34795
caddy: add missing dependency
Without mime-types installed Caddy silently omits certain headers,
especially Content-Type.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34795.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-caddy-34795.patch --]
[-- Type: text/x-diff, Size: 913 bytes --]
From 78364742c94ac5497c943ca0e19a266a3b9d965e Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Sat, 1 Jan 2022 01:35:13 +0100
Subject: [PATCH] caddy: add missing dependency
Without mime-types installed Caddy silently omits certain headers,
especially Content-Type.
---
srcpkgs/caddy/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/caddy/template b/srcpkgs/caddy/template
index 5dcc5c0a42ab..192d0eb873cf 100644
--- a/srcpkgs/caddy/template
+++ b/srcpkgs/caddy/template
@@ -1,10 +1,11 @@
# Template file for 'caddy'
pkgname=caddy
version=2.4.6
-revision=1
+revision=2
build_style=go
go_import_path=github.com/caddyserver/caddy/v2
go_package="${go_import_path}/cmd/caddy"
+depends="mime-types"
short_desc="Fast, cross-platform HTTP/2 web server with automatic HTTPS"
maintainer="Dominic Monroe <monroef4@googlemail.com>"
license="Apache-2.0"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: caddy: add missing dependency
2022-01-01 0:38 [PR PATCH] caddy: add missing dependency steinex
@ 2022-01-01 17:12 ` paper42
2022-01-01 17:44 ` [PR PATCH] [Updated] " steinex
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-01-01 17:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 405 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/34795#issuecomment-1003587040
Comment:
It seems like since go 1.17, it first tries to read the shared MIME-info database, would it make sense to depend on shared-mime-info?
https://github.com/caddyserver/caddy/issues/4287
https://github.com/golang/go/commit/02beecb3974e9010d2deefaf09266286b0c6f408
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Updated] caddy: add missing dependency
2022-01-01 0:38 [PR PATCH] caddy: add missing dependency steinex
2022-01-01 17:12 ` paper42
@ 2022-01-01 17:44 ` steinex
2022-01-01 17:45 ` steinex
2022-01-01 17:51 ` [PR PATCH] [Merged]: " paper42
3 siblings, 0 replies; 5+ messages in thread
From: steinex @ 2022-01-01 17:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]
There is an updated pull request by steinex against master on the void-packages repository
https://github.com/steinex/void-packages caddy
https://github.com/void-linux/void-packages/pull/34795
caddy: add missing dependency
Without mime-types installed Caddy silently omits certain headers,
especially Content-Type.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34795.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-caddy-34795.patch --]
[-- Type: text/x-diff, Size: 925 bytes --]
From 7f62d069833556e27caa5fb610b75b7f308aad9c Mon Sep 17 00:00:00 2001
From: Frank Steinborn <steinex@nognu.de>
Date: Sat, 1 Jan 2022 01:35:13 +0100
Subject: [PATCH] caddy: add missing dependency
Without shared-mime-info installed Caddy silently omits certain
headers, especially Content-Type.
---
srcpkgs/caddy/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/caddy/template b/srcpkgs/caddy/template
index 5dcc5c0a42ab..762a36749b46 100644
--- a/srcpkgs/caddy/template
+++ b/srcpkgs/caddy/template
@@ -1,10 +1,11 @@
# Template file for 'caddy'
pkgname=caddy
version=2.4.6
-revision=1
+revision=2
build_style=go
go_import_path=github.com/caddyserver/caddy/v2
go_package="${go_import_path}/cmd/caddy"
+depends="shared-mime-info"
short_desc="Fast, cross-platform HTTP/2 web server with automatic HTTPS"
maintainer="Dominic Monroe <monroef4@googlemail.com>"
license="Apache-2.0"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: caddy: add missing dependency
2022-01-01 0:38 [PR PATCH] caddy: add missing dependency steinex
2022-01-01 17:12 ` paper42
2022-01-01 17:44 ` [PR PATCH] [Updated] " steinex
@ 2022-01-01 17:45 ` steinex
2022-01-01 17:51 ` [PR PATCH] [Merged]: " paper42
3 siblings, 0 replies; 5+ messages in thread
From: steinex @ 2022-01-01 17:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New comment by steinex on void-packages repository
https://github.com/void-linux/void-packages/pull/34795#issuecomment-1003591659
Comment:
Yes, that makes sense. I changed to shared-mime-info and verified that this works aswell.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PR PATCH] [Merged]: caddy: add missing dependency
2022-01-01 0:38 [PR PATCH] caddy: add missing dependency steinex
` (2 preceding siblings ...)
2022-01-01 17:45 ` steinex
@ 2022-01-01 17:51 ` paper42
3 siblings, 0 replies; 5+ messages in thread
From: paper42 @ 2022-01-01 17:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]
There's a merged pull request on the void-packages repository
caddy: add missing dependency
https://github.com/void-linux/void-packages/pull/34795
Description:
Without mime-types installed Caddy silently omits certain headers,
especially Content-Type.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-01 17:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-01 0:38 [PR PATCH] caddy: add missing dependency steinex
2022-01-01 17:12 ` paper42
2022-01-01 17:44 ` [PR PATCH] [Updated] " steinex
2022-01-01 17:45 ` steinex
2022-01-01 17:51 ` [PR PATCH] [Merged]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).