From: sug0 <sug0@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: lollypop: update to 1.4.26
Date: Sat, 01 Jan 2022 23:26:51 +0100 [thread overview]
Message-ID: <20220101222651.9Zmch7L2fYjkWZhnqWLbtgjLX7YdZ2ZUJfhatNlQsac@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34801@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 919 bytes --]
New comment by sug0 on void-packages repository
https://github.com/void-linux/void-packages/pull/34801#issuecomment-1003628783
Comment:
Builds fine without `cmake` and `git`. Removed those. Also fixed up the `distfiles`.
> I think we can also remove python3-youtube-dl and python3-dbus from depends.
I tested the package without `python3-dbus` and it seems to be working fine. There is no actual code using dbus I think. This is the output of `rg dbus` in the lollypop source tree:
```
search-provider/meson.build
1:service_dir = join_paths(get_option('datadir'), 'dbus-1', 'services')
search-provider/lollypop-sp.in
116: 'http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd'>
lollypop/mpris.py
84: "http://www.freedesktop.org/standards/dbus/1.0/introspect.dtd">
```
So, `python3-dbus` is gone as well. On the other hand, we still require `youtube-dl`. It's used as a dependency.
next prev parent reply other threads:[~2022-01-01 22:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-01 19:08 [PR PATCH] " sug0
2022-01-01 22:03 ` [PR REVIEW] " paper42
2022-01-01 22:03 ` paper42
2022-01-01 22:17 ` [PR PATCH] [Updated] " sug0
2022-01-01 22:18 ` sug0
2022-01-01 22:26 ` sug0
2022-01-01 22:26 ` sug0 [this message]
2022-01-01 23:16 ` sug0
2022-01-01 23:25 ` sug0
2022-01-02 1:20 ` sug0
2022-01-02 1:21 ` sug0
2022-01-02 1:23 ` sug0
2022-01-02 11:33 ` [PR PATCH] [Merged]: " paper42
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220101222651.9Zmch7L2fYjkWZhnqWLbtgjLX7YdZ2ZUJfhatNlQsac@z \
--to=sug0@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).