Github messages for voidlinux
 help / color / mirror / Atom feed
From: balejk <balejk@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: root-6.24.06
Date: Sun, 02 Jan 2022 22:24:53 +0100	[thread overview]
Message-ID: <20220102212453.D0q4wXR5n1blDc78tJmUD5OOSIoxTlGSnCSbWw4vsHQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34647@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]

New comment by balejk on void-packages repository

https://github.com/void-linux/void-packages/pull/34647#issuecomment-1003777614

Comment:
I believe specifying `cmake` as `hostmakedepends` is unnecessary with the selected build style. I also think that it should suffice to use the `gnuinstall` option, installation and mandir prefixes should be set accordingly automatically.

Making using `ninja` worked fine for me, so I see no reason to override it to use `make` - do you have one?

Have you tried cross-building for any other architecture? These two might be the only officially supported ones, but that does not necessarily mean that it won't work on any other.

And have you disabled the `xrootd` option globally on purpose or did you mean to do it just for musl where it won't build? Also, I see that you have set TBB as a dependency - with that, it might be possible to make `imt` available for musl as well, as the compilation is failing there because of the builtin TBB. I believe `cmake` should detect system TBB automatically if you remove `imt=OFF`. Will you be able to try it?

Last thing that comes to mind is that it might be nice to add a `build_option` for the R bindings (preferably disabled by default though).

  parent reply	other threads:[~2022-01-02 21:24 UTC|newest]

Thread overview: 105+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-21 16:55 [PR PATCH] " BenJarg
2021-12-21 16:59 ` [PR REVIEW] " Duncaen
2021-12-21 20:35 ` [PR PATCH] [Updated] " BenJarg
2021-12-21 20:48 ` [PR REVIEW] " BenJarg
2021-12-22  3:00 ` [PR PATCH] [Updated] " BenJarg
2021-12-23  2:47 ` BenJarg
2021-12-23  9:45 ` balejk
2021-12-23 17:24 ` BenJarg
2021-12-23 17:55 ` [PR PATCH] [Updated] " BenJarg
2021-12-24  0:17 ` BenJarg
2021-12-30 18:25 ` [PR PATCH] [Updated] " BenJarg
2021-12-30 22:22 ` Chocimier
2021-12-31  2:27 ` [PR PATCH] [Updated] " BenJarg
2021-12-31  2:40 ` BenJarg
2022-01-02 21:24 ` balejk [this message]
2022-01-02 21:34 ` balejk
2022-01-02 23:33 ` BenJarg
2022-01-03  7:43 ` [PR PATCH] [Updated] " BenJarg
2022-01-03  8:30 ` BenJarg
2022-01-03  9:22 ` balejk
2022-01-03  9:55 ` [PR PATCH] [Updated] " BenJarg
2022-01-03 10:04 ` BenJarg
2022-01-03 10:06 ` BenJarg
2022-01-03 11:03 ` balejk
2022-01-03 11:04 ` balejk
2022-01-05  2:53 ` [PR PATCH] [Updated] " BenJarg
2022-01-05  3:00 ` BenJarg
2022-01-05 14:37 ` balejk
2022-01-05 20:50 ` [PR PATCH] [Updated] " BenJarg
2022-01-05 20:57 ` BenJarg
2022-01-06 23:35 ` BenJarg
2022-01-07 22:06 ` [PR PATCH] [Updated] " BenJarg
2022-01-07 22:09 ` BenJarg
2022-01-10 18:29 ` Chocimier
2022-01-10 21:10 ` balejk
2022-01-11 23:25 ` [PR PATCH] [Updated] " BenJarg
2022-01-11 23:38 ` BenJarg
2022-01-11 23:39 ` BenJarg
2022-01-11 23:39 ` BenJarg
2022-01-11 23:39 ` BenJarg
2022-01-12  8:35 ` balejk
2022-01-13  2:48 ` [PR PATCH] [Updated] " BenJarg
2022-01-13  2:53 ` BenJarg
2022-01-13  5:00 ` [PR PATCH] [Updated] " BenJarg
2022-01-13  5:06 ` BenJarg
2022-01-13  5:10 ` [PR PATCH] [Updated] " BenJarg
2022-01-13  6:09 ` BenJarg
2022-01-17  7:32 ` BenJarg
2022-01-17  7:33 ` BenJarg
2022-01-18  0:13 ` [PR PATCH] [Updated] " BenJarg
2022-01-18  0:14 ` BenJarg
2022-01-18  1:38 ` [PR PATCH] [Updated] " BenJarg
2022-01-20 20:40 ` Chocimier
2022-01-21  3:47 ` [PR PATCH] [Updated] " BenJarg
2022-01-21  4:09 ` BenJarg
2022-01-28 18:31 ` [PR REVIEW] " Chocimier
2022-01-28 18:31 ` Chocimier
2022-01-28 18:31 ` Chocimier
2022-01-28 18:31 ` Chocimier
2022-01-28 18:31 ` Chocimier
2022-01-28 20:06 ` BenJarg
2022-01-28 20:33 ` [PR PATCH] [Updated] " BenJarg
2022-01-28 20:45 ` [PR REVIEW] " BenJarg
2022-01-28 21:30 ` [PR PATCH] [Updated] " BenJarg
2022-01-28 21:32 ` [PR REVIEW] " BenJarg
2022-01-28 21:38 ` Chocimier
2022-01-28 22:12 ` [PR PATCH] [Updated] " BenJarg
2022-01-28 22:51 ` [PR REVIEW] " BenJarg
2022-01-29  0:22 ` BenJarg
2022-01-29 18:52 ` Chocimier
2022-01-29 21:29 ` [PR PATCH] [Updated] " BenJarg
2022-01-29 21:30 ` [PR REVIEW] " BenJarg
2022-02-23 19:45 ` [PR PATCH] [Updated] " BenJarg
2022-02-24  5:57 ` BenJarg
2022-02-24  6:04 ` [PR REVIEW] " BenJarg
2022-03-01 18:43 ` Chocimier
2022-03-01 23:44 ` [PR PATCH] [Updated] " BenJarg
2022-03-01 23:58 ` [PR REVIEW] " BenJarg
2022-03-02 21:19 ` BenJarg
2022-03-10 21:14 ` [PR PATCH] [Updated] " BenJarg
2022-03-10 21:15 ` BenJarg
2022-03-10 21:20 ` BenJarg
2022-03-15 20:41 ` Chocimier
2022-03-17  5:24 ` [PR PATCH] [Updated] " BenJarg
2022-03-17  5:27 ` BenJarg
2022-04-04  5:38 ` [PR PATCH] [Updated] " BenJarg
2022-04-06  2:18 ` BenJarg
2022-04-20  2:24 ` BenJarg
2022-04-20 16:20 ` [PR REVIEW] " Chocimier
2022-04-20 16:20 ` Chocimier
2022-04-20 16:20 ` Chocimier
2022-04-20 16:20 ` Chocimier
2022-04-20 17:24 ` BenJarg
2022-04-20 17:25 ` [PR PATCH] [Updated] " BenJarg
2022-04-20 18:46 ` BenJarg
2022-04-20 19:05 ` [PR REVIEW] " BenJarg
2022-04-21 16:19 ` Chocimier
2022-04-21 19:49 ` [PR PATCH] [Updated] " BenJarg
2022-04-21 19:51 ` BenJarg
2022-05-05 21:43 ` [PR PATCH] [Updated] " BenJarg
2022-05-07 17:39 ` [PR PATCH] [Merged]: " Chocimier
2022-06-04 11:14 ` q66
2022-06-04 14:26 ` BenJarg
2022-06-04 14:31 ` Chocimier
2022-06-04 15:38 ` q66

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220102212453.D0q4wXR5n1blDc78tJmUD5OOSIoxTlGSnCSbWw4vsHQ@z \
    --to=balejk@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).