Re: [PR PATCH] [Updated] mesa: add Broadcom vulkan driver

[sug0 <sug0@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]

There is an updated pull request by sug0 against master on the void-packages repository

https://github.com/sug0/void-packages mesa-vulkan-rpi
https://github.com/void-linux/void-packages/pull/34778

mesa: add Broadcom vulkan driver
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, aarch64

---

I created a new subpackage to build vulkan drivers for the Raspberry Pi 4. They seem to be working correctly, given the output of `vulkaninfo` from `Vulkan-Tools`, but I haven't actually tested any graphical workload, since `vkcube` is missing from `Vulkan-Tools` in `aarch64`.

P.S. -- I removed the update to 21.3.3 to keep this PR more feature isolated.

A patch file from https://github.com/void-linux/void-packages/pull/34778.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mesa-vulkan-rpi-34778.patch --]
[-- Type: text/x-diff, Size: 1596 bytes --]

From 1417beec6b0aa16ea0f2311aeb33eb44812b26be Mon Sep 17 00:00:00 2001
From: Tiago Carvalho <sugoiuguu@tfwno.gf>
Date: Sun, 2 Jan 2022 01:43:58 +0000
Subject: [PATCH] mesa: build broadcom vulkan drivers

---
 srcpkgs/mesa-vulkan-broadcom |  1 +
 srcpkgs/mesa/template        | 10 ++++++++++
 2 files changed, 11 insertions(+)
 create mode 120000 srcpkgs/mesa-vulkan-broadcom

diff --git a/srcpkgs/mesa-vulkan-broadcom b/srcpkgs/mesa-vulkan-broadcom
new file mode 120000
index 000000000000..1ad1bbec7ab3
--- /dev/null
+++ b/srcpkgs/mesa-vulkan-broadcom
@@ -0,0 +1 @@
+mesa
\ No newline at end of file
diff --git a/srcpkgs/mesa/template b/srcpkgs/mesa/template
index 42bc12fbf877..c99c2a57b3a4 100644
--- a/srcpkgs/mesa/template
+++ b/srcpkgs/mesa/template
@@ -115,10 +115,12 @@ fi
 if [ "$_have_arm" ]; then
 	_gallium_drivers+=",kmsro"
 	_gallium_drivers+=",v3d,vc4,freedreno,etnaviv,lima,panfrost"
+	_vulkan_drivers+=",broadcom"
 	# transitional dummy packages
 	subpackages+=" mesa-kmsro-dri mesa-v3d-dri mesa-vc4-dri"
 	subpackages+=" mesa-etnaviv-dri mesa-freedreno-dri"
 	subpackages+=" mesa-lima-dri mesa-panfrost-dri"
+	subpackages+=" mesa-vulkan-broadcom"
 fi
 
 if [ "$_have_virgl" ]; then
@@ -354,6 +356,14 @@ mesa-vulkan-radeon_package() {
 	}
 }
 
+mesa-vulkan-broadcom_package() {
+	short_desc="Mesa Broadcom Vulkan driver"
+	pkg_install() {
+		vmove "usr/share/vulkan/icd.d/broadcom_icd*.json"
+		vmove "usr/lib/libvulkan_broadcom.so"
+	}
+}
+
 mesa-vulkan-overlay-layer_package() {
 	short_desc="Vulkan layer to display information about the running application"
 	pkg_install() {