From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] libmtp: update to 1.1.19.
Date: Wed, 05 Jan 2022 02:15:21 +0100 [thread overview]
Message-ID: <20220105011521.q_kfPRetNA_4tU8F5Q7KryMx_J5H8Yt4YW4xptADteA@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34757@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1842 bytes --]
New review comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/34757#discussion_r778486761
Comment:
The default is "none" which means there's no group. The only change with this seems to be in the file `/usr/lib/udev/rules.d/69-libmtp.rules`:
```diff
--- 69-libmtp.rules.old 2020-11-05 23:30:09.000000000 -0300
+++ 69-libmtp.rules.new 2021-12-29 18:26:43.895937081 -0300
@@ -9,7 +9,7 @@
LABEL="libmtp_usb_rules"
# If we have a hwdb entry for this device, act immediately!
-ENV{ID_MTP_DEVICE}=="1", SYMLINK+="libmtp-%k", GOTO="libmtp_rules_end"
+ENV{ID_MTP_DEVICE}=="1", SYMLINK+="libmtp-%k", GROUP="_libmtp", GOTO="libmtp_rules_end"
# Fall back to probing.
# Some sensitive devices we surely don't wanna probe
@@ -36,6 +36,6 @@
ENV{ID_USB_INTERFACES}=="*:0701??:*", GOTO="libmtp_rules_end"
# Autoprobe vendor-specific, communication and PTP devices
-ENV{ID_MTP_DEVICE}!="1", ENV{MTP_NO_PROBE}!="1", ENV{COLOR_MEASUREMENT_DEVICE}!="1", ENV{ID_GPHOTO}!="1", ENV{libsane_matched}!="yes", ATTR{bDeviceClass}=="00|02|06|ef|ff", PROGRAM="/usr/lib/udev/mtp-probe /sys$env{DEVPATH} $attr{busnum} $attr{devnum}", RESULT=="1", SYMLINK+="libmtp-%k", ENV{ID_MTP_DEVICE}="1", ENV{ID_MEDIA_PLAYER}="1"
+ENV{ID_MTP_DEVICE}!="1", ENV{MTP_NO_PROBE}!="1", ENV{COLOR_MEASUREMENT_DEVICE}!="1", ENV{ID_GPHOTO}!="1", ENV{libsane_matched}!="yes", ATTR{bDeviceClass}=="00|02|06|ef|ff", PROGRAM="/usr/lib/udev/mtp-probe /sys$env{DEVPATH} $attr{busnum} $attr{devnum}", RESULT=="1", SYMLINK+="libmtp-%k", ENV{ID_MTP_DEVICE}="1", ENV{ID_MEDIA_PLAYER}="1", GROUP="_libmtp"
LABEL="libmtp_rules_end"
```
The net effect is that the device node that is created in `/dev/bus/usb/...` has its group set to `_libmtp`. These files are created with mode 664 in any case, but with group `root`.
next prev parent reply other threads:[~2022-01-05 1:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 21:42 [PR PATCH] " tornaria
2022-01-04 8:01 ` [PR REVIEW] " ericonr
2022-01-05 1:15 ` tornaria [this message]
2022-01-20 13:21 ` tornaria
2022-02-25 21:55 ` Piraty
2022-02-25 21:57 ` Piraty
2022-02-25 22:03 ` tornaria
2022-02-25 22:15 ` tornaria
2022-02-25 23:08 ` Piraty
2022-02-26 0:32 ` Piraty
2022-02-26 13:35 ` tornaria
2022-02-26 21:58 ` Piraty
2022-02-27 17:38 ` tornaria
2022-03-19 23:07 ` [PR PATCH] [Updated] " tornaria
2022-03-19 23:10 ` [PR REVIEW] " tornaria
2022-03-19 23:12 ` tornaria
2022-04-06 22:53 ` 0x5c
2022-04-10 20:42 ` libmtp: update to 1.1.19, use plugdev group for r/w access to mtp devices tornaria
2022-04-10 23:39 ` [PR PATCH] [Merged]: " q66
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220105011521.q_kfPRetNA_4tU8F5Q7KryMx_J5H8Yt4YW4xptADteA@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).