* [PR PATCH] gettext: fix cross compile
@ 2022-01-05 13:54 lfdebrux
2022-01-05 15:14 ` [PR PATCH] [Updated] " lfdebrux
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: lfdebrux @ 2022-01-05 13:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
There is a new pull request by lfdebrux against master on the void-packages repository
https://github.com/lfdebrux/void-packages fix-gettext-cross
https://github.com/void-linux/void-packages/pull/34866
gettext: fix cross compile
For gettext-0.21 cross-compile does not work, because the pre-configure step tries to run `autoreconf -fi`, which fails with the error
configure.ac:25: error: AC_INIT should be called with package and version arguments
: gl_AM_INIT_AUTOMAKE is expanded from...
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:25: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: aclocal failed with exit status: 1
This pre-configure step was added back in commit 17f6ad8b for gettext-0.18.3, but its not clear what the error seen back then was, and now cross-compiling without running autoreconf works fine.
So this commit just removes the pre-configure step, reverting 17f6ad8b. This PR fixes #34810.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures:
- aarch64-musl
- armv5tel-musl
- i686-musl
A patch file from https://github.com/void-linux/void-packages/pull/34866.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-gettext-cross-34866.patch --]
[-- Type: text/x-diff, Size: 1831 bytes --]
From 2d4c6cfabc69ae23ab3a7892144f400fa67b7713 Mon Sep 17 00:00:00 2001
From: Laurence de Bruxelles <lfdebrux@gmail.com>
Date: Fri, 31 Dec 2021 16:38:48 +0000
Subject: [PATCH] gettext: fix cross compile
For gettext-0.21 cross-compile does not work, because the
pre-configure step tries to run `autoreconf -fi`, which fails with the
error
configure.ac:25: error: AC_INIT should be called with package and version arguments
: gl_AM_INIT_AUTOMAKE is expanded from...
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:25: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: aclocal failed with exit status: 1
This pre-configure step was added back in commit 17f6ad8b for
gettext-0.18.3, but its not clear what the error seen back then was, and
now cross-compiling without running autoreconf works fine.
So this commit just removes the pre-configure step, reverting 17f6ad8b.
---
srcpkgs/gettext/template | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/srcpkgs/gettext/template b/srcpkgs/gettext/template
index dfb11a1f886c..85fc90e8cb14 100644
--- a/srcpkgs/gettext/template
+++ b/srcpkgs/gettext/template
@@ -1,7 +1,7 @@
# Template file for 'gettext'
pkgname=gettext
version=0.21
-revision=4
+revision=5
build_style=gnu-configure
configure_args="--disable-java --disable-native-java --disable-csharp
--disable-libasprintf --enable-threads=posix --disable-rpath --without-emacs
@@ -36,13 +36,6 @@ else
conflicts="gettext-libs>=0"
fi
-if [ "$CROSS_BUILD" ]; then
- hostmakedepends+=" automake libtool"
- pre_configure() {
- autoreconf -fi
- }
-fi
-
post_install() {
# don't overwrite musl's header
if [ "$XBPS_TARGET_LIBC" = musl ]; then
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] gettext: fix cross compile
2022-01-05 13:54 [PR PATCH] gettext: fix cross compile lfdebrux
@ 2022-01-05 15:14 ` lfdebrux
2022-01-05 20:41 ` Chocimier
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: lfdebrux @ 2022-01-05 15:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]
There is an updated pull request by lfdebrux against master on the void-packages repository
https://github.com/lfdebrux/void-packages fix-gettext-cross
https://github.com/void-linux/void-packages/pull/34866
gettext: fix cross compile
For gettext-0.21 cross-compile does not work, because the pre-configure step tries to run `autoreconf -fi`, which fails with the error
configure.ac:25: error: AC_INIT should be called with package and version arguments
: gl_AM_INIT_AUTOMAKE is expanded from...
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:25: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: aclocal failed with exit status: 1
This pre-configure step was added back in commit 17f6ad8b for gettext-0.18.3, but its not clear what the error seen back then was, and now cross-compiling without running autoreconf works fine.
So this PR just removes the pre-configure step, reverting 17f6ad8b. This fixes #34810.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures:
- aarch64-musl
- armv5tel-musl
- i686-musl
A patch file from https://github.com/void-linux/void-packages/pull/34866.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-gettext-cross-34866.patch --]
[-- Type: text/x-diff, Size: 1839 bytes --]
From 9cce4e5150a0e8e85f79bae18ab8496a99ab7e50 Mon Sep 17 00:00:00 2001
From: Laurence de Bruxelles <lfdebrux@gmail.com>
Date: Fri, 31 Dec 2021 16:38:48 +0000
Subject: [PATCH] gettext: fix cross compile
For gettext-0.21 cross-compile does not work, because the
pre-configure step tries to run `autoreconf -fi`, which fails with the
error
configure.ac:25: error: AC_INIT should be called with package
and version arguments
: gl_AM_INIT_AUTOMAKE is expanded from...
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:25: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: aclocal failed with exit status: 1
This pre-configure step was added back in commit 17f6ad8b for
gettext-0.18.3, but its not clear what the error seen back then was, and
now cross-compiling without running autoreconf works fine.
So this commit just removes the pre-configure step, reverting 17f6ad8b.
---
srcpkgs/gettext/template | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/srcpkgs/gettext/template b/srcpkgs/gettext/template
index dfb11a1f886c..85fc90e8cb14 100644
--- a/srcpkgs/gettext/template
+++ b/srcpkgs/gettext/template
@@ -1,7 +1,7 @@
# Template file for 'gettext'
pkgname=gettext
version=0.21
-revision=4
+revision=5
build_style=gnu-configure
configure_args="--disable-java --disable-native-java --disable-csharp
--disable-libasprintf --enable-threads=posix --disable-rpath --without-emacs
@@ -36,13 +36,6 @@ else
conflicts="gettext-libs>=0"
fi
-if [ "$CROSS_BUILD" ]; then
- hostmakedepends+=" automake libtool"
- pre_configure() {
- autoreconf -fi
- }
-fi
-
post_install() {
# don't overwrite musl's header
if [ "$XBPS_TARGET_LIBC" = musl ]; then
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gettext: fix cross compile
2022-01-05 13:54 [PR PATCH] gettext: fix cross compile lfdebrux
2022-01-05 15:14 ` [PR PATCH] [Updated] " lfdebrux
@ 2022-01-05 20:41 ` Chocimier
2022-01-06 9:15 ` lfdebrux
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Chocimier @ 2022-01-05 20:41 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
New comment by Chocimier on void-packages repository
https://github.com/void-linux/void-packages/pull/34866#issuecomment-1006062038
Comment:
Alternatively, apply https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=patch;h=d1836dbbd6a90b4c0ab79bc5292c023f08b49511
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gettext: fix cross compile
2022-01-05 13:54 [PR PATCH] gettext: fix cross compile lfdebrux
2022-01-05 15:14 ` [PR PATCH] [Updated] " lfdebrux
2022-01-05 20:41 ` Chocimier
@ 2022-01-06 9:15 ` lfdebrux
2022-04-12 2:05 ` github-actions
2022-04-17 17:34 ` [PR PATCH] [Closed]: " paper42
4 siblings, 0 replies; 6+ messages in thread
From: lfdebrux @ 2022-01-06 9:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 401 bytes --]
New comment by lfdebrux on void-packages repository
https://github.com/void-linux/void-packages/pull/34866#issuecomment-1006400843
Comment:
> Alternatively, apply https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=patch;h=d1836dbbd6a90b4c0ab79bc5292c023f08b49511
Oh, that's interesting, nice find!
Forgive my ignorance, but what's the advantage of running autoreconf before cross-compiling?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: gettext: fix cross compile
2022-01-05 13:54 [PR PATCH] gettext: fix cross compile lfdebrux
` (2 preceding siblings ...)
2022-01-06 9:15 ` lfdebrux
@ 2022-04-12 2:05 ` github-actions
2022-04-17 17:34 ` [PR PATCH] [Closed]: " paper42
4 siblings, 0 replies; 6+ messages in thread
From: github-actions @ 2022-04-12 2:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/34866#issuecomment-1095826389
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Closed]: gettext: fix cross compile
2022-01-05 13:54 [PR PATCH] gettext: fix cross compile lfdebrux
` (3 preceding siblings ...)
2022-04-12 2:05 ` github-actions
@ 2022-04-17 17:34 ` paper42
4 siblings, 0 replies; 6+ messages in thread
From: paper42 @ 2022-04-17 17:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1364 bytes --]
There's a closed pull request on the void-packages repository
gettext: fix cross compile
https://github.com/void-linux/void-packages/pull/34866
Description:
For gettext-0.21 cross-compile does not work, because the pre-configure step tries to run `autoreconf -fi`, which fails with the error
configure.ac:25: error: AC_INIT should be called with package and version arguments
: gl_AM_INIT_AUTOMAKE is expanded from...
/usr/share/aclocal-1.16/init.m4:29: AM_INIT_AUTOMAKE is expanded from...
configure.ac:25: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: /usr/bin/autom4te failed with exit status: 1
autoreconf: aclocal failed with exit status: 1
This pre-configure step was added back in commit 17f6ad8b for gettext-0.18.3, but its not clear what the error seen back then was, and now cross-compiling without running autoreconf works fine.
So this PR just removes the pre-configure step, reverting 17f6ad8b. This fixes #34810.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
- I built this PR locally for these architectures:
- aarch64-musl
- armv5tel-musl
- i686-musl
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-17 17:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 13:54 [PR PATCH] gettext: fix cross compile lfdebrux
2022-01-05 15:14 ` [PR PATCH] [Updated] " lfdebrux
2022-01-05 20:41 ` Chocimier
2022-01-06 9:15 ` lfdebrux
2022-04-12 2:05 ` github-actions
2022-04-17 17:34 ` [PR PATCH] [Closed]: " paper42
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).