* Re: gtk+3: update to 3.24.31.
2022-01-07 13:24 [PR PATCH] gtk+3: update to 3.24.31 JamiKettunen
@ 2022-01-07 14:09 ` JamiKettunen
2022-01-07 15:25 ` paper42
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: JamiKettunen @ 2022-01-07 14:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 233 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/34921#issuecomment-1007434566
Comment:
Interesting test failures, should we start addressing them with this PR as well or no?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: gtk+3: update to 3.24.31.
2022-01-07 13:24 [PR PATCH] gtk+3: update to 3.24.31 JamiKettunen
2022-01-07 14:09 ` JamiKettunen
@ 2022-01-07 15:25 ` paper42
2022-01-07 16:34 ` [PR PATCH] [Updated] " JamiKettunen
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-01-07 15:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 453 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/34921#issuecomment-1007493966
Comment:
> Interesting test failures, should we start addressing them with this PR as well or no?
It would be nice to fix them, yes. The `assertion 'font != NULL'` test fail usually means no fonts are installed during the check phase, adding `cantarell-fonts` (because they are small) to checkdepends should fix this.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] gtk+3: update to 3.24.31.
2022-01-07 13:24 [PR PATCH] gtk+3: update to 3.24.31 JamiKettunen
2022-01-07 14:09 ` JamiKettunen
2022-01-07 15:25 ` paper42
@ 2022-01-07 16:34 ` JamiKettunen
2022-01-07 17:27 ` JamiKettunen
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: JamiKettunen @ 2022-01-07 16:34 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
There is an updated pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages gtk+3-update
https://github.com/void-linux/void-packages/pull/34921
gtk+3: update to 3.24.31.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34921.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gtk+3-update-34921.patch --]
[-- Type: text/x-diff, Size: 1365 bytes --]
From b89890816d86d1b3f32d29fb9314d4c897996071 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Fri, 7 Jan 2022 15:17:56 +0200
Subject: [PATCH] gtk+3: update to 3.24.31.
---
srcpkgs/gtk+3/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gtk+3/template b/srcpkgs/gtk+3/template
index c6660b618f10..0b3dc8bd6575 100644
--- a/srcpkgs/gtk+3/template
+++ b/srcpkgs/gtk+3/template
@@ -1,6 +1,6 @@
# Template file for 'gtk+3'
pkgname=gtk+3
-version=3.24.30
+version=3.24.31
revision=1
wrksrc="gtk+-${version}"
build_style=meson
@@ -26,13 +26,13 @@ makedepends="at-spi2-atk-devel gdk-pixbuf-devel libepoxy-devel pango-devel
$(vopt_if cloudproviders 'libcloudproviders-devel')"
depends="gtk-update-icon-cache adwaita-icon-theme
librsvg shared-mime-info $(vopt_if x11 'dbus-x11')"
-checkdepends="$depends xvfb-run dbus"
+checkdepends="$depends xvfb-run dbus cantarell-fonts"
short_desc="GTK+ toolkit (v3)"
maintainer="Enno Boland <gottox@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://www.gtk.org/"
distfiles="${GNOME_SITE}/gtk+/${version%.*}/gtk+-${version}.tar.xz"
-checksum=ba75bfff320ad1f4cfbee92ba813ec336322cc3c660d406aad014b07087a3ba9
+checksum=423c3e7fdb4c459ee889e35fd4d71fd2623562541c1041b11c07e5ad1ff10bf9
_broken_tests="
a11y/scale-drawvalue
a11y/menu
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] gtk+3: update to 3.24.31.
2022-01-07 13:24 [PR PATCH] gtk+3: update to 3.24.31 JamiKettunen
` (2 preceding siblings ...)
2022-01-07 16:34 ` [PR PATCH] [Updated] " JamiKettunen
@ 2022-01-07 17:27 ` JamiKettunen
2022-01-07 18:23 ` JamiKettunen
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: JamiKettunen @ 2022-01-07 17:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
There is an updated pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages gtk+3-update
https://github.com/void-linux/void-packages/pull/34921
gtk+3: update to 3.24.31.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34921.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gtk+3-update-34921.patch --]
[-- Type: text/x-diff, Size: 2258 bytes --]
From 639a1981f65cbb010a4e0cff06e6db421acfbc5d Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Fri, 7 Jan 2022 15:17:56 +0200
Subject: [PATCH] gtk+3: update to 3.24.31.
Additionally includes the following fixes to unit tests:
1. Adding cantarell-fonts to checkdepends fixed over 100 tests
2. Some reftests were broken by upstream by removing the .ui files[1]
3. UNEXPECTEDPASS of quit-mnemonic.ui is a known "somehow broken" test[2]
[1] https://gitlab.gnome.org/GNOME/gtk/-/commit/93e1f7f1
[2] https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.31/testsuite/reftests/meson.build#L430
---
srcpkgs/gtk+3/template | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/gtk+3/template b/srcpkgs/gtk+3/template
index c6660b618f10..c60602f9ee83 100644
--- a/srcpkgs/gtk+3/template
+++ b/srcpkgs/gtk+3/template
@@ -1,6 +1,6 @@
# Template file for 'gtk+3'
pkgname=gtk+3
-version=3.24.30
+version=3.24.31
revision=1
wrksrc="gtk+-${version}"
build_style=meson
@@ -26,13 +26,13 @@ makedepends="at-spi2-atk-devel gdk-pixbuf-devel libepoxy-devel pango-devel
$(vopt_if cloudproviders 'libcloudproviders-devel')"
depends="gtk-update-icon-cache adwaita-icon-theme
librsvg shared-mime-info $(vopt_if x11 'dbus-x11')"
-checkdepends="$depends xvfb-run dbus"
+checkdepends="$depends xvfb-run dbus cantarell-fonts"
short_desc="GTK+ toolkit (v3)"
maintainer="Enno Boland <gottox@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://www.gtk.org/"
distfiles="${GNOME_SITE}/gtk+/${version%.*}/gtk+-${version}.tar.xz"
-checksum=ba75bfff320ad1f4cfbee92ba813ec336322cc3c660d406aad014b07087a3ba9
+checksum=423c3e7fdb4c459ee889e35fd4d71fd2623562541c1041b11c07e5ad1ff10bf9
_broken_tests="
a11y/scale-drawvalue
a11y/menu
@@ -44,7 +44,12 @@ _broken_tests="
reftests/cellrenderer-pixbuf-stock-rtl.ui
reftests/icon-effect-missing.ui
reftests/symbolic-icon-translucent-color.ui
- reftests/window-height-for-width.ui"
+ reftests/window-height-for-width.ui
+ reftests/label-text-shadow-changes-modify-clip.ui
+ reftests/toplevel-vs-popup.ui
+ reftests/treeview-crash-too-wide.ui
+ reftests/quit-mnemonic.ui
+"
case "$XBPS_TARGET_MACHINE" in
i686*) _broken_tests+=" gtk/cellarea" ;;
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] gtk+3: update to 3.24.31.
2022-01-07 13:24 [PR PATCH] gtk+3: update to 3.24.31 JamiKettunen
` (3 preceding siblings ...)
2022-01-07 17:27 ` JamiKettunen
@ 2022-01-07 18:23 ` JamiKettunen
2022-01-07 18:24 ` JamiKettunen
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: JamiKettunen @ 2022-01-07 18:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
There is an updated pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages gtk+3-update
https://github.com/void-linux/void-packages/pull/34921
gtk+3: update to 3.24.31.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34921.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gtk+3-update-34921.patch --]
[-- Type: text/x-diff, Size: 2410 bytes --]
From 255cc7228dd8cf34dc3d784ba7905828d1307914 Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Fri, 7 Jan 2022 15:17:56 +0200
Subject: [PATCH] gtk+3: update to 3.24.31.
Additionally includes the following fixes to unit tests:
1. Adding cantarell-fonts to checkdepends fixed over 100 tests
2. Some reftests were broken by upstream by removing the .ui files[1]
3. UNEXPECTEDPASS of quit-mnemonic.ui is a known "somehow broken" test[2]
4. Fix reftests/icon-effect-missing.ui by adding hicolor-icon-theme to checkdepends
[1] https://gitlab.gnome.org/GNOME/gtk/-/commit/93e1f7f1
[2] https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.31/testsuite/reftests/meson.build#L430
---
srcpkgs/gtk+3/template | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gtk+3/template b/srcpkgs/gtk+3/template
index c6660b618f10..8f3092774739 100644
--- a/srcpkgs/gtk+3/template
+++ b/srcpkgs/gtk+3/template
@@ -1,6 +1,6 @@
# Template file for 'gtk+3'
pkgname=gtk+3
-version=3.24.30
+version=3.24.31
revision=1
wrksrc="gtk+-${version}"
build_style=meson
@@ -26,13 +26,13 @@ makedepends="at-spi2-atk-devel gdk-pixbuf-devel libepoxy-devel pango-devel
$(vopt_if cloudproviders 'libcloudproviders-devel')"
depends="gtk-update-icon-cache adwaita-icon-theme
librsvg shared-mime-info $(vopt_if x11 'dbus-x11')"
-checkdepends="$depends xvfb-run dbus"
+checkdepends="$depends xvfb-run dbus cantarell-fonts hicolor-icon-theme"
short_desc="GTK+ toolkit (v3)"
maintainer="Enno Boland <gottox@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://www.gtk.org/"
distfiles="${GNOME_SITE}/gtk+/${version%.*}/gtk+-${version}.tar.xz"
-checksum=ba75bfff320ad1f4cfbee92ba813ec336322cc3c660d406aad014b07087a3ba9
+checksum=423c3e7fdb4c459ee889e35fd4d71fd2623562541c1041b11c07e5ad1ff10bf9
_broken_tests="
a11y/scale-drawvalue
a11y/menu
@@ -42,9 +42,13 @@ _broken_tests="
a11y/tooltips
reftests/button-wrapping.ui
reftests/cellrenderer-pixbuf-stock-rtl.ui
- reftests/icon-effect-missing.ui
reftests/symbolic-icon-translucent-color.ui
- reftests/window-height-for-width.ui"
+ reftests/window-height-for-width.ui
+ reftests/label-text-shadow-changes-modify-clip.ui
+ reftests/toplevel-vs-popup.ui
+ reftests/treeview-crash-too-wide.ui
+ reftests/quit-mnemonic.ui
+"
case "$XBPS_TARGET_MACHINE" in
i686*) _broken_tests+=" gtk/cellarea" ;;
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: gtk+3: update to 3.24.31.
2022-01-07 13:24 [PR PATCH] gtk+3: update to 3.24.31 JamiKettunen
` (4 preceding siblings ...)
2022-01-07 18:23 ` JamiKettunen
@ 2022-01-07 18:24 ` JamiKettunen
2022-01-07 18:32 ` [PR PATCH] [Updated] " JamiKettunen
2022-01-07 19:09 ` [PR PATCH] [Merged]: " paper42
7 siblings, 0 replies; 9+ messages in thread
From: JamiKettunen @ 2022-01-07 18:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 299 bytes --]
New comment by JamiKettunen on void-packages repository
https://github.com/void-linux/void-packages/pull/34921#issuecomment-1007633630
Comment:
Managed to fix `reftests/icon-effect-missing.ui` test by just including `hicolor-icon-theme`, the others I have no clue about; this PR is ready now imho
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Updated] gtk+3: update to 3.24.31.
2022-01-07 13:24 [PR PATCH] gtk+3: update to 3.24.31 JamiKettunen
` (5 preceding siblings ...)
2022-01-07 18:24 ` JamiKettunen
@ 2022-01-07 18:32 ` JamiKettunen
2022-01-07 19:09 ` [PR PATCH] [Merged]: " paper42
7 siblings, 0 replies; 9+ messages in thread
From: JamiKettunen @ 2022-01-07 18:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1230 bytes --]
There is an updated pull request by JamiKettunen against master on the void-packages repository
https://github.com/JamiKettunen/void-packages gtk+3-update
https://github.com/void-linux/void-packages/pull/34921
gtk+3: update to 3.24.31.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
A patch file from https://github.com/void-linux/void-packages/pull/34921.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gtk+3-update-34921.patch --]
[-- Type: text/x-diff, Size: 2415 bytes --]
From f57e5b128e83229064bcb6e80e5716f34d29c12f Mon Sep 17 00:00:00 2001
From: Jami Kettunen <jami.kettunen@protonmail.com>
Date: Fri, 7 Jan 2022 15:17:56 +0200
Subject: [PATCH] gtk+3: update to 3.24.31.
Additionally includes the following fixes to unit tests:
1. Adding cantarell-fonts to checkdepends fixed over 100 tests
2. Some reftests were broken by upstream by removing the .ui files[1]
3. UNEXPECTEDPASS of quit-mnemonic.ui is a known "somehow broken" test[2]
4. Fix reftests/icon-effect-missing.ui by adding hicolor-icon-theme to
checkdepends
[1] https://gitlab.gnome.org/GNOME/gtk/-/commit/93e1f7f1
[2] https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.31/testsuite/reftests/meson.build#L430
---
srcpkgs/gtk+3/template | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/gtk+3/template b/srcpkgs/gtk+3/template
index c6660b618f10..8f3092774739 100644
--- a/srcpkgs/gtk+3/template
+++ b/srcpkgs/gtk+3/template
@@ -1,6 +1,6 @@
# Template file for 'gtk+3'
pkgname=gtk+3
-version=3.24.30
+version=3.24.31
revision=1
wrksrc="gtk+-${version}"
build_style=meson
@@ -26,13 +26,13 @@ makedepends="at-spi2-atk-devel gdk-pixbuf-devel libepoxy-devel pango-devel
$(vopt_if cloudproviders 'libcloudproviders-devel')"
depends="gtk-update-icon-cache adwaita-icon-theme
librsvg shared-mime-info $(vopt_if x11 'dbus-x11')"
-checkdepends="$depends xvfb-run dbus"
+checkdepends="$depends xvfb-run dbus cantarell-fonts hicolor-icon-theme"
short_desc="GTK+ toolkit (v3)"
maintainer="Enno Boland <gottox@voidlinux.org>"
license="LGPL-2.1-or-later"
homepage="https://www.gtk.org/"
distfiles="${GNOME_SITE}/gtk+/${version%.*}/gtk+-${version}.tar.xz"
-checksum=ba75bfff320ad1f4cfbee92ba813ec336322cc3c660d406aad014b07087a3ba9
+checksum=423c3e7fdb4c459ee889e35fd4d71fd2623562541c1041b11c07e5ad1ff10bf9
_broken_tests="
a11y/scale-drawvalue
a11y/menu
@@ -42,9 +42,13 @@ _broken_tests="
a11y/tooltips
reftests/button-wrapping.ui
reftests/cellrenderer-pixbuf-stock-rtl.ui
- reftests/icon-effect-missing.ui
reftests/symbolic-icon-translucent-color.ui
- reftests/window-height-for-width.ui"
+ reftests/window-height-for-width.ui
+ reftests/label-text-shadow-changes-modify-clip.ui
+ reftests/toplevel-vs-popup.ui
+ reftests/treeview-crash-too-wide.ui
+ reftests/quit-mnemonic.ui
+"
case "$XBPS_TARGET_MACHINE" in
i686*) _broken_tests+=" gtk/cellarea" ;;
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PR PATCH] [Merged]: gtk+3: update to 3.24.31.
2022-01-07 13:24 [PR PATCH] gtk+3: update to 3.24.31 JamiKettunen
` (6 preceding siblings ...)
2022-01-07 18:32 ` [PR PATCH] [Updated] " JamiKettunen
@ 2022-01-07 19:09 ` paper42
7 siblings, 0 replies; 9+ messages in thread
From: paper42 @ 2022-01-07 19:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
There's a merged pull request on the void-packages repository
gtk+3: update to 3.24.31.
https://github.com/void-linux/void-packages/pull/34921
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
- aarch64-musl
- armv7l
- armv6l-musl
-->
^ permalink raw reply [flat|nested] 9+ messages in thread