Re: kicad: update to 6.0.0

[unspecd <unspecd@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 3795 bytes --]

New comment by unspecd on void-packages repository

https://github.com/void-linux/void-packages/pull/34917#issuecomment-1007652897

Comment:
1. It works for me (on x86_64-musl), but one test failed:
```
=> kicad-6.0.0_1: running do_check ...
[0/1] Running tests...
Test project /builddir/kicad-6.0.0/build
    Start 1: qa_python
1/8 Test #1: qa_python ........................   Passed   63.83 sec
    Start 2: qa_common
2/8 Test #2: qa_common ........................   Passed    2.34 sec
    Start 3: qa_gerbview
3/8 Test #3: qa_gerbview ......................   Passed   21.09 sec
    Start 4: qa_eeschema
4/8 Test #4: qa_eeschema ......................***Failed   15.42 sec
Running 62 test cases...
../qa/eeschema/test_ee_item.cpp(124): error: in "EeItem/Rotate": check aItem->GetBoundingBox().GetTop() == aOriginalItem->GetBoundingBox().GetTop() has failed [-529945 != -529188]
Failure occurred in a following context:
    Class: SCH_SHEET
    Position: -1000000 -500000, Reference: -1000000 -500000
../qa/eeschema/test_ee_item.cpp(128): error: in "EeItem/Rotate": check aItem->GetBoundingBox().GetBottom() == aOriginalItem->GetBoundingBox().GetBottom() has failed [-433225 != -433982]
Failure occurred in a following context:
    Class: SCH_SHEET
    Position: -1000000 -500000, Reference: -1000000 -500000
../qa/eeschema/test_ee_item.cpp(124): error: in "EeItem/Rotate": check aItem->GetBoundingBox().GetTop() == aOriginalItem->GetBoundingBox().GetTop() has failed [-529945 != -529188]
Failure occurred in a following context:
    Class: SCH_SHEET
    Position: -1000000 -500000, Reference: -1000000 0
../qa/eeschema/test_ee_item.cpp(128): error: in "EeItem/Rotate": check aItem->GetBoundingBox().GetBottom() == aOriginalItem->GetBoundingBox().GetBottom() has failed [-433225 != -433982]
Failure occurred in a following context:
    Class: SCH_SHEET
    Position: -1000000 -500000, Reference: -1000000 0

[etc...]

*** 162 failures are detected in the test module "Common Eeschema module tests"


    Start 5: qa_sexpr
5/8 Test #5: qa_sexpr .........................   Passed    0.13 sec
    Start 6: qa_kimath
6/8 Test #6: qa_kimath ........................   Passed    0.92 sec
    Start 7: qa_pcbnew
7/8 Test #7: qa_pcbnew ........................   Passed  125.88 sec
    Start 8: qa_kicad2step
8/8 Test #8: qa_kicad2step ....................   Passed    4.92 sec

88% tests passed, 1 tests failed out of 8

Total Test time (real) = 234.73 sec

The following tests FAILED:
	  4 - qa_eeschema (Failed)
Errors while running CTest
FAILED: CMakeFiles/test.util 
cd /builddir/kicad-6.0.0/build && /usr/bin/ctest --force-new-ctest-process
ninja: build stopped: subcommand failed.
```
2. You could remove unused configure_args:
   - KICAD_USE_OCE [[1](https://gitlab.com/kicad/code/kicad/-/commit/e57bde65821d7afcafeceb3b1a7f25e424d83121), [2](https://gitlab.com/kicad/code/kicad/-/commit/1c5c052301b607a0cf8b8ed6681f1db1622a865b)]
   - [KICAD_BUILD_VERSION](https://gitlab.com/kicad/code/kicad/-/commit/fd54d394bd12d2cb277fc289b6b4879f986c2416)
   - [BUILD_GITHUB_PLUGIN](https://gitlab.com/kicad/code/kicad/-/commit/9ed6cdd94391bf07b4d509b0b79f8873ec1ec4fd)
3. Not sure, but instead of deleting `disable-warnings.patch`, you could update it:
```diff
--- a/CMakeModules/Warnings.cmake
+++ b/CMakeModules/Warnings.cmake
@@ -38,13 +38,6 @@
     set( WARN_FLAGS_CXX "-Wall" )
 
 
-    # Warn about missing override specifiers
-    CHECK_CXX_COMPILER_FLAG( "-Wsuggest-override" COMPILER_SUPPORTS_WSUGGEST_OVERRIDE )
-
-    if( COMPILER_SUPPORTS_WSUGGEST_OVERRIDE )
-        set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wsuggest-override" )
-        message( STATUS "Enabling warning -Wsuggest-override" )
-    endif()
```