* [PR PATCH] haskell-language-server: update to 1.5.1.
@ 2022-01-08 17:05 motorto
2022-01-08 21:38 ` ericonr
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: motorto @ 2022-01-08 17:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
There is a new pull request by motorto against master on the void-packages repository
https://github.com/motorto/void-packages haskell-language-server
https://github.com/void-linux/void-packages/pull/34946
haskell-language-server: update to 1.5.1.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: yes
#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/34946.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-haskell-language-server-34946.patch --]
[-- Type: text/x-diff, Size: 1444 bytes --]
From d4100995ab336b4d9314107b84270fd4f7632224 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Cerqueira?= <acerqueira021@gmail.com>
Date: Sat, 8 Jan 2022 17:04:15 +0000
Subject: [PATCH] haskell-language-server: update to 1.5.1.
---
srcpkgs/haskell-language-server/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/haskell-language-server/template b/srcpkgs/haskell-language-server/template
index ff0782a54ddb..252bfc30467f 100644
--- a/srcpkgs/haskell-language-server/template
+++ b/srcpkgs/haskell-language-server/template
@@ -1,16 +1,16 @@
# Template file for 'haskell-language-server'
pkgname=haskell-language-server
-version=1.3.0
+version=1.5.1
revision=1
build_style="haskell-stack"
-make_build_args="--stack-yaml stack-8.10.4.yaml"
+make_build_args="--stack-yaml stack-8.10.7.yaml"
makedepends="ncurses-devel ncurses-libtinfo-devel icu-devel zlib-devel"
short_desc="Integration of ghcide and haskell-ide-engine"
maintainer="Wayne Van Son <waynevanson@gmail.com>"
license="Apache-2.0"
homepage="https://github.com/haskell/haskell-language-server"
distfiles="https://github.com/haskell/haskell-language-server/archive/${version}.tar.gz"
-checksum=9be31ead3fb1c0ca761de80185a23665dfe167457baaba642cf62885df98f6a1
+checksum=fa2b1d39d413283202ee1f75e4ad9fc44544535741370d6f1e63afd5878d9e40
nopie_files="
/usr/bin/haskell-language-server
/usr/bin/haskell-language-server-wrapper
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: haskell-language-server: update to 1.5.1.
2022-01-08 17:05 [PR PATCH] haskell-language-server: update to 1.5.1 motorto
@ 2022-01-08 21:38 ` ericonr
2022-01-08 23:01 ` motorto
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2022-01-08 21:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 339 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34946#issuecomment-1008158961
Comment:
> As we noted in the previous release we have dropped support for ghc versions 8.6.4, 8.10.2, 8.10.3, 8.10.4 in this release
Interesting that it still works for us, since that happened in 1.5.0.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: haskell-language-server: update to 1.5.1.
2022-01-08 17:05 [PR PATCH] haskell-language-server: update to 1.5.1 motorto
2022-01-08 21:38 ` ericonr
@ 2022-01-08 23:01 ` motorto
2022-01-08 23:12 ` ericonr
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: motorto @ 2022-01-08 23:01 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 275 bytes --]
New comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/34946#issuecomment-1008173022
Comment:
Hum ... Actually weird but it builds and I am currently using it actively for my project ... Wanna maybe wait for #33850, @ericonr ?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: haskell-language-server: update to 1.5.1.
2022-01-08 17:05 [PR PATCH] haskell-language-server: update to 1.5.1 motorto
2022-01-08 21:38 ` ericonr
2022-01-08 23:01 ` motorto
@ 2022-01-08 23:12 ` ericonr
2022-01-09 10:49 ` motorto
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: ericonr @ 2022-01-08 23:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 403 bytes --]
New comment by ericonr on void-packages repository
https://github.com/void-linux/void-packages/pull/34946#issuecomment-1008176208
Comment:
Yeah it might be okay to merge, I just don't know enough about Haskell to know what removing support for older GHC entails.
If it's just not guaranteeing support but not outright breaking stuff, it should be ok to merge. Do you know if you can find that out?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: haskell-language-server: update to 1.5.1.
2022-01-08 17:05 [PR PATCH] haskell-language-server: update to 1.5.1 motorto
` (2 preceding siblings ...)
2022-01-08 23:12 ` ericonr
@ 2022-01-09 10:49 ` motorto
2022-01-09 10:51 ` motorto
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: motorto @ 2022-01-09 10:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
New comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/34946#issuecomment-1008273685
Comment:
As I said I am currently using it on my school project, and everything
seems to work fine.
To be honest with you I am no Haskell expert to tell it certainty that it means no outright breaking stuff,I could ask on
hls GitHub and see their answer...
@slotThe whats your opinion ?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: haskell-language-server: update to 1.5.1.
2022-01-08 17:05 [PR PATCH] haskell-language-server: update to 1.5.1 motorto
` (3 preceding siblings ...)
2022-01-09 10:49 ` motorto
@ 2022-01-09 10:51 ` motorto
2022-01-09 12:52 ` slotThe
2022-02-20 22:24 ` [PR PATCH] [Closed]: " motorto
6 siblings, 0 replies; 8+ messages in thread
From: motorto @ 2022-01-09 10:51 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
New comment by motorto on void-packages repository
https://github.com/void-linux/void-packages/pull/34946#issuecomment-1008273685
Comment:
As I said I am currently using it on my school project, and everything
seems to work fine.
To be honest with you I am no Haskell expert to tell with certainty that it means no outright breaking stuff,I could ask on
hls GitHub and see their answer...
@slotThe whats your opinion ?
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: haskell-language-server: update to 1.5.1.
2022-01-08 17:05 [PR PATCH] haskell-language-server: update to 1.5.1 motorto
` (4 preceding siblings ...)
2022-01-09 10:51 ` motorto
@ 2022-01-09 12:52 ` slotThe
2022-02-20 22:24 ` [PR PATCH] [Closed]: " motorto
6 siblings, 0 replies; 8+ messages in thread
From: slotThe @ 2022-01-09 12:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
New comment by slotThe on void-packages repository
https://github.com/void-linux/void-packages/pull/34946#issuecomment-1008292090
Comment:
> @slotThe whats your opinion ?
"Dropping support" here basically means that i) stuff won't be tested against 8.10.4 anymore (which includes the updating to a stackage resolver for 8.10.7 in which things _might_ break with 8.10.4) and ii) depending on [some `8.10.7` compatible version](https://github.com/haskell/haskell-language-server/pull/2197/files#diff-7fec8325c6bd8bb86738dbe9638c6eb14d8f4eb7df78d8052a0244961648fb4a) of `ghc-lib` (basically, GHCs API since we want to parse and transform Haskell code).
Since the bumps from 8.10.4 -> 8.10.7 were mostly with regards to other platforms having some problems, this should be a case of "if it builds then it works", so we can merge this without too much trouble.
Though that reminds me that #33850 has essentially been "done" for quite a while—should get onto that again :)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PR PATCH] [Closed]: haskell-language-server: update to 1.5.1.
2022-01-08 17:05 [PR PATCH] haskell-language-server: update to 1.5.1 motorto
` (5 preceding siblings ...)
2022-01-09 12:52 ` slotThe
@ 2022-02-20 22:24 ` motorto
6 siblings, 0 replies; 8+ messages in thread
From: motorto @ 2022-02-20 22:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
There's a closed pull request on the void-packages repository
haskell-language-server: update to 1.5.1.
https://github.com/void-linux/void-packages/pull/34946
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: yes
#### Local build testing
- I built this PR locally for my native architecture, x86-64-glibc
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-02-20 22:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-08 17:05 [PR PATCH] haskell-language-server: update to 1.5.1 motorto
2022-01-08 21:38 ` ericonr
2022-01-08 23:01 ` motorto
2022-01-08 23:12 ` ericonr
2022-01-09 10:49 ` motorto
2022-01-09 10:51 ` motorto
2022-01-09 12:52 ` slotThe
2022-02-20 22:24 ` [PR PATCH] [Closed]: " motorto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).