Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: Cross building packages with `libgomp-devel` in makedepends breaks the masterdir
Date: Mon, 10 Jan 2022 15:38:57 +0100	[thread overview]
Message-ID: <20220110143857.gl6urwll4DIRTJSqgcw1c_OkYlu8Cn6bnHfWWWuF-LY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-31055@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/issues/31055#issuecomment-1008935998

Comment:
I know what happens with siril:
```
$ grep Libs: /usr/aarch64-linux-gnu/usr/lib/pkgconfig/libraw.pc 
Libs: -L${libdir} -lraw -lstdc++ -fopenmp
```
Since siril links to libraw, it will inherit the `-fopenmp` flag thus requiring libgomp-devel.

Normally _for cross builds_  this is not a problem since libgomp-devel is implicit. But note that for non-cross builds on aarch64 this would still be a problem.

Maybe a package having `-fopenmp` in its pkgconfig should depend on `libgomp-devel` to avoid this breakage.

Why is this happening? My guess is that when cross building libraw detects openmp is available at compile time so it uses it. When nocross building libraw doesn't use openmp.

Random thoughts:
 - if libraw can use openmp, maybe we want to use it for nocross as well, so add libgomp-devel explicitly
 - maybe a hook should check if `-fopenmp` is in some pkgconfig but `libgomp-devel` is not in depends and error out?
 - if `libgomp-devel` is implicit in every cross build, shouldn't also be implicit in every nocross build? Maybe more programs can benefit from openmp (e.g. siril itself I think can use openmp, not only indirectly via libraw).

  parent reply	other threads:[~2022-01-10 14:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-21 18:36 [ISSUE] " ericonr
2021-12-28  3:54 ` tornaria
2021-12-28  3:58 ` tornaria
2022-01-04  8:18 ` ericonr
2022-01-10 14:38 ` tornaria [this message]
2022-01-13 19:37 ` Chocimier
2022-05-20  2:12 ` github-actions

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220110143857.gl6urwll4DIRTJSqgcw1c_OkYlu8Cn6bnHfWWWuF-LY@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).