From: dkwo <dkwo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [WIP] New package: gap-4.11.1
Date: Tue, 11 Jan 2022 16:26:51 +0100 [thread overview]
Message-ID: <20220111152651.qe6oIOWW6x124h6elXm_Uaxady9Iw2Cqn-xUVKOUEgI@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34995@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1593 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/34995#issuecomment-1010074349
Comment:
Don't we need to `cd pkg` and `../bin/BuildPackages.sh` at some point?
I thought their make install does not work:
```
=> gap-4.11.1_1: running do_install ...
Warning, 'make install-bin' is incomplete
# TODO: make gac installable; this requires adjusting path in it, and
# installing the libtool script generated by configure somewhere; and then
# putting that path to it into gac)
Warning, 'make install-gaproot' is incomplete
# TODO: update paths and FLAGS in sysinfo.gap
# the following lines should not use `cp -r`, which is not quite portable,
# and which also may not deal with file permissions correctly
# TODO: what about CITATION, CONTRIBUTING.md, COPYRIGHT, INSTALL.md,
# LICENSE, README* ? Copy them also here? Or into some other path?
# TODO: also copy bin/BuildPackage.sh, as it is very useful?
Warning, 'make install-headers' is incomplete
# TODO: run the following only if HPC-GAP is enabled?
# TODO: take care of config.h, this is difficult
Warning, 'make install-libgap' is incomplete
libtool: warning: remember to run 'libtool --finish /usr/lib64'
```
Just a reference for myself: I also had
```
+configure_args="--with-gmp=system"
+hostmakedepends="tar"
+makedepends="givaro-devel mpfi-devel cddlib-devel libXaw-devel
+ boost-devel zeromq-devel fplll-devel wget chrpath fmt-devel libcurl-devel ncurses-devel"
```
Just a stupid lint: could you rebase on master and move up `make_install_target` by two?
next prev parent reply other threads:[~2022-01-11 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 14:38 [PR PATCH] " tornaria
2022-01-11 15:26 ` dkwo [this message]
2022-01-11 15:30 ` [PR PATCH] [Updated] " tornaria
2022-01-11 15:42 ` tornaria
2022-01-11 16:06 ` tornaria
2022-01-11 16:18 ` tornaria
2022-01-12 11:30 ` dkwo
2022-01-13 18:57 ` tornaria
2022-01-14 14:14 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220111152651.qe6oIOWW6x124h6elXm_Uaxady9Iw2Cqn-xUVKOUEgI@z \
--to=dkwo@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).