Re: [PR PATCH] [Updated] [WIP] New package: gap-4.11.1

[tornaria <tornaria@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 617 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages gap
https://github.com/void-linux/void-packages/pull/34995

[WIP] New package: gap-4.11.1
#### Testing the changes
- I tested the changes in this PR: **briefly**

This is a dependency of sagemath. It's working fine standalone, and I'm now working on having it used by sagemath from system. 

This is working fine on x86_64. I haven't tested musl, i686, or cross build yet.

Cc: @dkwo

A patch file from https://github.com/void-linux/void-packages/pull/34995.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gap-34995.patch --]
[-- Type: text/x-diff, Size: 4653 bytes --]

From b0fd6bfc383459ca0899ab28e3921ba6589c64d2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 10 Jan 2022 16:18:04 -0300
Subject: [PATCH 1/3] New package: gap-4.11.1

---
 common/shlibs        |  1 +
 srcpkgs/gap-devel    |  1 +
 srcpkgs/gap/template | 41 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+)
 create mode 120000 srcpkgs/gap-devel
 create mode 100644 srcpkgs/gap/template

diff --git a/common/shlibs b/common/shlibs
index 999d3ad714b8..1e537682c3a1 100644
--- a/common/shlibs
+++ b/common/shlibs
@@ -4021,6 +4021,7 @@ libpari-gmp.so.7 pari-2.13.0_1
 libpari-gmp-tls.so.7 pari-2.13.2_1
 libtree-sitter.so.0 tree-sitter-0.19.0_1
 libplanarity.so.0 planarity-3.0.1.1_1
+libgap.so.0 gap-4.11.1_1
 libgtkdatabox.so.1 gtkdatabox3-1.0.0_1
 libgf2x.so.3 gf2x-1.3.0_1
 libntl.so.44 ntl-11.5.1_1
diff --git a/srcpkgs/gap-devel b/srcpkgs/gap-devel
new file mode 120000
index 000000000000..e195f60d0b1a
--- /dev/null
+++ b/srcpkgs/gap-devel
@@ -0,0 +1 @@
+gap
\ No newline at end of file
diff --git a/srcpkgs/gap/template b/srcpkgs/gap/template
new file mode 100644
index 000000000000..683d4e4edb63
--- /dev/null
+++ b/srcpkgs/gap/template
@@ -0,0 +1,41 @@
+# Template file for 'gap'
+pkgname=gap
+version=4.11.1
+revision=1
+build_style=gnu-configure
+makedepends="gmp-devel zlib-devel readline-devel"
+make_install_target="install-bin install-gaproot install-headers install-libgap"
+short_desc="Groups, Algorithms, Programming - computational discrete algebra"
+maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
+license="GPL-2.0-or-later"
+homepage="http://www.gap-system.org/"
+distfiles="https://github.com/gap-system/gap/releases/download/v${version}/gap-${version}.tar.gz"
+checksum=6635c5da7d82755f8339486b9cac33766f58712f297e8234fba40818902ea304
+
+_GAPROOT=/usr/share/gap/
+
+# minimal required packages
+_GAPPKGS="GAPDoc primgrp SmallGrp transgrp"
+
+# other expected packages
+_GAPPKGS+=" atlasrep autpgrp alnuth crisp ctbllib FactInt fga irredsol laguna
+ polenta polycyclic resclasses sophus tomlib"
+
+post_install() {
+	vmkdir ${_GAPROOT}/pkg
+	for p in ${_GAPPKGS}; do
+		[ -d pkg/$p ] || p="$p-*"
+		vcopy "pkg/$p" ${_GAPROOT}/pkg
+	done
+	# not handled by make install-headers
+	vcopy gen/config.h /usr/include/gap
+}
+
+gap-devel_package() {
+	depends="${sourcepkg}>=${version}_${revision}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/include
+		vmove "usr/lib/*.so"
+	}
+}

From 1c60e9668e5c40bdcedcc4c7350e9be157bb3bae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 11 Jan 2022 00:09:49 -0300
Subject: [PATCH 2/3] gap: run more tests on full check

---
 srcpkgs/gap/template | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/srcpkgs/gap/template b/srcpkgs/gap/template
index 683d4e4edb63..74be8c03ea42 100644
--- a/srcpkgs/gap/template
+++ b/srcpkgs/gap/template
@@ -4,6 +4,7 @@ version=4.11.1
 revision=1
 build_style=gnu-configure
 makedepends="gmp-devel zlib-devel readline-devel"
+checkdepends="perl"
 make_install_target="install-bin install-gaproot install-headers install-libgap"
 short_desc="Groups, Algorithms, Programming - computational discrete algebra"
 maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
@@ -12,6 +13,11 @@ homepage="http://www.gap-system.org/"
 distfiles="https://github.com/gap-system/gap/releases/download/v${version}/gap-${version}.tar.gz"
 checksum=6635c5da7d82755f8339486b9cac33766f58712f297e8234fba40818902ea304
 
+if [ "$XBPS_CHECK_PKGS" = full ]; then
+	# not sure about this -- takes about 25 minutes
+	make_check_target=teststandard
+fi
+
 _GAPROOT=/usr/share/gap/
 
 # minimal required packages

From 9fa0e10cd5167ce7704cb52a552121f0663bd150 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 11 Jan 2022 12:30:31 -0300
Subject: [PATCH 3/3] fix lint

---
 srcpkgs/gap/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/gap/template b/srcpkgs/gap/template
index 74be8c03ea42..7bc7d13ace20 100644
--- a/srcpkgs/gap/template
+++ b/srcpkgs/gap/template
@@ -3,9 +3,9 @@ pkgname=gap
 version=4.11.1
 revision=1
 build_style=gnu-configure
+make_install_target="install-bin install-gaproot install-headers install-libgap"
 makedepends="gmp-devel zlib-devel readline-devel"
 checkdepends="perl"
-make_install_target="install-bin install-gaproot install-headers install-libgap"
 short_desc="Groups, Algorithms, Programming - computational discrete algebra"
 maintainer="Gonzalo Tornaría <tornaria@cmat.edu.uy>"
 license="GPL-2.0-or-later"