Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: grapejuice-4.8.2
@ 2022-01-11 16:14 wael444
  2022-01-11 17:05 ` [PR PATCH] [Updated] " wael444
                   ` (18 more replies)
  0 siblings, 19 replies; 20+ messages in thread
From: wael444 @ 2022-01-11 16:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

There is a new pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages master
https://github.com/void-linux/void-packages/pull/34998

New package: grapejuice-4.8.2
New package: grapejuice-4.8.2

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- grapejuice's dependencies `freetype-32bit`, `gnutls-32bit`, `libgcc-32bit` will not work on musl.



A patch file from https://github.com/void-linux/void-packages/pull/34998.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-34998.patch --]
[-- Type: text/x-diff, Size: 3318 bytes --]

From fb20619c0b162dd375c76fa313d79df3ec0ed1a9 Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Tue, 11 Jan 2022 18:40:57 +0300
Subject: [PATCH 1/2] New package: grapejuice-4.8.2

New package: grapejuice-4.8.2
---
 srcpkgs/grapejuice/template | 38 +++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 srcpkgs/grapejuice/template

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
new file mode 100644
index 000000000000..18a8996fda75
--- /dev/null
+++ b/srcpkgs/grapejuice/template
@@ -0,0 +1,38 @@
+# Template file for 'grapejuice'
+pkgname=grapejuice
+version=4.8.2
+revision=1
+_commit=13b50a946844715f6806f762aaa3aea536c07007
+wrksrc=${pkgname}-${_commit}
+build_style=python3-module
+hostmakedepends="python3-setuptools python3-pip python3-wheel
+ pkg-config cairo-devel gobject-introspection"
+
+depends="gtk+3 python3-pip python3-cairo python3-gobject desktop-file-utils xdg-utils cairo-devel
+ xdg-user-dirs gtk-update-icon-cache shared-mime-info pkg-config
+ gobject-introspection libgcc-32bit freetype-32bit gnutls-32bit"
+
+short_desc="Wine+Roblox management tool"
+maintainer="wael <40663@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://brinkervii.gitlab.io/grapejuice/"
+distfiles="https://gitlab.com/brinkervii/grapejuice/-/archive/${_commit}/grapejuice-${_commit}.tar.gz"
+checksum=d0ef19d227ccc01af07044e06ab2f2ec32d9186d2cfcf1f3c819723baeec1827
+
+pre_patch() {
+	vsed -i src/grapejuice_common/assets/desktop/roblox-app.desktop \
+		-e 's|$PLAYER_ICON|grapejuice-roblox-player|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+	vsed -i src/grapejuice_common/assets/desktop/roblox-player.desktop \
+		-e 's|$PLAYER_ICON|grapejuice-roblox-player|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+	vsed -i src/grapejuice_common/assets/desktop/roblox-studio.desktop \
+		-e 's|$STUDIO_ICON|grapejuice-roblox-studio|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+}
+
+post_install() {
+	vmkdir usr/share/applications
+	vmkdir usr/share/icons/hicolor
+	vmkdir usr/share/mime/packages/
+	vcopy src/grapejuice_common/assets/desktop/* usr/share/applications
+	vcopy src/grapejuice_common/assets/icons/hicolor/* usr/share/icons/hicolor
+	vcopy src/grapejuice_common/assets/mime_xml/x-grapejuice-roblox.xml usr/share/mime/packages
+}

From 0f45a6a9d0ebc5355c4bcaedab49bfb50e7fc93c Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Tue, 11 Jan 2022 19:10:52 +0300
Subject: [PATCH 2/2] grapejuice: update to 4.8.2.

update distfiles with pkgname
---
 srcpkgs/grapejuice/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
index 18a8996fda75..b3b3faa67c1a 100644
--- a/srcpkgs/grapejuice/template
+++ b/srcpkgs/grapejuice/template
@@ -16,7 +16,7 @@ short_desc="Wine+Roblox management tool"
 maintainer="wael <40663@protonmail.com>"
 license="GPL-3.0-only"
 homepage="https://brinkervii.gitlab.io/grapejuice/"
-distfiles="https://gitlab.com/brinkervii/grapejuice/-/archive/${_commit}/grapejuice-${_commit}.tar.gz"
+distfiles="https://gitlab.com/brinkervii/${pkgname}/-/archive/${_commit}/${pkgname}-${_commit}.tar.gz"
 checksum=d0ef19d227ccc01af07044e06ab2f2ec32d9186d2cfcf1f3c819723baeec1827
 
 pre_patch() {

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
@ 2022-01-11 17:05 ` wael444
  2022-01-11 17:34 ` Chocimier
                   ` (17 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: wael444 @ 2022-01-11 17:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages master
https://github.com/void-linux/void-packages/pull/34998

New package: grapejuice-4.8.2
New package: grapejuice-4.8.2

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- grapejuice's dependencies `freetype-32bit`, `gnutls-32bit`, `libgcc-32bit` will not work on musl.



A patch file from https://github.com/void-linux/void-packages/pull/34998.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-34998.patch --]
[-- Type: text/x-diff, Size: 4240 bytes --]

From fb20619c0b162dd375c76fa313d79df3ec0ed1a9 Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Tue, 11 Jan 2022 18:40:57 +0300
Subject: [PATCH 1/3] New package: grapejuice-4.8.2

New package: grapejuice-4.8.2
---
 srcpkgs/grapejuice/template | 38 +++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 srcpkgs/grapejuice/template

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
new file mode 100644
index 000000000000..18a8996fda75
--- /dev/null
+++ b/srcpkgs/grapejuice/template
@@ -0,0 +1,38 @@
+# Template file for 'grapejuice'
+pkgname=grapejuice
+version=4.8.2
+revision=1
+_commit=13b50a946844715f6806f762aaa3aea536c07007
+wrksrc=${pkgname}-${_commit}
+build_style=python3-module
+hostmakedepends="python3-setuptools python3-pip python3-wheel
+ pkg-config cairo-devel gobject-introspection"
+
+depends="gtk+3 python3-pip python3-cairo python3-gobject desktop-file-utils xdg-utils cairo-devel
+ xdg-user-dirs gtk-update-icon-cache shared-mime-info pkg-config
+ gobject-introspection libgcc-32bit freetype-32bit gnutls-32bit"
+
+short_desc="Wine+Roblox management tool"
+maintainer="wael <40663@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://brinkervii.gitlab.io/grapejuice/"
+distfiles="https://gitlab.com/brinkervii/grapejuice/-/archive/${_commit}/grapejuice-${_commit}.tar.gz"
+checksum=d0ef19d227ccc01af07044e06ab2f2ec32d9186d2cfcf1f3c819723baeec1827
+
+pre_patch() {
+	vsed -i src/grapejuice_common/assets/desktop/roblox-app.desktop \
+		-e 's|$PLAYER_ICON|grapejuice-roblox-player|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+	vsed -i src/grapejuice_common/assets/desktop/roblox-player.desktop \
+		-e 's|$PLAYER_ICON|grapejuice-roblox-player|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+	vsed -i src/grapejuice_common/assets/desktop/roblox-studio.desktop \
+		-e 's|$STUDIO_ICON|grapejuice-roblox-studio|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+}
+
+post_install() {
+	vmkdir usr/share/applications
+	vmkdir usr/share/icons/hicolor
+	vmkdir usr/share/mime/packages/
+	vcopy src/grapejuice_common/assets/desktop/* usr/share/applications
+	vcopy src/grapejuice_common/assets/icons/hicolor/* usr/share/icons/hicolor
+	vcopy src/grapejuice_common/assets/mime_xml/x-grapejuice-roblox.xml usr/share/mime/packages
+}

From 0f45a6a9d0ebc5355c4bcaedab49bfb50e7fc93c Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Tue, 11 Jan 2022 19:10:52 +0300
Subject: [PATCH 2/3] grapejuice: update to 4.8.2.

update distfiles with pkgname
---
 srcpkgs/grapejuice/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
index 18a8996fda75..b3b3faa67c1a 100644
--- a/srcpkgs/grapejuice/template
+++ b/srcpkgs/grapejuice/template
@@ -16,7 +16,7 @@ short_desc="Wine+Roblox management tool"
 maintainer="wael <40663@protonmail.com>"
 license="GPL-3.0-only"
 homepage="https://brinkervii.gitlab.io/grapejuice/"
-distfiles="https://gitlab.com/brinkervii/grapejuice/-/archive/${_commit}/grapejuice-${_commit}.tar.gz"
+distfiles="https://gitlab.com/brinkervii/${pkgname}/-/archive/${_commit}/${pkgname}-${_commit}.tar.gz"
 checksum=d0ef19d227ccc01af07044e06ab2f2ec32d9186d2cfcf1f3c819723baeec1827
 
 pre_patch() {

From b5ed1a82f8115a5bd1f97f253d35bc148fb197a2 Mon Sep 17 00:00:00 2001
From: wael <47404953+wael444@users.noreply.github.com>
Date: Tue, 11 Jan 2022 20:05:36 +0300
Subject: [PATCH 3/3] add missing python3 hostmakedepends

---
 srcpkgs/grapejuice/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
index b3b3faa67c1a..560c698155a3 100644
--- a/srcpkgs/grapejuice/template
+++ b/srcpkgs/grapejuice/template
@@ -5,7 +5,7 @@ revision=1
 _commit=13b50a946844715f6806f762aaa3aea536c07007
 wrksrc=${pkgname}-${_commit}
 build_style=python3-module
-hostmakedepends="python3-setuptools python3-pip python3-wheel
+hostmakedepends="python3 python3-devel python3-setuptools python3-pip python3-wheel
  pkg-config cairo-devel gobject-introspection"
 
 depends="gtk+3 python3-pip python3-cairo python3-gobject desktop-file-utils xdg-utils cairo-devel

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
  2022-01-11 17:05 ` [PR PATCH] [Updated] " wael444
@ 2022-01-11 17:34 ` Chocimier
  2022-01-11 17:37 ` cinerea0
                   ` (16 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Chocimier @ 2022-01-11 17:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010199525

Comment:
> * grapejuice's dependencies `freetype-32bit`, `gnutls-32bit`, `libgcc-32bit` will not work on musl.

They do not work on i686, and arguably on glibc x86_64 either, see https://github.com/void-linux/void-packages/pull/540#issuecomment-417855681.
I guess they need to be left to install manually.
 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
  2022-01-11 17:05 ` [PR PATCH] [Updated] " wael444
  2022-01-11 17:34 ` Chocimier
@ 2022-01-11 17:37 ` cinerea0
  2022-01-11 18:42 ` wael444
                   ` (15 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: cinerea0 @ 2022-01-11 17:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 229 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010201511

Comment:
Why is this pointing at some arbitrary commit instead of the project's latest release?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (2 preceding siblings ...)
  2022-01-11 17:37 ` cinerea0
@ 2022-01-11 18:42 ` wael444
  2022-01-11 18:43 ` cinerea0
                   ` (14 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: wael444 @ 2022-01-11 18:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010254425

Comment:

> Why is this pointing at some arbitrary commit instead of the project's latest release?

The latest release is 4.0.0. this is 4.8.2, 

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (3 preceding siblings ...)
  2022-01-11 18:42 ` wael444
@ 2022-01-11 18:43 ` cinerea0
  2022-01-11 18:49 ` wael444
                   ` (13 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: cinerea0 @ 2022-01-11 18:43 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010256087

Comment:
> The latest release is 4.0.0. this is 4.8.2,

Exactly, the version of the package should match the upstream release version.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (4 preceding siblings ...)
  2022-01-11 18:43 ` cinerea0
@ 2022-01-11 18:49 ` wael444
  2022-01-11 18:57 ` z-ffqq
                   ` (12 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: wael444 @ 2022-01-11 18:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010260595

Comment:
> > The latest release is 4.0.0. this is 4.8.2,
> 
> Exactly, the version of the package should match the upstream release version.

I will try to contact the project creator.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (5 preceding siblings ...)
  2022-01-11 18:49 ` wael444
@ 2022-01-11 18:57 ` z-ffqq
  2022-01-11 18:59 ` z-ffqq
                   ` (11 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: z-ffqq @ 2022-01-11 18:57 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 594 bytes --]

New comment by z-ffqq on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010266780

Comment:
> > The latest release is 4.0.0. this is 4.8.2,
> 
> Exactly, the version of the package should match the upstream release version.

The project maintainer of [grapejuice](https://gitlab.com/brinkervii/grapejuice) has forgot to make a new tag for the latest stable release (v4.8.2), so @wael444 is forced to use commits to avoid more confusion. v4.0.0 is NOT the newest stable version, v4.8.2 is

I just made this comment to clear up any confusion

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (6 preceding siblings ...)
  2022-01-11 18:57 ` z-ffqq
@ 2022-01-11 18:59 ` z-ffqq
  2022-01-11 19:00 ` z-ffqq
                   ` (10 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: z-ffqq @ 2022-01-11 18:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 603 bytes --]

New comment by z-ffqq on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010266780

Comment:
> > The latest release is 4.0.0. this is 4.8.2,
> 
> Exactly, the version of the package should match the upstream release version.

The project maintainer of [grapejuice](https://gitlab.com/brinkervii/grapejuice) has probably forgot to make a new tag for the latest stable release (v4.8.2), so @wael444 is forced to use commits to avoid more confusion. v4.0.0 is NOT the newest stable version, v4.8.2 is

I just made this comment to clear up any confusion

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (7 preceding siblings ...)
  2022-01-11 18:59 ` z-ffqq
@ 2022-01-11 19:00 ` z-ffqq
  2022-01-11 19:01 ` z-ffqq
                   ` (9 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: z-ffqq @ 2022-01-11 19:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 640 bytes --]

New comment by z-ffqq on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010266780

Comment:
> > The latest release is 4.0.0. this is 4.8.2,
> 
> Exactly, the version of the package should match the upstream release version.

The project maintainer of [grapejuice](https://gitlab.com/brinkervii/grapejuice) has probably forgot to make a new tag for the latest stable release (v4.8.2), so @wael444 is forced to use commits to avoid more confusion and to get the latest stable version. v4.0.0 is NOT the newest stable version, v4.8.2 is

I just made this comment to clear up any confusion

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (8 preceding siblings ...)
  2022-01-11 19:00 ` z-ffqq
@ 2022-01-11 19:01 ` z-ffqq
  2022-01-11 19:07 ` z-ffqq
                   ` (8 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: z-ffqq @ 2022-01-11 19:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

New comment by z-ffqq on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010266780

Comment:
> > The latest release is 4.0.0. this is 4.8.2,
> 
> Exactly, the version of the package should match the upstream release version.

The project maintainer of [grapejuice](https://gitlab.com/brinkervii/grapejuice) has probably forgot to make a new tag for the latest stable release (v4.8.2), so @wael444 is forced to use commits to avoid more confusion and to get the latest stable version. v4.0.0 is NOT the newest stable version, v4.8.2 is

If OP uses the tag, it'd use an outdated release of [grapejuice](https://gitlab.com/brinkervii/grapejuice).

I just made this comment to clear up any confusion

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (9 preceding siblings ...)
  2022-01-11 19:01 ` z-ffqq
@ 2022-01-11 19:07 ` z-ffqq
  2022-01-12  9:15 ` z-ffqq
                   ` (7 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: z-ffqq @ 2022-01-11 19:07 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1072 bytes --]

New comment by z-ffqq on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010266780

Comment:
> > The latest release is 4.0.0. this is 4.8.2,
> 
> Exactly, the version of the package should match the upstream release version.

The project maintainer of [grapejuice](https://gitlab.com/brinkervii/grapejuice) has probably forgot to make a new tag for the latest stable release (v4.8.2), so @wael444 is forced to use commits to avoid more confusion and to get the latest stable version. v4.0.0 is NOT the newest stable version, v4.8.2 is

If OP uses the tag, it'd use an outdated release of [grapejuice](https://gitlab.com/brinkervii/grapejuice).

I just made this comment to clear up any confusion

EDIT: I have talked to the maintainer and she said she will make tags for new releases of [grapejuice](https://gitlab.com/brinkervii/grapejuice). She's just really busy at the moment, so patience is key
![image](https://user-images.githubusercontent.com/36998498/149005655-948a15bb-9ccf-457b-8271-226431f4baf9.png)


^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (10 preceding siblings ...)
  2022-01-11 19:07 ` z-ffqq
@ 2022-01-12  9:15 ` z-ffqq
  2022-01-12 11:26 ` wael444
                   ` (6 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: z-ffqq @ 2022-01-12  9:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]

New comment by z-ffqq on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010266780

Comment:
> > The latest release is 4.0.0. this is 4.8.2,
> 
> Exactly, the version of the package should match the upstream release version.

The project maintainer of [grapejuice](https://gitlab.com/brinkervii/grapejuice) has probably forgot to make a new tag for the latest stable release (v4.8.2), so @wael444 is forced to use commits to avoid more confusion and to get the latest stable version. v4.0.0 is NOT the newest stable version, v4.8.2 is

If OP uses the tag, it'd use an outdated release of [grapejuice](https://gitlab.com/brinkervii/grapejuice).

I just made this comment to clear up any confusion

EDIT: I have talked to the maintainer and she said she will make tags for new releases of [grapejuice](https://gitlab.com/brinkervii/grapejuice). She's just really busy at the moment, so patience is key
![image](https://user-images.githubusercontent.com/36998498/149005655-948a15bb-9ccf-457b-8271-226431f4baf9.png)

EDIT 2: The maintainer has pushed a new tag for the latest release! (v4.9.2) 
![image](https://user-images.githubusercontent.com/36998498/149098828-643cd236-02ed-49d5-9545-8e567d6240bd.png)



^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (11 preceding siblings ...)
  2022-01-12  9:15 ` z-ffqq
@ 2022-01-12 11:26 ` wael444
  2022-01-12 14:26 ` wael444
                   ` (5 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: wael444 @ 2022-01-12 11:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010941102

Comment:
before i update the template, i would like to ask if having `freetype-32bit, gnutls-32bit, libgcc-32bit` is appropriate to be included in the package, as it only solves problems with wine such as 
libgcc-32bit:
```
libgcc_s.so.1 must be installed for pthread_cancel to work
wine client error:154: write: Bad file descriptor
``` 
freetype-32bit:
```
Wine cannot find the FreeType font library. 
```
gnutls-32bit:
```
HttpSendRequest Failed
```
i will not be including wine as an dependency as roblox requires a different build of wine with required patches to make roblox work.
these dependencies have nothing to do with grapejuice, but only provide fixes to wine problems.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (12 preceding siblings ...)
  2022-01-12 11:26 ` wael444
@ 2022-01-12 14:26 ` wael444
  2022-01-12 19:01 ` [PR PATCH] [Updated] " wael444
                   ` (4 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: wael444 @ 2022-01-12 14:26 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

New comment by wael444 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1010941102

Comment:
before i update the template, i would like to ask if having `freetype-32bit, gnutls-32bit, libgcc-32bit` is appropriate to be included in the package, as it only solves problems with wine such as 
libgcc-32bit:
```
libgcc_s.so.1 must be installed for pthread_cancel to work
wine client error:154: write: Bad file descriptor
``` 
freetype-32bit:
```
Wine cannot find the FreeType font library. 
```
gnutls-32bit:
```
HttpSendRequest Failed
```
i will not be including wine as an dependency as roblox requires a different build of wine with required patches to make roblox work.
these dependencies have nothing to do with grapejuice, but only provide fixes to wine problems.

edit: there is now a new grapejuice version, 4.9.2. should i close this pull request and open a new one to satisfy the new version?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Updated] New package: grapejuice-4.8.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (13 preceding siblings ...)
  2022-01-12 14:26 ` wael444
@ 2022-01-12 19:01 ` wael444
  2022-01-12 19:21 ` [PR PATCH] [Closed]: New package: grapejuice-4.9.2 Chocimier
                   ` (3 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: wael444 @ 2022-01-12 19:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 797 bytes --]

There is an updated pull request by wael444 against master on the void-packages repository

https://github.com/wael444/void-packages master
https://github.com/void-linux/void-packages/pull/34998

New package: grapejuice-4.8.2
New package: grapejuice-4.8.2

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- grapejuice's dependencies `freetype-32bit`, `gnutls-32bit`, `libgcc-32bit` will not work on musl.



A patch file from https://github.com/void-linux/void-packages/pull/34998.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-34998.patch --]
[-- Type: text/x-diff, Size: 6118 bytes --]

From fb20619c0b162dd375c76fa313d79df3ec0ed1a9 Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Tue, 11 Jan 2022 18:40:57 +0300
Subject: [PATCH 1/4] New package: grapejuice-4.8.2

New package: grapejuice-4.8.2
---
 srcpkgs/grapejuice/template | 38 +++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 srcpkgs/grapejuice/template

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
new file mode 100644
index 000000000000..18a8996fda75
--- /dev/null
+++ b/srcpkgs/grapejuice/template
@@ -0,0 +1,38 @@
+# Template file for 'grapejuice'
+pkgname=grapejuice
+version=4.8.2
+revision=1
+_commit=13b50a946844715f6806f762aaa3aea536c07007
+wrksrc=${pkgname}-${_commit}
+build_style=python3-module
+hostmakedepends="python3-setuptools python3-pip python3-wheel
+ pkg-config cairo-devel gobject-introspection"
+
+depends="gtk+3 python3-pip python3-cairo python3-gobject desktop-file-utils xdg-utils cairo-devel
+ xdg-user-dirs gtk-update-icon-cache shared-mime-info pkg-config
+ gobject-introspection libgcc-32bit freetype-32bit gnutls-32bit"
+
+short_desc="Wine+Roblox management tool"
+maintainer="wael <40663@protonmail.com>"
+license="GPL-3.0-only"
+homepage="https://brinkervii.gitlab.io/grapejuice/"
+distfiles="https://gitlab.com/brinkervii/grapejuice/-/archive/${_commit}/grapejuice-${_commit}.tar.gz"
+checksum=d0ef19d227ccc01af07044e06ab2f2ec32d9186d2cfcf1f3c819723baeec1827
+
+pre_patch() {
+	vsed -i src/grapejuice_common/assets/desktop/roblox-app.desktop \
+		-e 's|$PLAYER_ICON|grapejuice-roblox-player|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+	vsed -i src/grapejuice_common/assets/desktop/roblox-player.desktop \
+		-e 's|$PLAYER_ICON|grapejuice-roblox-player|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+	vsed -i src/grapejuice_common/assets/desktop/roblox-studio.desktop \
+		-e 's|$STUDIO_ICON|grapejuice-roblox-studio|g' -e 's|$GRAPEJUICE_EXECUTABLE|/usr/bin/grapejuice|g'
+}
+
+post_install() {
+	vmkdir usr/share/applications
+	vmkdir usr/share/icons/hicolor
+	vmkdir usr/share/mime/packages/
+	vcopy src/grapejuice_common/assets/desktop/* usr/share/applications
+	vcopy src/grapejuice_common/assets/icons/hicolor/* usr/share/icons/hicolor
+	vcopy src/grapejuice_common/assets/mime_xml/x-grapejuice-roblox.xml usr/share/mime/packages
+}

From 0f45a6a9d0ebc5355c4bcaedab49bfb50e7fc93c Mon Sep 17 00:00:00 2001
From: wael <40663@protonmail.com>
Date: Tue, 11 Jan 2022 19:10:52 +0300
Subject: [PATCH 2/4] grapejuice: update to 4.8.2.

update distfiles with pkgname
---
 srcpkgs/grapejuice/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
index 18a8996fda75..b3b3faa67c1a 100644
--- a/srcpkgs/grapejuice/template
+++ b/srcpkgs/grapejuice/template
@@ -16,7 +16,7 @@ short_desc="Wine+Roblox management tool"
 maintainer="wael <40663@protonmail.com>"
 license="GPL-3.0-only"
 homepage="https://brinkervii.gitlab.io/grapejuice/"
-distfiles="https://gitlab.com/brinkervii/grapejuice/-/archive/${_commit}/grapejuice-${_commit}.tar.gz"
+distfiles="https://gitlab.com/brinkervii/${pkgname}/-/archive/${_commit}/${pkgname}-${_commit}.tar.gz"
 checksum=d0ef19d227ccc01af07044e06ab2f2ec32d9186d2cfcf1f3c819723baeec1827
 
 pre_patch() {

From b5ed1a82f8115a5bd1f97f253d35bc148fb197a2 Mon Sep 17 00:00:00 2001
From: wael <47404953+wael444@users.noreply.github.com>
Date: Tue, 11 Jan 2022 20:05:36 +0300
Subject: [PATCH 3/4] add missing python3 hostmakedepends

---
 srcpkgs/grapejuice/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
index b3b3faa67c1a..560c698155a3 100644
--- a/srcpkgs/grapejuice/template
+++ b/srcpkgs/grapejuice/template
@@ -5,7 +5,7 @@ revision=1
 _commit=13b50a946844715f6806f762aaa3aea536c07007
 wrksrc=${pkgname}-${_commit}
 build_style=python3-module
-hostmakedepends="python3-setuptools python3-pip python3-wheel
+hostmakedepends="python3 python3-devel python3-setuptools python3-pip python3-wheel
  pkg-config cairo-devel gobject-introspection"
 
 depends="gtk+3 python3-pip python3-cairo python3-gobject desktop-file-utils xdg-utils cairo-devel

From 9cb456c351d2d523c60fb2bff453042fc65fc3a2 Mon Sep 17 00:00:00 2001
From: wael <47404953+wael444@users.noreply.github.com>
Date: Wed, 12 Jan 2022 22:01:01 +0300
Subject: [PATCH 4/4] New package: grapejuice-4.9.2

---
 srcpkgs/grapejuice/template | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/grapejuice/template b/srcpkgs/grapejuice/template
index 560c698155a3..f3a5b434f975 100644
--- a/srcpkgs/grapejuice/template
+++ b/srcpkgs/grapejuice/template
@@ -1,23 +1,21 @@
 # Template file for 'grapejuice'
 pkgname=grapejuice
-version=4.8.2
+version=4.9.2
 revision=1
-_commit=13b50a946844715f6806f762aaa3aea536c07007
-wrksrc=${pkgname}-${_commit}
+wrksrc=${pkgname}-v${version}
 build_style=python3-module
-hostmakedepends="python3 python3-devel python3-setuptools python3-pip python3-wheel
+hostmakedepends="python3-setuptools python3-pip python3-wheel
  pkg-config cairo-devel gobject-introspection"
 
 depends="gtk+3 python3-pip python3-cairo python3-gobject desktop-file-utils xdg-utils cairo-devel
- xdg-user-dirs gtk-update-icon-cache shared-mime-info pkg-config
- gobject-introspection libgcc-32bit freetype-32bit gnutls-32bit"
+ xdg-user-dirs gtk-update-icon-cache shared-mime-info pkg-config gobject-introspection"
 
 short_desc="Wine+Roblox management tool"
 maintainer="wael <40663@protonmail.com>"
 license="GPL-3.0-only"
 homepage="https://brinkervii.gitlab.io/grapejuice/"
-distfiles="https://gitlab.com/brinkervii/${pkgname}/-/archive/${_commit}/${pkgname}-${_commit}.tar.gz"
-checksum=d0ef19d227ccc01af07044e06ab2f2ec32d9186d2cfcf1f3c819723baeec1827
+distfiles="https://gitlab.com/brinkervii/${pkgname}/-/archive/v${version}/${pkgname}-v${version}.tar.gz"
+checksum=2d377a2baa511dd7385c07e459cc278cd7da6d0fa35e5a31cb819e35c24e830c
 
 pre_patch() {
 	vsed -i src/grapejuice_common/assets/desktop/roblox-app.desktop \

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: [PR PATCH] [Closed]: New package: grapejuice-4.9.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (14 preceding siblings ...)
  2022-01-12 19:01 ` [PR PATCH] [Updated] " wael444
@ 2022-01-12 19:21 ` Chocimier
  2022-01-13  8:58 ` karimrir1
                   ` (2 subsequent siblings)
  18 siblings, 0 replies; 20+ messages in thread
From: Chocimier @ 2022-01-12 19:21 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

There's a closed pull request on the void-packages repository

New package: grapejuice-4.9.2
https://github.com/void-linux/void-packages/pull/34998

Description:
New package: grapejuice-4.8.2

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- grapejuice's dependencies `freetype-32bit`, `gnutls-32bit`, `libgcc-32bit` will not work on musl.



^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.9.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (15 preceding siblings ...)
  2022-01-12 19:21 ` [PR PATCH] [Closed]: New package: grapejuice-4.9.2 Chocimier
@ 2022-01-13  8:58 ` karimrir1
  2022-01-13  9:11 ` karimrir1
  2022-01-13  9:19 ` karimrir1
  18 siblings, 0 replies; 20+ messages in thread
From: karimrir1 @ 2022-01-13  8:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

New comment by karimrir1 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1011928872

Comment:
> To sum up:
> 
>     * this is launcher of single proprietary game
> 
>     * moving fast
> 
>     * that can't be installed with dependencies of game due to way void multilib works
> 
>     * requiring wine built from source separately (up to 1 hour build time)
> 
>     * being pure python module buildable within minutes
> 
> 
> Sorry, but it is not worthwhile to package this. However, after restoring -32bit dependencies jut for glibc x86_64, you have nice template you can share somewhere else.

It's not a launcher, It's a wrapper for wine. Just like lutris. Nothing else nothing more.

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.9.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (16 preceding siblings ...)
  2022-01-13  8:58 ` karimrir1
@ 2022-01-13  9:11 ` karimrir1
  2022-01-13  9:19 ` karimrir1
  18 siblings, 0 replies; 20+ messages in thread
From: karimrir1 @ 2022-01-13  9:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 923 bytes --]

New comment by karimrir1 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1011928872

Comment:
> To sum up:
> 
>     * this is launcher of single proprietary game
> 
>     * moving fast
> 
>     * that can't be installed with dependencies of game due to way void multilib works
> 
>     * requiring wine built from source separately (up to 1 hour build time)
> 
>     * being pure python module buildable within minutes
> 
> 
> Sorry, but it is not worthwhile to package this. However, after restoring -32bit dependencies jut for glibc x86_64, you have nice template you can share somewhere else.

It's not a launcher, It's a wrapper for wine. Just like lutris. Nothing else nothing more.

Edit: If you were right about being it a launcher for a proprietary game, then why is there a MultiMC package?? Isn't MultiMC a launcher for a single proprietary game?

^ permalink raw reply	[flat|nested] 20+ messages in thread

* Re: New package: grapejuice-4.9.2
  2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
                   ` (17 preceding siblings ...)
  2022-01-13  9:11 ` karimrir1
@ 2022-01-13  9:19 ` karimrir1
  18 siblings, 0 replies; 20+ messages in thread
From: karimrir1 @ 2022-01-13  9:19 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]

New comment by karimrir1 on void-packages repository

https://github.com/void-linux/void-packages/pull/34998#issuecomment-1011928872

Comment:
> To sum up:
> 
>     * this is launcher of single proprietary game
> 
>     * moving fast
> 
>     * that can't be installed with dependencies of game due to way void multilib works
> 
>     * requiring wine built from source separately (up to 1 hour build time)
> 
>     * being pure python module buildable within minutes
> 
> 
> Sorry, but it is not worthwhile to package this. However, after restoring -32bit dependencies jut for glibc x86_64, you have nice template you can share somewhere else.

It's not a launcher, It's a wrapper for wine. Just like lutris. Nothing else nothing more.

Edit: If you were right about being it a launcher for a proprietary game, then why is there a MultiMC package?? Isn't MultiMC a launcher for a single proprietary game?

I never intended to insult you, I was just trying to make you understand that Grapejuice is a wrapper, not a launcher. I honestly appreciate the work you guys do at the void linux project. I even installed void linux on my mom's laptop (because void linux is pretty low in terms of memory usage and her computer is yet just another bootloader to Google Chrome.)

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-01-13  9:19 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 16:14 [PR PATCH] New package: grapejuice-4.8.2 wael444
2022-01-11 17:05 ` [PR PATCH] [Updated] " wael444
2022-01-11 17:34 ` Chocimier
2022-01-11 17:37 ` cinerea0
2022-01-11 18:42 ` wael444
2022-01-11 18:43 ` cinerea0
2022-01-11 18:49 ` wael444
2022-01-11 18:57 ` z-ffqq
2022-01-11 18:59 ` z-ffqq
2022-01-11 19:00 ` z-ffqq
2022-01-11 19:01 ` z-ffqq
2022-01-11 19:07 ` z-ffqq
2022-01-12  9:15 ` z-ffqq
2022-01-12 11:26 ` wael444
2022-01-12 14:26 ` wael444
2022-01-12 19:01 ` [PR PATCH] [Updated] " wael444
2022-01-12 19:21 ` [PR PATCH] [Closed]: New package: grapejuice-4.9.2 Chocimier
2022-01-13  8:58 ` karimrir1
2022-01-13  9:11 ` karimrir1
2022-01-13  9:19 ` karimrir1

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).