Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] New package: python3-tasklib-2.4.3_1
Date: Wed, 12 Jan 2022 22:28:53 +0100	[thread overview]
Message-ID: <20220112212853.FMc-mp-28xTfGZzcKDDFtk1zq8Z1cMHdl_wNefiPWko@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35016@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 480 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35016#discussion_r783456688

Comment:
Usually setup.py, setup.cfg or pytest.ini contains install_requires or an equivalent, also checks will fail if you forget to specify a dependency and don't add pip to checkdepends (which defeats the purpose of having checks).
https://github.com/GothenburgBitFactory/tasklib/blob/f7672ddebe6d4f4ff8fdb743df0b2939ba66ec78/setup.py#L25

  parent reply	other threads:[~2022-01-12 21:28 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12 18:37 [PR PATCH] " Barbarossa93
2022-01-12 18:41 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-12 18:46 ` Barbarossa93
2022-01-12 18:52 ` Barbarossa93
2022-01-12 18:59 ` Barbarossa93
2022-01-12 19:01 ` Barbarossa93
2022-01-12 19:06 ` Barbarossa93
2022-01-12 19:09 ` Barbarossa93
2022-01-12 19:13 ` Barbarossa93
2022-01-12 19:21 ` Barbarossa93
2022-01-12 19:33 ` Barbarossa93
2022-01-12 19:36 ` Barbarossa93
2022-01-12 19:39 ` Barbarossa93
2022-01-12 19:40 ` Barbarossa93
2022-01-12 20:57 ` Barbarossa93
2022-01-12 21:06 ` [PR REVIEW] " paper42
2022-01-12 21:06 ` paper42
2022-01-12 21:09 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-12 21:10 ` [PR REVIEW] " Barbarossa93
2022-01-12 21:13 ` Barbarossa93
2022-01-12 21:14 ` Barbarossa93
2022-01-12 21:15 ` paper42
2022-01-12 21:19 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-12 21:19 ` Barbarossa93
2022-01-12 21:21 ` [PR REVIEW] " paper42
2022-01-12 21:25 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-12 21:28 ` paper42 [this message]
2022-01-12 21:29 ` [PR REVIEW] " Barbarossa93
2022-01-12 21:29 ` Barbarossa93
2022-01-12 21:33 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-12 21:37 ` Barbarossa93
2022-01-12 21:38 ` [PR REVIEW] " ahesford
2022-01-12 21:42 ` ahesford
2022-01-12 21:42 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-12 21:44 ` Barbarossa93
2022-01-12 21:48 ` [PR REVIEW] " Barbarossa93
2022-01-12 21:48 ` Barbarossa93
2022-01-12 21:58 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-12 23:23 ` Barbarossa93
2022-01-12 23:26 ` [PR PATCH] [Updated] New packages: vit-2.1.0_1 and python3-tasklib-2.4.3_1 Barbarossa93
2022-01-12 23:31 ` Barbarossa93
2022-01-12 23:40 ` Barbarossa93
2022-01-13  0:50 ` Barbarossa93
2022-01-13  0:57 ` Barbarossa93
2022-01-13 18:09 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-13 19:30 ` Barbarossa93
2022-01-14 12:02 ` [PR REVIEW] " paper42
2022-01-14 12:02 ` paper42
2022-01-14 12:02 ` paper42
2022-01-14 13:13 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-14 13:14 ` [PR REVIEW] " Barbarossa93
2022-01-14 13:27 ` [PR PATCH] [Updated] " Barbarossa93
2022-01-14 15:10 ` [PR PATCH] [Merged]: New packages: vit-2.1.0 and python3-tasklib-2.4.3 paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220112212853.FMc-mp-28xTfGZzcKDDFtk1zq8Z1cMHdl_wNefiPWko@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    --subject='Re: [PR REVIEW] New package: python3-tasklib-2.4.3_1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).