[-- Attachment #1: Type: text/plain, Size: 1270 bytes --] There is a new pull request by tibequadorian against master on the void-packages repository https://github.com/tibequadorian/void-packages xfce4-docklike-plugin https://github.com/void-linux/void-packages/pull/35022 New package: xfce4-docklike-plugin-0.4.0 <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **YES**|**briefly**|**NO** <!-- #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO** --> <!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration) and test at least one native build and, if supported, at least one cross build. Ignore this section if this PR is not skipping CI. --> <!-- #### Local build testing - I built this PR locally for my native architecture, (ARCH-LIBC) - I built this PR locally for these architectures (if supported. mark crossbuilds): - aarch64-musl - armv7l - armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/35022.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-xfce4-docklike-plugin-35022.patch --] [-- Type: text/x-diff, Size: 1204 bytes --] From 203c8e0d75ebbbf72f6ff7f077ac4c3dc8917a57 Mon Sep 17 00:00:00 2001 From: tibequadorian <tibequadorian@posteo.de> Date: Thu, 13 Jan 2022 00:33:31 +0100 Subject: [PATCH] New package: xfce4-docklike-plugin-0.4.0 --- srcpkgs/xfce4-docklike-plugin/template | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 srcpkgs/xfce4-docklike-plugin/template diff --git a/srcpkgs/xfce4-docklike-plugin/template b/srcpkgs/xfce4-docklike-plugin/template new file mode 100644 index 000000000000..999a9304e389 --- /dev/null +++ b/srcpkgs/xfce4-docklike-plugin/template @@ -0,0 +1,13 @@ +# Template file for 'xfce4-docklike-plugin' +pkgname=xfce4-docklike-plugin +version=0.4.0 +revision=1 +build_style=gnu-configure +hostmakedepends="pkg-config intltool" +makedepends="xfce4-panel-devel libwnck-devel" +short_desc="Modern, minimalist taskbar for Xfce" +maintainer="tibequadorian <tibequadorian@posteo.de>" +license="GPL-3.0-or-later" +homepage="https://docs.xfce.org/panel-plugins/xfce4-docklike-plugin/start" +distfiles="https://archive.xfce.org/src/panel-plugins/${pkgname}/${version%.*}/${pkgname}-${version}.tar.bz2" +checksum=b4136a70897895f0599e8e7237223dde17221f099a2fc816917d5894bbd4f372
[-- Attachment #1: Type: text/plain, Size: 1256 bytes --] There is an updated pull request by tibequadorian against master on the void-packages repository https://github.com/tibequadorian/void-packages xfce4-docklike-plugin https://github.com/void-linux/void-packages/pull/35022 New package: xfce4-docklike-plugin-0.4.0 <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **YES** <!-- #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO** --> <!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration) and test at least one native build and, if supported, at least one cross build. Ignore this section if this PR is not skipping CI. --> <!-- #### Local build testing - I built this PR locally for my native architecture, (ARCH-LIBC) - I built this PR locally for these architectures (if supported. mark crossbuilds): - aarch64-musl - armv7l - armv6l-musl --> A patch file from https://github.com/void-linux/void-packages/pull/35022.patch is attached [-- Warning: decoded text below may be mangled, UTF-8 assumed --] [-- Attachment #2: github-pr-xfce4-docklike-plugin-35022.patch --] [-- Type: text/x-diff, Size: 3423 bytes --] From ba9acdd96e4c9dbe3b6b109b34ad2e8fb54e7c71 Mon Sep 17 00:00:00 2001 From: tibequadorian <tibequadorian@posteo.de> Date: Thu, 13 Jan 2022 00:33:31 +0100 Subject: [PATCH] New package: xfce4-docklike-plugin-0.4.0 --- ...ame-called-but-libgen.h-not-included.patch | 56 +++++++++++++++++++ srcpkgs/xfce4-docklike-plugin/template | 14 +++++ 2 files changed, 70 insertions(+) create mode 100644 srcpkgs/xfce4-docklike-plugin/patches/0001-basename-called-but-libgen.h-not-included.patch create mode 100644 srcpkgs/xfce4-docklike-plugin/template diff --git a/srcpkgs/xfce4-docklike-plugin/patches/0001-basename-called-but-libgen.h-not-included.patch b/srcpkgs/xfce4-docklike-plugin/patches/0001-basename-called-but-libgen.h-not-included.patch new file mode 100644 index 000000000000..81624f468ad5 --- /dev/null +++ b/srcpkgs/xfce4-docklike-plugin/patches/0001-basename-called-but-libgen.h-not-included.patch @@ -0,0 +1,56 @@ +From 1af295dba41c2a5a6a91b83ce4eebc0cf6225598 Mon Sep 17 00:00:00 2001 +From: Hakan Erduman <hakan@erduman.de> +Date: Fri, 7 Jan 2022 18:22:43 +0100 +Subject: [PATCH] basename() called but <libgen.h> not included + + Seen while porting to alpine linux. + This compiles on GNU libc since it is not posixly strict + enough in regard to header files but fails on e.g. musl + or other c libraries. + + The patch adresses this by using g_path_get_basename from + glib instead. This may also help compilation on the *BSDs. + and void linux, musl variety. +--- + src/Helpers.cpp | 2 +- + src/Wnck.cpp | 4 ++-- + 2 files changed, 3 insertions(+), 3 deletions(-) + +diff --git a/src/Helpers.cpp b/src/Helpers.cpp +index ece3e95..086dff3 100644 +--- a/src/Helpers.cpp ++++ b/src/Helpers.cpp +@@ -83,7 +83,7 @@ namespace Help + { + char buffer[1024]; + strcpy(buffer, str.c_str()); +- return basename(buffer); ++ return g_path_get_basename(buffer); + } + + std::string trim(const std::string str) +diff --git a/src/Wnck.cpp b/src/Wnck.cpp +index 2ab598f..1c08335 100644 +--- a/src/Wnck.cpp ++++ b/src/Wnck.cpp +@@ -35,7 +35,7 @@ namespace Wnck + int nbr = read(fd, buffer, 512); + ::close(fd); + +- char* exe = basename(buffer); ++ char* exe = g_path_get_basename(buffer); + if (strcmp(exe, "python") != 0) // ADDIT graphical interpreters here + return exe; + +@@ -44,7 +44,7 @@ namespace Wnck + ; + + if (it < buffer + nbr) +- return basename(it); ++ return g_path_get_basename(it); + } + + // fallback : return window's name +-- +2.34.1 + diff --git a/srcpkgs/xfce4-docklike-plugin/template b/srcpkgs/xfce4-docklike-plugin/template new file mode 100644 index 000000000000..ab9f49f303c1 --- /dev/null +++ b/srcpkgs/xfce4-docklike-plugin/template @@ -0,0 +1,14 @@ +# Template file for 'xfce4-docklike-plugin' +pkgname=xfce4-docklike-plugin +version=0.4.0 +revision=1 +build_style=gnu-configure +configure_args="--with-locales-dir=/usr/share/locale" +hostmakedepends="pkg-config intltool" +makedepends="xfce4-panel-devel libwnck-devel" +short_desc="Modern, minimalist taskbar for Xfce" +maintainer="tibequadorian <tibequadorian@posteo.de>" +license="GPL-3.0-or-later" +homepage="https://docs.xfce.org/panel-plugins/xfce4-docklike-plugin/start" +distfiles="https://archive.xfce.org/src/panel-plugins/${pkgname}/${version%.*}/${pkgname}-${version}.tar.bz2" +checksum=b4136a70897895f0599e8e7237223dde17221f099a2fc816917d5894bbd4f372
[-- Attachment #1: Type: text/plain, Size: 245 bytes --] New review comment by Piraty on void-packages repository https://github.com/void-linux/void-packages/pull/35022#discussion_r784266732 Comment: why? configure works fine on its own > checking for locales directory... ${prefix}/share/locale
[-- Attachment #1: Type: text/plain, Size: 180 bytes --] New review comment by Piraty on void-packages repository https://github.com/void-linux/void-packages/pull/35022#discussion_r784275722 Comment: strike that, fails for crossbuilds
[-- Attachment #1: Type: text/plain, Size: 205 bytes --] New review comment by Piraty on void-packages repository https://github.com/void-linux/void-packages/pull/35022#discussion_r784275722 Comment: strike that, fails for crossbuilds, same as Thunar actually
[-- Attachment #1: Type: text/plain, Size: 1177 bytes --] There's a closed pull request on the void-packages repository New package: xfce4-docklike-plugin-0.4.0 https://github.com/void-linux/void-packages/pull/35022 Description: <!-- Uncomment relevant sections and delete options which are not applicable --> #### Testing the changes - I tested the changes in this PR: **YES** closes #34879 patch from https://gitlab.xfce.org/panel-plugins/xfce4-docklike-plugin/-/issues/33 <!-- #### New package - This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO** --> <!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration) and test at least one native build and, if supported, at least one cross build. Ignore this section if this PR is not skipping CI. --> <!-- #### Local build testing - I built this PR locally for my native architecture, (ARCH-LIBC) - I built this PR locally for these architectures (if supported. mark crossbuilds): - aarch64-musl - armv7l - armv6l-musl -->
[-- Attachment #1: Type: text/plain, Size: 190 bytes --] New review comment by tibequadorian on void-packages repository https://github.com/void-linux/void-packages/pull/35022#discussion_r784293937 Comment: yes it's in almost all xfce4 packages
[-- Attachment #1: Type: text/plain, Size: 185 bytes --] New comment by tibequadorian on void-packages repository https://github.com/void-linux/void-packages/pull/35022#issuecomment-1012539236 Comment: @Piraty don't forget to close #34879