From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: dumb_runtime_dir-1.0.0
Date: Mon, 17 Jan 2022 16:41:01 +0100 [thread overview]
Message-ID: <20220117154101.hSZSd-A1NPZp5WsJaYkMfTeaXCqZMCZXshRgrvkU_xQ@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-34724@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/34724#issuecomment-1014673551
Comment:
I've read the PR and the upstream code and everything LGTM.
I built and installed on my desktop, and works ok. Before I had `pam_rundir` which I replaced by this. I like that it comes preconfigured in pam-base. Even if both elogind and this are installed, it doesn't seem a problem at least when run in the order specified in this PR (but I haven't and won't test that).
I wonder if the package name should be `pam-dumb_runtime_dir` for consistency with other pam modules, or have the words "pam" and/or "rundir" somewhere for the benefit of searching.
In any case, other than the package name (on which I have no clear opinion), this is positive review from me.
next prev parent reply other threads:[~2022-01-17 15:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-28 2:10 [PR PATCH] " ifreund
2021-12-28 2:25 ` [PR PATCH] [Updated] " ifreund
2021-12-28 2:53 ` ifreund
2021-12-31 3:39 ` ifreund
2022-01-17 12:00 ` ifreund
2022-01-17 15:41 ` tornaria [this message]
2022-01-17 15:58 ` ifreund
2022-01-17 16:04 ` tornaria
2022-01-17 16:37 ` ifreund
2022-01-18 12:33 ` tornaria
2022-01-18 15:03 ` ifreund
2022-01-18 15:03 ` ifreund
2022-01-29 18:49 ` [PR PATCH] [Updated] " ifreund
2022-01-29 18:57 ` ifreund
2022-01-29 18:59 ` New package: dumb_runtime_dir-1.0.2 ifreund
2022-01-29 19:53 ` [PR PATCH] [Updated] " ifreund
2022-01-29 19:54 ` ifreund
2022-01-29 20:02 ` [PR PATCH] [Merged]: " leahneukirchen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117154101.hSZSd-A1NPZp5WsJaYkMfTeaXCqZMCZXshRgrvkU_xQ@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).