Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] intermodal: update to 0.1.12.
@ 2022-01-16 12:39 jcgruenhage
  2022-01-17 12:58 ` [PR PATCH] [Updated] " jcgruenhage
                   ` (18 more replies)
  0 siblings, 19 replies; 20+ messages in thread
From: jcgruenhage @ 2022-01-16 12:39 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1740 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages intermodal-0.1.12_1
https://github.com/void-linux/void-packages/pull/35082

intermodal: update to 0.1.12.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### tl;dr: computers are hard
So, the `imdl` package was a bit barebones so far, but I'm not quite sure what the correct way to fix this is. Intermodal does have really nice tooling for automatically generating additional artifacts (completions, man pages, other docs, etc) and does try to make packaging `imdl` easy, but sadly, this additional tooling is not really built with cross compilation in mind (afaict), and it requires access to the git history of the repository (for changelog generation). It would be possible to work around these limitations here, but it probably makes sense to instead think about how to improve this, approach upstream about it (they say "First off, thank you very much! If I can do anything to make packaging Intermodal easier, please don't hesistate to open an issue." in the repo upstream and provide a lot of useful info in the readme already), improve the situation upstream and then use the improved tooling in a package here.

I have still extended the package a tiny bit to ship shell completions, because this is the part that bugged me the most, and doing so was fairly straight forward using our vtargetrun helper. I've cargo-culted those bits from our rustup package, I hope this is the right way to go?

cc @casey (upstream) and @ThatNerdyPikachu (void contributor for this package)

A patch file from https://github.com/void-linux/void-packages/pull/35082.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-intermodal-0.1.12_1-35082.patch --]
[-- Type: text/x-diff, Size: 1385 bytes --]

From ff23327082901719324035bd78232bce430ab428 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 16 Jan 2022 13:12:25 +0100
Subject: [PATCH] intermodal: update to 0.1.12.

---
 srcpkgs/intermodal/template | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/intermodal/template b/srcpkgs/intermodal/template
index bb0e6148ad02..dd5366db135b 100644
--- a/srcpkgs/intermodal/template
+++ b/srcpkgs/intermodal/template
@@ -1,11 +1,27 @@
 # Template file for 'intermodal'
 pkgname=intermodal
-version=0.1.10
+version=0.1.12
 revision=1
 build_style=cargo
+build_helper=qemu
 short_desc="User-friendly and featureful command-line BitTorrent metainfo utility"
 maintainer="Pika <pika@lasagna.dev>"
 license="CC0-1.0"
 homepage="https://github.com/casey/intermodal"
 distfiles="https://github.com/casey/intermodal/archive/v${version}.tar.gz"
-checksum=8bb3e4f549e5c4446543babd741fec0cd7c42da4d49eca3e98c5f7611ad59618
+checksum=cd62894e519dc5aa0284a5f48aab86e1a45c3bc96b8a5481741adb6960d4751a
+
+post_build() {
+	IMDL="target/${RUST_TARGET}/release/imdl"
+	ln -sf "${IMDL}" imdl
+
+	for shell in zsh bash fish; do
+		vtargetrun ./imdl completions ${shell} >imdl.${shell}
+	done
+}
+
+post_install() {
+	for shell in zsh bash fish; do
+		vcompletion imdl.${shell} ${shell}
+	done
+}

^ permalink raw reply	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2022-01-26 19:38 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-16 12:39 [PR PATCH] intermodal: update to 0.1.12 jcgruenhage
2022-01-17 12:58 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-18 13:20 ` [PR REVIEW] " ahesford
2022-01-18 13:21 ` ahesford
2022-01-18 13:31 ` jcgruenhage
2022-01-18 13:31 ` ahesford
2022-01-18 13:33 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-18 13:42 ` jcgruenhage
2022-01-18 13:52 ` Johnnynator
2022-01-18 13:53 ` Johnnynator
2022-01-18 14:42 ` ahesford
2022-01-18 14:49 ` jcgruenhage
2022-01-18 15:17 ` ahesford
2022-01-25 10:28 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-25 10:30 ` jcgruenhage
2022-01-25 10:56 ` jcgruenhage
2022-01-25 11:03 ` jcgruenhage
2022-01-25 11:31 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-26 19:21 ` jcgruenhage
2022-01-26 19:38 ` [PR PATCH] [Closed]: " ahesford

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).