From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: intermodal: update to 0.1.12.
Date: Tue, 18 Jan 2022 14:31:38 +0100 [thread overview]
Message-ID: <20220118133138.2RCyTTjH7FTG8I-JpSgCoVt9oe0hDf-5YccxjYgIuLE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35082@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/35082#issuecomment-1015415324
Comment:
Cloning the git repo is generally undesirable with xbps-src. The best fix from our perspective would be for upstream to include pre-generated docs in the release tarballs. This requires a bit of release engineering but shouldn't be too terrible and can be scripted for future releases.
In general, I think maintaining a separate changelog is good practice for several reasons:
1. It doesn't require repository history to review.
2. It provides an opportunity to add context to some more sophisticated changes.
3. Not all Git commits are worth inclusion in history. Changelogs should provide a good summary of substantive changes, not every minor tweak. (Does it really matter to others that you fixed a typo in one commit that you introduced in the preceding commit?)
For packages that require doc generation, we have sometimes used a hostmakedepends trick to get those docs in cross-compiled packages. For native packages, the docs are built as expected; for cross builds, the package itself is added to hostmakedepends. The docs can then be copied from the native package on the host to the $DESTDIR. Yes, this is a hack, but it works.
next prev parent reply other threads:[~2022-01-18 13:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-16 12:39 [PR PATCH] " jcgruenhage
2022-01-17 12:58 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-18 13:20 ` [PR REVIEW] " ahesford
2022-01-18 13:21 ` ahesford
2022-01-18 13:31 ` jcgruenhage
2022-01-18 13:31 ` ahesford [this message]
2022-01-18 13:33 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-18 13:42 ` jcgruenhage
2022-01-18 13:52 ` Johnnynator
2022-01-18 13:53 ` Johnnynator
2022-01-18 14:42 ` ahesford
2022-01-18 14:49 ` jcgruenhage
2022-01-18 15:17 ` ahesford
2022-01-25 10:28 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-25 10:30 ` jcgruenhage
2022-01-25 10:56 ` jcgruenhage
2022-01-25 11:03 ` jcgruenhage
2022-01-25 11:31 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-26 19:21 ` jcgruenhage
2022-01-26 19:38 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118133138.2RCyTTjH7FTG8I-JpSgCoVt9oe0hDf-5YccxjYgIuLE@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).