Github messages for voidlinux
 help / color / mirror / Atom feed
From: jcgruenhage <jcgruenhage@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] intermodal: update to 0.1.12.
Date: Tue, 18 Jan 2022 14:33:53 +0100	[thread overview]
Message-ID: <20220118133353.jiBIGB4SjcoOVe-Ob3OfuccMPOuvz6fZ072sEhfUN0Y@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35082@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1745 bytes --]

There is an updated pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages intermodal-0.1.12_1
https://github.com/void-linux/void-packages/pull/35082

intermodal: update to 0.1.12.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### tl;dr: computers are hard
So, the `imdl` package was a bit barebones so far, but I'm not quite sure what the correct way to fix this is. Intermodal does have really nice tooling for automatically generating additional artifacts (completions, man pages, other docs, etc) and does try to make packaging `imdl` easy, but sadly, this additional tooling is not really built with cross compilation in mind (afaict), and it requires access to the git history of the repository (for changelog generation). It would be possible to work around these limitations here, but it probably makes sense to instead think about how to improve this, approach upstream about it (they say "First off, thank you very much! If I can do anything to make packaging Intermodal easier, please don't hesistate to open an issue." in the repo upstream and provide a lot of useful info in the readme already), improve the situation upstream and then use the improved tooling in a package here.

I have still extended the package a tiny bit to ship shell completions, because this is the part that bugged me the most, and doing so was fairly straight forward using our vtargetrun helper. I've cargo-culted those bits from our rustup package, I hope this is the right way to go?

cc @casey (upstream) and @ThatNerdyPikachu (void contributor for this package)

A patch file from https://github.com/void-linux/void-packages/pull/35082.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-intermodal-0.1.12_1-35082.patch --]
[-- Type: text/x-diff, Size: 1497 bytes --]

From ca99c1cb27a418746c2b19927eba3456481c874a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 16 Jan 2022 13:12:25 +0100
Subject: [PATCH] intermodal: update to 0.1.12.

---
 srcpkgs/intermodal/template | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/intermodal/template b/srcpkgs/intermodal/template
index bb0e6148ad02..f4180bd33998 100644
--- a/srcpkgs/intermodal/template
+++ b/srcpkgs/intermodal/template
@@ -1,11 +1,27 @@
 # Template file for 'intermodal'
 pkgname=intermodal
-version=0.1.10
+version=0.1.12
 revision=1
 build_style=cargo
+build_helper=qemu
+make_check_args="-- --skip subcommand::torrent::verify::tests::output_multiple --skip subcommand::torrent::verify::tests::output_color"
 short_desc="User-friendly and featureful command-line BitTorrent metainfo utility"
 maintainer="Pika <pika@lasagna.dev>"
 license="CC0-1.0"
 homepage="https://github.com/casey/intermodal"
 distfiles="https://github.com/casey/intermodal/archive/v${version}.tar.gz"
-checksum=8bb3e4f549e5c4446543babd741fec0cd7c42da4d49eca3e98c5f7611ad59618
+checksum=cd62894e519dc5aa0284a5f48aab86e1a45c3bc96b8a5481741adb6960d4751a
+
+post_build() {
+	IMDL="target/${RUST_TARGET}/release/imdl"
+
+	for shell in zsh bash fish; do
+		vtargetrun $IMDL completions ${shell} >imdl.${shell}
+	done
+}
+
+post_install() {
+	for shell in zsh bash fish; do
+		vcompletion imdl.${shell} ${shell}
+	done
+}

  parent reply	other threads:[~2022-01-18 13:33 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-16 12:39 [PR PATCH] " jcgruenhage
2022-01-17 12:58 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-18 13:20 ` [PR REVIEW] " ahesford
2022-01-18 13:21 ` ahesford
2022-01-18 13:31 ` jcgruenhage
2022-01-18 13:31 ` ahesford
2022-01-18 13:33 ` jcgruenhage [this message]
2022-01-18 13:42 ` jcgruenhage
2022-01-18 13:52 ` Johnnynator
2022-01-18 13:53 ` Johnnynator
2022-01-18 14:42 ` ahesford
2022-01-18 14:49 ` jcgruenhage
2022-01-18 15:17 ` ahesford
2022-01-25 10:28 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-25 10:30 ` jcgruenhage
2022-01-25 10:56 ` jcgruenhage
2022-01-25 11:03 ` jcgruenhage
2022-01-25 11:31 ` [PR PATCH] [Updated] " jcgruenhage
2022-01-26 19:21 ` jcgruenhage
2022-01-26 19:38 ` [PR PATCH] [Closed]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220118133353.jiBIGB4SjcoOVe-Ob3OfuccMPOuvz6fZ072sEhfUN0Y@z \
    --to=jcgruenhage@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).