* Re: [PR REVIEW] python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
@ 2022-01-20 0:59 ` paper42
2022-01-20 6:55 ` hamlolum
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2022-01-20 0:59 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#discussion_r788265913
Comment:
```suggestion
homepage="https://github.com/PyMySQL/mysqlclient"
changelog="https://raw.githubusercontent.com/PyMySQL/mysqlclient/main/HISTORY.rst"
distfiles="https://github.com/PyMySQL/mysqlclient/archive/refs/tags/v${version}.tar.gz"
```
why did you decide to switch to a github tarball?
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
2022-01-20 0:59 ` [PR REVIEW] " paper42
@ 2022-01-20 6:55 ` hamlolum
2022-01-20 6:56 ` [PR PATCH] [Updated] " hamlolum
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: hamlolum @ 2022-01-20 6:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 166 bytes --]
New review comment by hamlolum on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#discussion_r788412496
Comment:
It seemed neater.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
2022-01-20 0:59 ` [PR REVIEW] " paper42
2022-01-20 6:55 ` hamlolum
@ 2022-01-20 6:56 ` hamlolum
2022-01-20 6:57 ` [PR REVIEW] " hamlolum
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: hamlolum @ 2022-01-20 6:56 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
There is an updated pull request by hamlolum against master on the void-packages repository
https://github.com/hamlolum/void-packages mysqlclient
https://github.com/void-linux/void-packages/pull/35062
python3-mysqlclient: update to 2.1.0.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/35062.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mysqlclient-35062.patch --]
[-- Type: text/x-diff, Size: 1433 bytes --]
From f8192e25ddf71ab56e0bb5d9be1908eaf6b8de87 Mon Sep 17 00:00:00 2001
From: hamlolum <hamlolum@tilde.club>
Date: Sat, 15 Jan 2022 16:03:41 +0530
Subject: [PATCH] python3-mysqlclient: update to 2.1.0.
---
srcpkgs/python3-mysqlclient/template | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/python3-mysqlclient/template b/srcpkgs/python3-mysqlclient/template
index 696dddf7f595..026d54365a7c 100644
--- a/srcpkgs/python3-mysqlclient/template
+++ b/srcpkgs/python3-mysqlclient/template
@@ -1,7 +1,7 @@
# Template file for 'python3-mysqlclient'
pkgname=python3-mysqlclient
-version=1.3.14
-revision=8
+version=2.1.0
+revision=1
wrksrc="mysqlclient-${version}"
build_style=python3-module
hostmakedepends="python3-setuptools"
@@ -10,6 +10,7 @@ depends="python3"
short_desc="Python3 interface to MySQL/MariaDB"
maintainer="Alin Dobre <alin.dobre@outlook.com>"
license="GPL-2.0-or-later"
-homepage="https://github.com/PyMySQL/mysqlclient-python"
-distfiles="${PYPI_SITE}/m/mysqlclient/mysqlclient-${version}.tar.gz"
-checksum=3981ae9ce545901a36a8b7aed76ed02960a429f75dc53b7ad77fb2f9ab7cd56b
+homepage="https://github.com/PyMySQL/mysqlclient"
+changelog="https://raw.githubusercontent.com/PyMySQL/mysqlclient/main/HISTORY.rst"
+distfiles="https://github.com/PyMySQL/mysqlclient/archive/refs/tags/v${version}.tar.gz"
+checksum=b202e33d06ac87d400091b61346c90798a77432e2ea4ac6441eed4d4106832a7
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (2 preceding siblings ...)
2022-01-20 6:56 ` [PR PATCH] [Updated] " hamlolum
@ 2022-01-20 6:57 ` hamlolum
2022-01-20 7:02 ` hamlolum
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: hamlolum @ 2022-01-20 6:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
New review comment by hamlolum on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#discussion_r788412496
Comment:
It seemed neater. Also, I have added the changelog line.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (3 preceding siblings ...)
2022-01-20 6:57 ` [PR REVIEW] " hamlolum
@ 2022-01-20 7:02 ` hamlolum
2022-01-20 7:48 ` [PR PATCH] [Updated] " hamlolum
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: hamlolum @ 2022-01-20 7:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 216 bytes --]
New comment by hamlolum on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#issuecomment-1017175980
Comment:
I have been using v2.1.0 for the past couple of weeks and it works fine.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (4 preceding siblings ...)
2022-01-20 7:02 ` hamlolum
@ 2022-01-20 7:48 ` hamlolum
2022-01-20 9:19 ` [PR REVIEW] " paper42
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: hamlolum @ 2022-01-20 7:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
There is an updated pull request by hamlolum against master on the void-packages repository
https://github.com/hamlolum/void-packages mysqlclient
https://github.com/void-linux/void-packages/pull/35062
python3-mysqlclient: update to 2.1.0.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/35062.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mysqlclient-35062.patch --]
[-- Type: text/x-diff, Size: 1433 bytes --]
From 13c7844ca85f6fb4de4eeeb18c05a9dda4b7c707 Mon Sep 17 00:00:00 2001
From: hamlolum <hamlolum@tilde.club>
Date: Sat, 15 Jan 2022 16:03:41 +0530
Subject: [PATCH] python3-mysqlclient: update to 2.1.0.
---
srcpkgs/python3-mysqlclient/template | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/python3-mysqlclient/template b/srcpkgs/python3-mysqlclient/template
index 696dddf7f595..026d54365a7c 100644
--- a/srcpkgs/python3-mysqlclient/template
+++ b/srcpkgs/python3-mysqlclient/template
@@ -1,7 +1,7 @@
# Template file for 'python3-mysqlclient'
pkgname=python3-mysqlclient
-version=1.3.14
-revision=8
+version=2.1.0
+revision=1
wrksrc="mysqlclient-${version}"
build_style=python3-module
hostmakedepends="python3-setuptools"
@@ -10,6 +10,7 @@ depends="python3"
short_desc="Python3 interface to MySQL/MariaDB"
maintainer="Alin Dobre <alin.dobre@outlook.com>"
license="GPL-2.0-or-later"
-homepage="https://github.com/PyMySQL/mysqlclient-python"
-distfiles="${PYPI_SITE}/m/mysqlclient/mysqlclient-${version}.tar.gz"
-checksum=3981ae9ce545901a36a8b7aed76ed02960a429f75dc53b7ad77fb2f9ab7cd56b
+homepage="https://github.com/PyMySQL/mysqlclient"
+changelog="https://raw.githubusercontent.com/PyMySQL/mysqlclient/main/HISTORY.rst"
+distfiles="https://github.com/PyMySQL/mysqlclient/archive/refs/tags/v${version}.tar.gz"
+checksum=b202e33d06ac87d400091b61346c90798a77432e2ea4ac6441eed4d4106832a7
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (5 preceding siblings ...)
2022-01-20 7:48 ` [PR PATCH] [Updated] " hamlolum
@ 2022-01-20 9:19 ` paper42
2022-01-20 9:23 ` paper42
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2022-01-20 9:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 254 bytes --]
New review comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#discussion_r788552408
Comment:
If it isn't objectively better (for example containing tests), I think we should just use the pypi tarball.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (6 preceding siblings ...)
2022-01-20 9:19 ` [PR REVIEW] " paper42
@ 2022-01-20 9:23 ` paper42
2022-01-20 9:32 ` Johnnynator
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: paper42 @ 2022-01-20 9:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 400 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#issuecomment-1017273112
Comment:
> I have been using v2.1.0 for the past couple of weeks and it works fine.
This is a library used by soci in the repositories, so we should test this. But I noticed the source code doesn't even mention python3-mysqlclient, is this a mistake? @Johnnynator
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (7 preceding siblings ...)
2022-01-20 9:23 ` paper42
@ 2022-01-20 9:32 ` Johnnynator
2022-01-20 11:02 ` [PR PATCH] [Updated] " hamlolum
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: Johnnynator @ 2022-01-20 9:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 615 bytes --]
New comment by Johnnynator on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#issuecomment-1017280970
Comment:
> > I have been using v2.1.0 for the past couple of weeks and it works fine.
>
> This is a library used by soci in the repositories, so we should test this. But I noticed the source code doesn't even mention python3-mysqlclient, is this a mistake? @Johnnynator
Can be ignored, since soci tests can't be run without a complicated setup, it was needed during checks for some script or by some script provided by mariadb. I can't remember the exact reason right now.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Updated] python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (8 preceding siblings ...)
2022-01-20 9:32 ` Johnnynator
@ 2022-01-20 11:02 ` hamlolum
2022-01-20 11:03 ` [PR REVIEW] " hamlolum
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: hamlolum @ 2022-01-20 11:02 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
There is an updated pull request by hamlolum against master on the void-packages repository
https://github.com/hamlolum/void-packages mysqlclient
https://github.com/void-linux/void-packages/pull/35062
python3-mysqlclient: update to 2.1.0.
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
A patch file from https://github.com/void-linux/void-packages/pull/35062.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mysqlclient-35062.patch --]
[-- Type: text/x-diff, Size: 1341 bytes --]
From eb097f93521d7245b68bdc101de6eed586ef64ed Mon Sep 17 00:00:00 2001
From: hamlolum <hamlolum@tilde.club>
Date: Sat, 15 Jan 2022 16:03:41 +0530
Subject: [PATCH] python3-mysqlclient: update to 2.1.0.
---
srcpkgs/python3-mysqlclient/template | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/python3-mysqlclient/template b/srcpkgs/python3-mysqlclient/template
index 696dddf7f595..ebd8bbf069be 100644
--- a/srcpkgs/python3-mysqlclient/template
+++ b/srcpkgs/python3-mysqlclient/template
@@ -1,7 +1,7 @@
# Template file for 'python3-mysqlclient'
pkgname=python3-mysqlclient
-version=1.3.14
-revision=8
+version=2.1.0
+revision=1
wrksrc="mysqlclient-${version}"
build_style=python3-module
hostmakedepends="python3-setuptools"
@@ -10,6 +10,7 @@ depends="python3"
short_desc="Python3 interface to MySQL/MariaDB"
maintainer="Alin Dobre <alin.dobre@outlook.com>"
license="GPL-2.0-or-later"
-homepage="https://github.com/PyMySQL/mysqlclient-python"
+homepage="https://github.com/PyMySQL/mysqlclient"
+changelog="https://raw.githubusercontent.com/PyMySQL/mysqlclient/main/HISTORY.rst"
distfiles="${PYPI_SITE}/m/mysqlclient/mysqlclient-${version}.tar.gz"
-checksum=3981ae9ce545901a36a8b7aed76ed02960a429f75dc53b7ad77fb2f9ab7cd56b
+checksum=973235686f1b720536d417bf0a0d39b4ab3d5086b2b6ad5e6752393428c02b12
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR REVIEW] python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (9 preceding siblings ...)
2022-01-20 11:02 ` [PR PATCH] [Updated] " hamlolum
@ 2022-01-20 11:03 ` hamlolum
2022-06-22 2:14 ` github-actions
2022-07-07 2:14 ` [PR PATCH] [Closed]: " github-actions
12 siblings, 0 replies; 14+ messages in thread
From: hamlolum @ 2022-01-20 11:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
New review comment by hamlolum on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#discussion_r788653535
Comment:
I have changed it back to the pypi tarball.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (10 preceding siblings ...)
2022-01-20 11:03 ` [PR REVIEW] " hamlolum
@ 2022-06-22 2:14 ` github-actions
2022-07-07 2:14 ` [PR PATCH] [Closed]: " github-actions
12 siblings, 0 replies; 14+ messages in thread
From: github-actions @ 2022-06-22 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/35062#issuecomment-1162546776
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PR PATCH] [Closed]: python3-mysqlclient: update to 2.1.0.
2022-01-15 10:35 [PR PATCH] python3-mysqlclient: update to 2.1.0 hamlolum
` (11 preceding siblings ...)
2022-06-22 2:14 ` github-actions
@ 2022-07-07 2:14 ` github-actions
12 siblings, 0 replies; 14+ messages in thread
From: github-actions @ 2022-07-07 2:14 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 343 bytes --]
There's a closed pull request on the void-packages repository
python3-mysqlclient: update to 2.1.0.
https://github.com/void-linux/void-packages/pull/35062
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, x86_64-glibc
^ permalink raw reply [flat|nested] 14+ messages in thread