Re: [PR PATCH] [Updated] lynis: update to 3.0.7.

Re: [PR PATCH] [Updated] lynis: update to 3.0.7.

[jhe2]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

There is an updated pull request by jhe2 against master on the void-packages repository

https://github.com/jhe2/void-packages lynis
https://github.com/void-linux/void-packages/pull/35119

lynis: update to 3.0.7.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lynis-35119.patch --]
[-- Type: text/x-diff, Size: 1381 bytes --]

From 048a9ea67e4f508910ba19c6a683b84c001f0cb7 Mon Sep 17 00:00:00 2001
From: Johannes Heimansberg <git@jhe.dedyn.io>
Date: Wed, 19 Jan 2022 08:13:53 +0100
Subject: [PATCH] lynis: update to 3.0.7.

---
 srcpkgs/lynis/template | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/lynis/template b/srcpkgs/lynis/template
index 17940cdf5138..a48651863d35 100644
--- a/srcpkgs/lynis/template
+++ b/srcpkgs/lynis/template
@@ -1,13 +1,14 @@
 # Template file for 'lynis'
 pkgname=lynis
-version=3.0.6
+version=3.0.7
 revision=1
 short_desc="System and security auditing tool"
 maintainer="Johannes Heimansberg <git@jhe.dedyn.io>"
 license="GPL-3.0-only"
 homepage="https://cisofy.com/lynis/"
+changelog="https://raw.githubusercontent.com/CISOfy/lynis/master/CHANGELOG.md"
 distfiles="https://github.com/CISOfy/lynis/archive/refs/tags/${version}.tar.gz"
-checksum=584ed6f6fa9dedeea1b473d888a4fe92fa9716400284fe41c92aed09cf10ec3e
+checksum=13cedb14b17f0fff6c0ae7cdcc0550a887975bb3da4db96b47b2caf41c1c143b
 
 do_install() {
 	vmkdir etc/lynis
@@ -19,9 +20,7 @@ do_install() {
 	vbin lynis
 	vman lynis.8
 	vmkdir usr/share/doc/lynis
-	vinstall CHANGELOG.md 0644 usr/share/doc/lynis
 	vinstall FAQ 0644 usr/share/doc/lynis
-	vinstall INSTALL 0644 usr/share/doc/lynis
 	vinstall README 0644 usr/share/doc/lynis
 	vcompletion extras/bash_completion.d/lynis bash
 }

Re: [PR PATCH] [Updated] lynis: update to 3.0.7.

[jhe2]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

There is an updated pull request by jhe2 against master on the void-packages repository

https://github.com/jhe2/void-packages lynis
https://github.com/void-linux/void-packages/pull/35119

lynis: update to 3.0.7.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lynis-35119.patch --]
[-- Type: text/x-diff, Size: 1382 bytes --]

From 72e3beffd326f89dfd8e4fec9a519f7ea07aa8c9 Mon Sep 17 00:00:00 2001
From: Johannes Heimansberg <git@jhe.dedyn.io>
Date: Wed, 19 Jan 2022 08:13:53 +0100
Subject: [PATCH] lynis: update to 3.0.7.

---
 srcpkgs/lynis/template | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/lynis/template b/srcpkgs/lynis/template
index 17940cdf5138..054f3a60efe7 100644
--- a/srcpkgs/lynis/template
+++ b/srcpkgs/lynis/template
@@ -1,13 +1,14 @@
 # Template file for 'lynis'
 pkgname=lynis
-version=3.0.6
+version=3.0.7
 revision=1
 short_desc="System and security auditing tool"
 maintainer="Johannes Heimansberg <git@jhe.dedyn.io>"
 license="GPL-3.0-only"
 homepage="https://cisofy.com/lynis/"
+changelog="https://raw.githubusercontent.com/CISOfy/lynis/master/CHANGELOG.md"
 distfiles="https://github.com/CISOfy/lynis/archive/refs/tags/${version}.tar.gz"
-checksum=584ed6f6fa9dedeea1b473d888a4fe92fa9716400284fe41c92aed09cf10ec3e
+checksum=13cedb14b17f0fff6c0ae7cdcc0550a887975bb3da4db96b47b2caf41c1c143b
 
 do_install() {
 	vmkdir etc/lynis
@@ -19,9 +20,6 @@ do_install() {
 	vbin lynis
 	vman lynis.8
 	vmkdir usr/share/doc/lynis
-	vinstall CHANGELOG.md 0644 usr/share/doc/lynis
 	vinstall FAQ 0644 usr/share/doc/lynis
-	vinstall INSTALL 0644 usr/share/doc/lynis
-	vinstall README 0644 usr/share/doc/lynis
 	vcompletion extras/bash_completion.d/lynis bash
 }

Re: lynis: update to 3.0.7.

[jhe2]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

New comment by jhe2 on void-packages repository

https://github.com/void-linux/void-packages/pull/35119#issuecomment-1017160379

Comment:
> * add `$changelog`
> 
>     * all the vinstalls to usr/share/doc/ seem useless to me (maybe except for FAQ), what would you think about removing them?

I have added the changelog URL and removed the ``INSTALL``, ``README``  and ``CHANGELOG.md`` files from ``/usr/share/doc/lynis``, but kept ``FAQ``.

I've noticed that other packages sometimes also contain CHANGELOG files in their ``/usr/share/doc`` directories. Is it generally discouraged to include them there?

Re: [PR REVIEW] lynis: update to 3.0.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 176 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35119#discussion_r788558337

Comment:
```suggestion
	vdoc FAQ
```

Re: [PR REVIEW] lynis: update to 3.0.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35119#discussion_r788557809

Comment:
```suggestion
```

Re: lynis: update to 3.0.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35119#issuecomment-1017277451

Comment:
> > * add `$changelog`
> >   
> >   * all the vinstalls to usr/share/doc/ seem useless to me (maybe except for FAQ), what would you think about removing them?
> 
> I have added the changelog URL and removed the `INSTALL`, `README` and `CHANGELOG.md` files from `/usr/share/doc/lynis`, but kept `FAQ`.
> 
> I've noticed that other packages sometimes also contain CHANGELOG files in their `/usr/share/doc` directories. Is it generally discouraged to include them there?

From what I can see, CHANGELOG is explicitly included only in 4 packages (durden fingerprint-gui go-ipfs hunspell-it_IT). I don't think it's necessary to include a changelog, it doesn't add any value to the documentation and people can check it online if they really want to.

Re: [PR PATCH] [Updated] lynis: update to 3.0.7.

[jhe2]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

There is an updated pull request by jhe2 against master on the void-packages repository

https://github.com/jhe2/void-packages lynis
https://github.com/void-linux/void-packages/pull/35119

lynis: update to 3.0.7.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35119.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lynis-35119.patch --]
[-- Type: text/x-diff, Size: 1426 bytes --]

From f311d44d7a38a2bce525446f4e51f8f51bb55803 Mon Sep 17 00:00:00 2001
From: Johannes Heimansberg <git@jhe.dedyn.io>
Date: Wed, 19 Jan 2022 08:13:53 +0100
Subject: [PATCH] lynis: update to 3.0.7.

---
 srcpkgs/lynis/template | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/srcpkgs/lynis/template b/srcpkgs/lynis/template
index 17940cdf5138..62d8b59046c8 100644
--- a/srcpkgs/lynis/template
+++ b/srcpkgs/lynis/template
@@ -1,13 +1,14 @@
 # Template file for 'lynis'
 pkgname=lynis
-version=3.0.6
+version=3.0.7
 revision=1
 short_desc="System and security auditing tool"
 maintainer="Johannes Heimansberg <git@jhe.dedyn.io>"
 license="GPL-3.0-only"
 homepage="https://cisofy.com/lynis/"
+changelog="https://raw.githubusercontent.com/CISOfy/lynis/master/CHANGELOG.md"
 distfiles="https://github.com/CISOfy/lynis/archive/refs/tags/${version}.tar.gz"
-checksum=584ed6f6fa9dedeea1b473d888a4fe92fa9716400284fe41c92aed09cf10ec3e
+checksum=13cedb14b17f0fff6c0ae7cdcc0550a887975bb3da4db96b47b2caf41c1c143b
 
 do_install() {
 	vmkdir etc/lynis
@@ -18,10 +19,6 @@ do_install() {
 	vcopy db usr/share/lynis/
 	vbin lynis
 	vman lynis.8
-	vmkdir usr/share/doc/lynis
-	vinstall CHANGELOG.md 0644 usr/share/doc/lynis
-	vinstall FAQ 0644 usr/share/doc/lynis
-	vinstall INSTALL 0644 usr/share/doc/lynis
-	vinstall README 0644 usr/share/doc/lynis
+	vdoc FAQ
 	vcompletion extras/bash_completion.d/lynis bash
 }

Re: lynis: update to 3.0.7.

[jhe2]

[-- Attachment #1: Type: text/plain, Size: 845 bytes --]

New comment by jhe2 on void-packages repository

https://github.com/void-linux/void-packages/pull/35119#issuecomment-1017303485

Comment:
> From what I can see, CHANGELOG is explicitly included only in 4 packages (durden fingerprint-gui go-ipfs hunspell-it_IT). I don't think it's necessary to include a changelog, it doesn't add any value to the documentation and people can check it online if they really want to.

Of the packages installed on my system, the ``inxi`` package also comes with a changelog, so does ``flac`` (although in case of flac it appears to be installed implicitly).
I actually like not having to look online for things like that, but I'm all for consistency, so if such files are not supposed to be included, that's fine. I guess it is not of much use, if only some packages include a CHANGELOG files and other don't.

Re: [PR PATCH] [Merged]: lynis: update to 3.0.7.

[paper42]

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

There's a merged pull request on the void-packages repository

lynis: update to 3.0.7.
https://github.com/void-linux/void-packages/pull/35119

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->