Github messages for voidlinux
 help / color / mirror / Atom feed
From: 0323pin <0323pin@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: ncspot-0.9.4
Date: Thu, 20 Jan 2022 14:41:14 +0100	[thread overview]
Message-ID: <20220120134114.QEbBltVx7K4oQKG21PkB4reuCmfFc7kNuvmRYhoIowM@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-33600@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1426 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/33600#issuecomment-1017500838

Comment:
@ram02z Yes but, I can confirm that the patch provide, https://github.com/hrkfdn/ncspot/issues/714#issuecomment-1016409615

allows the build to succeed with rust-1.57.0
I've merged the package on NetBSD yesterday, https://mail-index.netbsd.org/pkgsrc-changes/2022/01/19/msg247190.html

**EDIT:**
```
$NetBSD: patch-src_ui_listview.rs,v 1.1 2022/01/19 14:04:45 pin Exp $

Fix build with rust =< 1.58.0
Patch provided by upstream

--- src/ui/listview.rs.orig    2022-01-18 21:10:09.000000000 +0000
+++ src/ui/listview.rs
@@ -85,7 +85,7 @@ impl<I: ListItem> ListView<I> {
 
     pub fn content_height_with_paginator(&self) -> usize {
         let content_len = self.content.read().unwrap().len();
-        log::info!("content len: {content_len}");
+        log::info!("content len: {}", content_len);
 
         // add 1 more row for paginator if we can paginate
         if self.can_paginate() {
@@ -97,7 +97,7 @@ impl<I: ListItem> ListView<I> {
 
     fn can_paginate(&self) -> bool {
         let loaded = self.get_pagination().loaded_content();
-        log::info!("can paginate: {loaded}");
+        log::info!("can paginate: {}", loaded);
         self.get_pagination().max_content().unwrap_or(0) > self.get_pagination().loaded_content()
     }
```


  parent reply	other threads:[~2022-01-20 13:41 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-17  9:42 [PR PATCH] New package: ncspot-0.9.0 ram02z
2021-10-17 12:36 ` [PR PATCH] [Updated] " ram02z
2021-10-29  2:04 ` [PR REVIEW] " abenson
2021-10-29 10:13 ` [PR PATCH] [Updated] " ram02z
2021-10-30  9:49 ` ram02z
2021-11-30  0:43 ` ram02z
2021-12-12  1:39 ` pfr-dev
2021-12-15  7:13 ` 0323pin
2022-01-04 18:40 ` [PR PATCH] [Updated] " ram02z
2022-01-05  0:46 ` New package: ncspot-0.9.4 ram02z
2022-01-20 12:12 ` ram02z
2022-01-20 13:23 ` 0323pin
2022-01-20 13:41 ` 0323pin [this message]
2022-01-20 13:42 ` ram02z
2022-01-20 13:50 ` 0323pin
2022-02-19 12:40 ` [PR PATCH] [Updated] " ram02z
2022-03-10 10:36 ` [PR PATCH] [Updated] New package: ncspot-0.9.5 ram02z
2022-03-10 12:30 ` New package: ncspot-0.9.6 ram02z
2022-03-28 14:22 ` [PR PATCH] [Updated] " ram02z
2022-03-28 14:23 ` ram02z
2022-04-05  9:51 ` pfr-dev
2022-04-05  9:53 ` pfr-dev
2022-04-05  9:53 ` pfr-dev
2022-04-05  9:53 ` pfr-dev
2022-04-05 20:18 ` New package: ncspot-0.9.7 abenson
2022-05-26 10:02 ` [PR PATCH] [Updated] " ram02z
2022-05-26 10:03 ` [PR PATCH] [Updated] New package: ncspot-0.9.8 ram02z
2022-06-11 15:13 ` ram02z
2022-07-01  3:55 ` New package: ncspot-0.10.0 wael444
2022-09-19 21:44 ` [PR PATCH] [Updated] " ram02z
2022-09-19 21:46 ` [PR PATCH] [Updated] New package: ncspot-0.11.1 ram02z
2022-12-19  1:54 ` github-actions
2022-12-19  1:56 ` ram02z
2022-12-19  1:56 ` ram02z
2022-12-28  9:56 ` [PR REVIEW] " classabbyamp
2022-12-28 10:23 ` 0323pin
2022-12-28 10:38 ` classabbyamp
2022-12-28 12:13 ` 0323pin
2023-01-16 13:42 ` [PR PATCH] [Updated] " ram02z
2023-01-16 13:44 ` [PR REVIEW] " ram02z
2023-01-16 13:44 ` ram02z
2023-01-16 13:44 ` [PR PATCH] [Updated] " ram02z
2023-01-16 15:03 ` [PR REVIEW] New package: ncspot-0.11.2 wael444
2023-01-16 16:42 ` classabbyamp
2023-01-16 16:43 ` [PR PATCH] [Updated] " ram02z
2023-01-16 16:43 ` [PR REVIEW] " classabbyamp
2023-01-16 16:43 ` ram02z
2023-01-16 16:45 ` classabbyamp
2023-01-16 16:46 ` ram02z
2023-01-16 16:47 ` classabbyamp
2023-01-16 16:47 ` 0323pin
2023-01-16 16:56 ` paper42
2023-01-16 17:03 ` 0323pin
2023-01-16 17:22 ` 0323pin
2023-01-16 17:57 ` paper42
2023-01-16 18:15 ` 0323pin
2023-01-16 18:15 ` 0323pin
2023-01-17 17:05 ` [PR PATCH] [Updated] " ram02z
2023-01-17 17:10 ` ram02z
2023-01-17 17:38 ` [PR REVIEW] " ram02z
2023-01-17 17:50 ` [PR PATCH] [Merged]: " classabbyamp
2023-01-17 20:19 ` atweiden
2023-01-17 20:28 ` classabbyamp
2023-01-17 20:41 ` classabbyamp
2023-01-17 21:11 ` 0323pin
2023-01-17 21:13 ` classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220120134114.QEbBltVx7K4oQKG21PkB4reuCmfFc7kNuvmRYhoIowM@z \
    --to=0323pin@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).