[PR PATCH] Adding manpages to fvwm3

[PR PATCH] Adding manpages to fvwm3

[tgaudin]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is a new pull request by tgaudin against master on the void-packages repository

https://github.com/tgaudin/void-packages master
https://github.com/void-linux/void-packages/pull/35165

Adding manpages to fvwm3
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)


A patch file from https://github.com/void-linux/void-packages/pull/35165.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-35165.patch --]
[-- Type: text/x-diff, Size: 929 bytes --]

From 8ff797d17652cc686ab330e013a9239ac7a36a68 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9ophile=20Gaudin?= <theophile.gaudin@gmail.com>
Date: Fri, 21 Jan 2022 22:25:49 +0100
Subject: [PATCH] Adding manpages to fvwm3

---
 srcpkgs/fvwm3/template | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/fvwm3/template b/srcpkgs/fvwm3/template
index 0293e5ecb600..18eefa0693eb 100644
--- a/srcpkgs/fvwm3/template
+++ b/srcpkgs/fvwm3/template
@@ -4,7 +4,8 @@ version=1.0.4
 revision=1
 build_style=gnu-configure
 hostmakedepends="pkg-config automake"
-makedepends="libXrandr-devel libbson-devel libevent-devel libXt-devel
+configure_args=--enable-mandoc
+makedepends="ruby-asciidoctor libXrandr-devel libbson-devel libevent-devel libXt-devel
  libpng-devel fribidi-devel libXft-devel libXcursor-devel libXpm-devel
  fribidi-devel librsvg-devel"
 short_desc="Multiple large virtual desktop window manager"

Re: fvwm3: adding manpages

[abenson]

[-- Attachment #1: Type: text/plain, Size: 415 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#issuecomment-1018878519

Comment:
Please follow [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md) for the commit message.  `revision` also needs to be bumped to 2.

Don't close this PR, just `git commit --amend` edit the message, save/quit, and then `git push -f`.

Re: [PR REVIEW] fvwm3: adding manpages

[abenson]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#discussion_r790008754

Comment:
Quote this just to be consistent.

Re: [PR PATCH] [Updated] fvwm3: adding manpages

[tgaudin]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by tgaudin against master on the void-packages repository

https://github.com/tgaudin/void-packages master
https://github.com/void-linux/void-packages/pull/35165

fvwm3: adding manpages
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/35165.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-35165.patch --]
[-- Type: text/x-diff, Size: 991 bytes --]

From 9a30b62ab228c018aa8feaac97f0af7bb6082d6b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9ophile=20Gaudin?= <theophile.gaudin@gmail.com>
Date: Fri, 21 Jan 2022 22:25:49 +0100
Subject: [PATCH] fvwm3: adding manpages

---
 srcpkgs/fvwm3/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/fvwm3/template b/srcpkgs/fvwm3/template
index 0293e5ecb600..4a4d12623f7f 100644
--- a/srcpkgs/fvwm3/template
+++ b/srcpkgs/fvwm3/template
@@ -1,10 +1,11 @@
 # Template file for 'fvwm3'
 pkgname=fvwm3
 version=1.0.4
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="pkg-config automake"
-makedepends="libXrandr-devel libbson-devel libevent-devel libXt-devel
+configure_args="--enable-mandoc"
+makedepends="ruby-asciidoctor libXrandr-devel libbson-devel libevent-devel libXt-devel
  libpng-devel fribidi-devel libXft-devel libXcursor-devel libXpm-devel
  fribidi-devel librsvg-devel"
 short_desc="Multiple large virtual desktop window manager"

Re: [PR REVIEW] fvwm3: adding manpages

[abenson]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

New review comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#discussion_r790037415

Comment:
Whoops, I missed this, move it above `hostmakedepends` then it should be good!

Re: [PR PATCH] [Updated] fvwm3: adding manpages

[tgaudin]

[-- Attachment #1: Type: text/plain, Size: 479 bytes --]

There is an updated pull request by tgaudin against master on the void-packages repository

https://github.com/tgaudin/void-packages master
https://github.com/void-linux/void-packages/pull/35165

fvwm3: adding manpages
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)


A patch file from https://github.com/void-linux/void-packages/pull/35165.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-35165.patch --]
[-- Type: text/x-diff, Size: 991 bytes --]

From 9a30b62ab228c018aa8feaac97f0af7bb6082d6b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Th=C3=A9ophile=20Gaudin?= <theophile.gaudin@gmail.com>
Date: Fri, 21 Jan 2022 22:25:49 +0100
Subject: [PATCH] fvwm3: adding manpages

---
 srcpkgs/fvwm3/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/fvwm3/template b/srcpkgs/fvwm3/template
index 0293e5ecb600..4a4d12623f7f 100644
--- a/srcpkgs/fvwm3/template
+++ b/srcpkgs/fvwm3/template
@@ -1,10 +1,11 @@
 # Template file for 'fvwm3'
 pkgname=fvwm3
 version=1.0.4
-revision=1
+revision=2
 build_style=gnu-configure
 hostmakedepends="pkg-config automake"
-makedepends="libXrandr-devel libbson-devel libevent-devel libXt-devel
+configure_args="--enable-mandoc"
+makedepends="ruby-asciidoctor libXrandr-devel libbson-devel libevent-devel libXt-devel
  libpng-devel fribidi-devel libXft-devel libXcursor-devel libXpm-devel
  fribidi-devel librsvg-devel"
 short_desc="Multiple large virtual desktop window manager"

Re: fvwm3: adding manpages

[paper42]

[-- Attachment #1: Type: text/plain, Size: 213 bytes --]

New comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#issuecomment-1018919806

Comment:
could you add the email you used for the commit to your github profile?

Re: fvwm3: adding manpages

[tgaudin]

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

New comment by tgaudin on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#issuecomment-1018921150

Comment:
Yes, that's done!

Re: [PR PATCH] [Merged]: fvwm3: adding manpages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

There's a merged pull request on the void-packages repository

fvwm3: adding manpages
https://github.com/void-linux/void-packages/pull/35165

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

Re: fvwm3: adding manpages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#issuecomment-1023959222

Comment:
This should have been in hostmakedeps, actually :/

Re: fvwm3: adding manpages

[tgaudin]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

New comment by tgaudin on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#issuecomment-1024921113

Comment:
> This should have been in hostmakedeps, actually :/

Not sure I understand that. Should I move asciidoc to hostmakedeps? If yes, do you want me to create a new pull request, bump the pkg version and so on?

Re: fvwm3: adding manpages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 280 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#issuecomment-1026879959

Comment:
I fixed it in https://github.com/void-linux/void-packages/commit/86f9bbe105e5ced5ccbbed1543110b9d5b8f9c83

It doesn't require a pkg bump

Re: fvwm3: adding manpages

[ericonr]

[-- Attachment #1: Type: text/plain, Size: 168 bytes --]

New comment by ericonr on void-packages repository

https://github.com/void-linux/void-packages/pull/35165#issuecomment-1026880236

Comment:
But thanks for offering c: