Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] geonkick: update to 2.8.1.
Date: Thu, 27 Jan 2022 18:42:11 +0100	[thread overview]
Message-ID: <20220127174211.zshLRgUaUKoAJJMBAuWUzLMG6B1pV6_bmHYdRpH7r1Y@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35254@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

New review comment by paper42 on void-packages repository

https://github.com/void-linux/void-packages/pull/35254#discussion_r793853257

Comment:
```suggestion
if ! [ ${XBPS_TARGET_MACHINE} = "x86_64" ]; then
```

but on aarch64 systems, it will default to aarch64, so this doesn't really make sense for native compilation, so
a) change this to run only when cross compiling and trust them to detect the architecture correctly
b) set it in configure_args every the time

  reply	other threads:[~2022-01-27 17:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-26 21:42 [PR PATCH] " teldra
2022-01-27 17:42 ` paper42 [this message]
2022-01-28 12:18 ` [PR REVIEW] " paper42
2022-02-06  0:03 ` [PR PATCH] [Updated] " teldra
2022-02-06  0:34 ` teldra
2022-02-06 19:15 ` paper42
2022-02-06 21:04 ` [PR PATCH] [Updated] " teldra
2022-02-10  0:14 ` [PR PATCH] [Merged]: " paper42

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220127174211.zshLRgUaUKoAJJMBAuWUzLMG6B1pV6_bmHYdRpH7r1Y@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).