Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [RFC] New package: sagelib-9.5
Date: Tue, 01 Feb 2022 13:58:31 +0100	[thread overview]
Message-ID: <20220201125831.LaQGVcrGwLuqi6a8cRw5z-BmUGO5TTbk095or8GSkOs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35339@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/35339#issuecomment-1026815018

Comment:
> For some reason, I struggle to pick up this kernel in jupyterlab. I wonder if we need something similar to what Arch has
> 
> ```
> # fix symlinks to assets
>   _pythonpath=`python -c "from sysconfig import get_path; print(get_path('platlib'))"`
>   for _i in $(ls "$srcdir"/sage-$pkgver/src/sage/ext_data/notebook-ipython); do
>     rm "$pkgdir"/usr/share/jupyter/kernels/sagemath/$_i
>     ln -s $_pythonpath/sage/ext_data/notebook-ipython/$_i "$pkgdir"/usr/share/jupyter/kernels/sagemath/
>   done
> ```

The jupyter kernel spec is fixed right at the top of the `post_install()`.

> which also matches what we were doing previosuly, as well as suggested by sage [docs](https://doc.sagemath.org/html/en/installation/launching.html#setting-up-sagemath-as-a-jupyter-kernel-in-an-existing-jupyter-notebook-or-jupyterlab-installation) Otherwise, it builds and tests fine.

The goal is for the notebook to work out of the box. How are you running it?

I'm just doing
```
$ sagelib -notebook
```
and the browser is launched with a jupyter session in which I can create a new "SageMath 9.5" notebook. It is identical if run as `$ jupyter notebook`. It also works fine from jupyterlab (although jupyterlab does NOT work out of the box, see #35341)

Are you sure you don't have leftover cruft from "fixing" of jupyter for the other package? You shouldn't have anything at all in `/usr/share/jupyter` other than what is shipped in this `sagelib` package.


  parent reply	other threads:[~2022-02-01 12:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-01  4:05 [PR PATCH] " tornaria
2022-02-01  9:21 ` dkwo
2022-02-01 10:10 ` dkwo
2022-02-01 10:12 ` dkwo
2022-02-01 10:13 ` dkwo
2022-02-01 12:17 ` tornaria
2022-02-01 12:58 ` tornaria [this message]
2022-02-01 13:32 ` dkwo
2022-02-01 13:32 ` dkwo
2022-02-01 13:32 ` tornaria
2022-02-01 13:32 ` dkwo
2022-02-01 13:39 ` dkwo
2022-02-01 13:55 ` dkwo
2022-02-01 15:14 ` leahneukirchen
2022-02-01 15:25 ` [PR PATCH] [Updated] " tornaria
2022-02-01 15:51 ` tornaria
2022-02-01 21:40 ` leahneukirchen
2022-02-02 21:06 ` tornaria
2022-02-02 21:06 ` [PR PATCH] [Closed]: " tornaria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220201125831.LaQGVcrGwLuqi6a8cRw5z-BmUGO5TTbk095or8GSkOs@z \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).