[PR PATCH] New package: mold-1.0.3

[PR PATCH] New package: mold-1.0.3

[save-buffer]

[-- Attachment #1: Type: text/plain, Size: 1201 bytes --]

There is a new pull request by save-buffer against master on the void-packages repository

https://github.com/save-buffer/void-packages sasha_mold
https://github.com/void-linux/void-packages/pull/35337

New package: mold-1.0.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35337.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sasha_mold-35337.patch --]
[-- Type: text/x-diff, Size: 1111 bytes --]

From c237a9322229ac240ff58cdbe14b9cc2d27434fc Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Mon, 31 Jan 2022 12:00:44 -0800
Subject: [PATCH] New package: mold-1.0.3

---
 srcpkgs/mold/template | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 srcpkgs/mold/template

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
new file mode 100644
index 000000000000..5f1a11d1fffd
--- /dev/null
+++ b/srcpkgs/mold/template
@@ -0,0 +1,20 @@
+# Template file for 'mold'
+pkgname=mold
+version=1.0.3
+revision=1
+arches="x86_64"
+worksrc=mold-${version}
+build_style=gnu-makefile
+hostmakedepends="make cmake pkg-config"
+makedepends="openssl-devel xxHash-devel zlib-devel libstdc++-devel"
+short_desc="High performance linker"
+maintainer="Sasha Krassovsky <krassovskysasha@gmail.com>"
+license="AGPL-3.0-only"
+homepage="https://github.com/rui314/mold"
+distfiles="https://github.com/rui314/mold/archive/refs/tags/v1.0.3.tar.gz"
+checksum="488c12058b4c7c77bff94c6f919e40b2f12c304214e2e0d7d4833c21167837c0"
+
+make_cmd() {
+	make -j${makejobs}
+}
+

Re: [PR PATCH] [Updated] New package: mold-1.0.3

[save-buffer]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

There is an updated pull request by save-buffer against master on the void-packages repository

https://github.com/save-buffer/void-packages sasha_mold
https://github.com/void-linux/void-packages/pull/35337

New package: mold-1.0.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35337.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sasha_mold-35337.patch --]
[-- Type: text/x-diff, Size: 1156 bytes --]

From 0071e4b2b9359b46e1324d1d2de54b19f4dceb2c Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Mon, 31 Jan 2022 12:00:44 -0800
Subject: [PATCH] New package: mold-1.0.3

---
 srcpkgs/mold/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/mold/template

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
new file mode 100644
index 000000000000..3afd3c3ec18d
--- /dev/null
+++ b/srcpkgs/mold/template
@@ -0,0 +1,22 @@
+# Template file for 'mold'
+pkgname=mold
+version=1.0.3
+revision=1
+worksrc=mold-${version}
+build_style=gnu-makefile
+hostmakedepends="make cmake pkg-config"
+makedepends="openssl-devel xxHash-devel zlib-devel libstdc++-devel"
+short_desc="High performance linker"
+maintainer="Sasha Krassovsky <krassovskysasha@gmail.com>"
+license="AGPL-3.0-only"
+homepage="https://github.com/rui314/mold"
+distfiles="https://github.com/rui314/mold/archive/refs/tags/v${version}.tar.gz"
+checksum="488c12058b4c7c77bff94c6f919e40b2f12c304214e2e0d7d4833c21167837c0"
+arches="x86_64"
+
+make_cmd() {
+	make -j${makejobs}
+}
+post_install() {
+	vlicense LICENSE
+}

Re: [PR PATCH] [Updated] New package: mold-1.0.3

[save-buffer]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]

There is an updated pull request by save-buffer against master on the void-packages repository

https://github.com/save-buffer/void-packages sasha_mold
https://github.com/void-linux/void-packages/pull/35337

New package: mold-1.0.3
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/35337.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-sasha_mold-35337.patch --]
[-- Type: text/x-diff, Size: 1143 bytes --]

From cb1a5264ad56f0d089ee8d414df9b25f68b5f7b3 Mon Sep 17 00:00:00 2001
From: Sasha Krassovsky <krassovskysasha@gmail.com>
Date: Mon, 31 Jan 2022 12:00:44 -0800
Subject: [PATCH] New package: mold-1.0.3

---
 srcpkgs/mold/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/mold/template

diff --git a/srcpkgs/mold/template b/srcpkgs/mold/template
new file mode 100644
index 000000000000..43eb932a94d3
--- /dev/null
+++ b/srcpkgs/mold/template
@@ -0,0 +1,22 @@
+# Template file for 'mold'
+pkgname=mold
+version=1.0.3
+revision=1
+archs="x86_64 aarch64 i686"
+build_style=gnu-makefile
+hostmakedepends="make cmake pkg-config"
+makedepends="openssl-devel xxHash-devel zlib-devel libstdc++-devel"
+short_desc="High performance linker"
+maintainer="Sasha Krassovsky <krassovskysasha@gmail.com>"
+license="AGPL-3.0-only"
+homepage="https://github.com/rui314/mold"
+distfiles="https://github.com/rui314/mold/archive/refs/tags/v${version}.tar.gz"
+checksum="488c12058b4c7c77bff94c6f919e40b2f12c304214e2e0d7d4833c21167837c0"
+
+do_build() {
+	make ${makejobs}
+}
+
+post_install() {
+	vlicense LICENSE
+}

Re: New package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35337#issuecomment-1027748967

Comment:
There's another PR for mold [here](https://github.com/void-linux/void-packages/pull/35305).

Re: [PR REVIEW] New package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35337#discussion_r797422262

Comment:
Why overwrite the `do_build` in `gnu-makefile` buildstyle?

Re: [PR REVIEW] New package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New review comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35337#discussion_r797422668

Comment:
Why limit the archs? I'm able to build it on musl arch.

Re: [PR PATCH] [Closed]: New package: mold-1.0.3

[save-buffer]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

There's a closed pull request on the void-packages repository

New package: mold-1.0.3
https://github.com/void-linux/void-packages/pull/35337

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [quality requirements](https://github.com/void-linux/void-packages/blob/master/Manual.md#quality-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please [skip CI](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration)
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!-- 
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: New Package: mold-1.0.3

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1048067713

Comment:
#31706 is packaging mimalloc separately, and pass more tests

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 1210 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. Consider using `checkdepends` if `clang` is only needed for the checks.

In general, it is heavily preferred to try and fix checks rather than abandon them. From [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md):
> Runtime testing of packages and building with the -Q flag or with XBPS_CHECK_PKGS=yes set in the environment or etc/conf are strongly encouraged. New packages will not be accepted unless they have been runtime tested.

Keep in mind, *they* do checks for a release build. When we fetch and build it, it's important to check it.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046670284

Comment:
Yes. You can skip CI while you're working on a package. See [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md).
> Continuous Integration

> Pull requests are automatically submitted for Continuous Integration (CI) testing to ensure packages build and pass their tests (on native builds) on various combinations of C library and architecture. Packages that take longer than 120 minutes or need more than 14G of storage to complete their build (for example, Firefox or the Linux kernel) will fail CI and should include [ci skip] in the PR title or body (the comment field when the PR is being opened) to avoid wasting CI builder time.

You can also name PR to `[WIP] New package: mold-1.1` (the p in package is technically supposed to be lowercase) to indicate that the package is still being worked on.

Executive summary:
* put `[ci skip]` in your PR.
* put [WIP] in PR name

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. Consider using `checkdepends` if `clang` is only needed for the checks.

In general, it is heavily preferred to try and fix checks rather than abandon them. From [CONTRIBUTING.md](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md):
> Runtime testing of packages and building with the -Q flag or with XBPS_CHECK_PKGS=yes set in the environment or etc/conf are strongly encouraged. New packages will not be accepted unless they have been runtime tested.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. It is preferred to try and fix checks rather than abandon them. Consider using `checkdepends` if `clang` is only needed for the checks.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046583054

Comment:
From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `checkdepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. Consider using `checkdepends` if `clang` is only needed for the checks.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 692 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046674450

Comment:
> > From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.
> 
> Can't I skip tests? As it's a release build and already go through a lot of tests.

Do not skip checks. It reduces quality of packages. If upstream provides checks, use them. Consider using checkdepends if `clang` is only needed for the checks.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046670284

Comment:
Yes. You can skip CI while you're working on a package. See [Contributing](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md).
> Continuous Integration

> Pull requests are automatically submitted for Continuous Integration (CI) testing to ensure packages build and pass their tests (on native builds) on various combinations of C library and architecture. Packages that take longer than 120 minutes or need more than 14G of storage to complete their build (for example, Firefox or the Linux kernel) will fail CI and should include [ci skip] in the PR title or body (the comment field when the PR is being opened) to avoid wasting CI builder time.

You can also name PR to `[WIP] New package: mold-1.1` (the p in package is technically supposed to be lowercase) to indicate that the package is still being worked on.

Executive summary:
* put `[ci skip]` in your PR.
* put [WIP] in PR name

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046670284

Comment:
Yes. You can skip CI while you're working on a package. See [Contributing](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md).
> Continuous Integration

> Pull requests are automatically submitted for Continuous Integration (CI) testing to ensure packages build and pass their tests (on native builds) on various combinations of C library and architecture. Packages that take longer than 120 minutes or need more than 14G of storage to complete their build (for example, Firefox or the Linux kernel) will fail CI and should include [ci skip] in the PR title or body (the comment field when the PR is being opened) to avoid wasting CI builder time.

Re: New Package: mold-1.0.3

[basicfunc]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

New comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046648050

Comment:
> From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.

Can't I skip tests? As it's a release build and already go through a lot of tests.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 434 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046583054

Comment:
From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times. If you want to review them here, try adding `ci-skip` to the PR.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046583054

Comment:
From the CI: `Testing emit-relocs ... ./elf/emit-relocs.sh: line 19: clang: command not found` You might try adding `clang` to `hostmakedepends`. Try getting a successful local build before pushing through CI several times

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046532108

Comment:
Squash your 6 commits to 1. `git rebase -i HEAD~6` and squash the last 5. Commit message should just be "New package: mold-1.0.3" Also consider updating the PR name itself to reflect the new version.

Re: New Package: mold-1.0.3

[kawaiiamber]

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by kawaiiamber on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046532108

Comment:
Squash your 6 commits to 1. `git rebase -i HEAD~6` and squash the last 5. Commit message should just be "New package: mold-1.0.3"

Re: New Package: mold-1.0.3

[basicfunc]

[-- Attachment #1: Type: text/plain, Size: 209 bytes --]

New comment by basicfunc on void-packages repository

https://github.com/void-linux/void-packages/pull/35361#issuecomment-1046528735

Comment:
@paper42 @kawaiiamber, I updated mold to v1.1, can you review it.