Github messages for voidlinux
 help / color / mirror / Atom feed
From: leahneukirchen <leahneukirchen@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Merged]: nauty: disable native code (illegal instructions)
Date: Thu, 03 Feb 2022 13:56:30 +0100	[thread overview]
Message-ID: <20220203125630.sB4G_M6FaKoebLAciKOUT-W82AAB39WscWVbF_vOCzs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35367@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

There's a merged pull request on the void-packages repository

nauty: disable native code (illegal instructions)
https://github.com/void-linux/void-packages/pull/35367

Description:
The package currently shipped in void gives me illegal instructions in a
nehalem cpu.

This commit fixes the issue by disabling native compilation unless a build
option is given; also disable popcnt which, although available on nehalem, is
not available in baseline x86_64.

An easy way to spot the issue is to run something like:
```
$ geng 2
>A geng -d0D1 n=2 e=0-1
Illegal instruction
```

#### Testing the changes
- I tested the changes in this PR: **YES**

I compiled with `./xbps-src build nauty` on a cascade lake cpu, then run `./xbps-src check nauty` on a nehalem cpu. This breaks before the present PR, and works ok after.

I also tested sagemath: previously I was getting a lot of doctest failures which are now fixed.

Cc: @leahneukirchen please merge this before sagemath.

      reply	other threads:[~2022-02-03 12:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-03  0:29 [PR PATCH] " tornaria
2022-02-03 12:56 ` leahneukirchen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220203125630.sB4G_M6FaKoebLAciKOUT-W82AAB39WscWVbF_vOCzs@z \
    --to=leahneukirchen@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).