Github messages for voidlinux
 help / color / mirror / Atom feed
From: paper42 <paper42@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] unicorn-python: remove package
Date: Fri, 04 Feb 2022 22:39:40 +0100	[thread overview]
Message-ID: <20220204213940.HiV3fAo5UV04CVziIaP2LvOUZJZEhUiM4Ea4gvbpqCY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-35365@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

There is an updated pull request by paper42 against master on the void-packages repository

https://github.com/paper42/void-packages unicorn-python
https://github.com/void-linux/void-packages/pull/35365

unicorn-python: remove package
@Piraty 

#### Testing the changes
- I tested the changes in this PR: **briefly**

A patch file from https://github.com/void-linux/void-packages/pull/35365.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-unicorn-python-35365.patch --]
[-- Type: text/x-diff, Size: 2868 bytes --]

From 72bf8c5d40295c00eaa758cb95ed3c10c72c2a97 Mon Sep 17 00:00:00 2001
From: Michal Vasilek <michal@vasilek.cz>
Date: Thu, 3 Feb 2022 00:10:47 +0100
Subject: [PATCH] unicorn-python: remove package

* python2 bindings, unused
---
 srcpkgs/removed-packages/template |  2 ++
 srcpkgs/unicorn-python            |  1 -
 srcpkgs/unicorn/template          | 22 +++-------------------
 3 files changed, 5 insertions(+), 20 deletions(-)
 delete mode 120000 srcpkgs/unicorn-python

diff --git a/srcpkgs/removed-packages/template b/srcpkgs/removed-packages/template
index 50a0a2c34756..6f7a3314ed44 100644
--- a/srcpkgs/removed-packages/template
+++ b/srcpkgs/removed-packages/template
@@ -280,6 +280,7 @@ replaces="
  python-pytest-relaxed<=1.1.2_2
  python-requests<=2.26.0_2
  python-sqlite<=2.8.3_1
+ python-unicorn>=0
  python-urllib3<=1.26.6_2
  python-xlib<0.29_1
  python3-Django<=3.0.7_2
@@ -341,6 +342,7 @@ replaces="
  traverso<=0.49.6_2
  ttyload-git<=20141117_4
  tuxc<=1.1_3
+ unicorn-python<=1.0.2_2
  urlmatch-git<=20141116_2
  uwsgi-python<=2.0.18_3
  v8<=3.24.35.33_4
diff --git a/srcpkgs/unicorn-python b/srcpkgs/unicorn-python
deleted file mode 120000
index 20c8576391e6..000000000000
--- a/srcpkgs/unicorn-python
+++ /dev/null
@@ -1 +0,0 @@
-unicorn
\ No newline at end of file
diff --git a/srcpkgs/unicorn/template b/srcpkgs/unicorn/template
index 2389b1ca9869..c0e7bf419b9e 100644
--- a/srcpkgs/unicorn/template
+++ b/srcpkgs/unicorn/template
@@ -2,7 +2,7 @@
 pkgname=unicorn
 version=1.0.2
 revision=2
-hostmakedepends="python-devel python3-devel python-setuptools python3-setuptools"
+hostmakedepends="python3-devel python3-setuptools"
 short_desc="Lightweight multi-platform, multi-architecture CPU emulator framework"
 maintainer="Piraty <piraty1@inbox.ru>"
 license="GPL-2.0-only"
@@ -19,18 +19,13 @@ do_build() {
 	make $makejobs
 	make $makejobs -C bindings
 	cd bindings/python
-	for pyver in $py2_ver $py3_ver; do
-		python${pyver} setup.py build --build-base=build-${pyver}
-	done
+	python3 setup.py build
 }
 
 do_install() {
 	make DESTDIR=${DESTDIR} install
 	cd bindings/python
-	for pyver in $py2_ver $py3_ver; do
-		python${pyver} setup.py build --build-base=build-${pyver} \
-			install --prefix=/usr --root=${DESTDIR}
-	done
+	python3 setup.py build install --prefix=/usr --root=${DESTDIR}
 }
 
 unicorn-devel_package() {
@@ -44,20 +39,9 @@ unicorn-devel_package() {
 	}
 }
 
-unicorn-python_package() {
-	replaces="python-unicorn>=0"
-	depends="${sourcepkg}-devel>=${version}_${revision} python-setuptools"
-	short_desc+=" - Python2 bindings"
-	pycompile_module="unicorn"
-	pkg_install() {
-		vmove ${py2_sitelib}
-	}
-}
-
 unicorn-python3_package() {
 	depends="${sourcepkg}-devel>=${version}_${revision} python3-setuptools"
 	short_desc+=" - Python3 bindings"
-	pycompile_module="unicorn"
 	pkg_install() {
 		vmove ${py3_sitelib}
 	}

  parent reply	other threads:[~2022-02-04 21:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-02 23:18 [PR PATCH] MoinMoin: " paper42
2022-02-03  1:38 ` [PR REVIEW] unicorn-python: " abenson
2022-02-03  1:39 ` abenson
2022-02-04 21:39 ` paper42 [this message]
2022-02-04 21:40 ` paper42
2022-02-04 21:41 ` paper42
2022-02-05  1:59 ` [PR PATCH] [Merged]: " paper42
2022-02-06 15:10 ` Piraty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220204213940.HiV3fAo5UV04CVziIaP2LvOUZJZEhUiM4Ea4gvbpqCY@z \
    --to=paper42@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).